Skip to content

fix(cli-tutor): wrap async resource reducer instead of replacing it#2478

Merged
lidel merged 1 commit intomainfrom
fix/cli-tutor-mode-crash
Feb 17, 2026
Merged

fix(cli-tutor): wrap async resource reducer instead of replacing it#2478
lidel merged 1 commit intomainfrom
fix/cli-tutor-mode-crash

Conversation

@lidel
Copy link
Member

@lidel lidel commented Feb 17, 2026

the custom reducer used state={} as default, losing fields like errorTimes that createAsyncResourceBundle's auto-generated selectors expect. this caused "can't access property 'slice', resource.errorTimes is undefined" crash when localStorage.debug is set (redux-bundler debug mode evaluates all selectors on startup).

follow the same pattern as peers.js: delegate to the original reducer and layer custom actions on top.

the custom reducer used state={} as default, losing fields like
errorTimes that createAsyncResourceBundle's auto-generated selectors
expect. this caused "can't access property 'slice', resource.errorTimes
is undefined" crash when localStorage.debug is set (redux-bundler debug
mode evaluates all selectors on startup).

follow the same pattern as peers.js: delegate to the original reducer
and layer custom actions on top.
@lidel lidel requested a review from a team as a code owner February 17, 2026 00:36
@lidel lidel merged commit 0468b72 into main Feb 17, 2026
11 checks passed
@lidel lidel deleted the fix/cli-tutor-mode-crash branch February 17, 2026 00:44
ipfs-gui-bot pushed a commit that referenced this pull request Feb 17, 2026
## [4.11.1](v4.11.0...v4.11.1) (2026-02-17)

 CID `bafybeiddnr2jz65byk67sjt6jsu6g7tueddr7odhzzpzli3rgudlbnc6iq`

 ---

### Bug Fixes

* **cli-tutor:** wrap async resource reducer instead of replacing it ([#2478](#2478)) ([0468b72](0468b72))
* **modal:** center overlays using flexbox via renderDialog ([#2477](#2477)) ([9db5775](9db5775))
* **peers:** accept /p2p/ prefix in peer filter input ([#2475](#2475)) ([c86d151](c86d151)), closes [#2468](#2468)

### Trivial Changes

* pull transifex translations ([#2474](#2474)) ([6cb5fd5](6cb5fd5))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants