Skip to content

fix(upload): prevent memory leaks from retained jobs #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itinance merged 1 commit into from
Jun 9, 2018
Merged

fix(upload): prevent memory leaks from retained jobs #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RNFSManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@ + (BOOL)requiresMainQueueSetup
params.method = method;

params.completeCallback = ^(NSString* body, NSURLResponse *resp) {
[self.uploaders removeObjectForKey:[jobId stringValue]];

NSMutableDictionary* result = [[NSMutableDictionary alloc] initWithDictionary: @{@"jobId": jobId,
@"body": body}];
Expand All @@ -570,6 +571,7 @@ + (BOOL)requiresMainQueueSetup
};

params.errorCallback = ^(NSError* error) {
[self.uploaders removeObjectForKey:[jobId stringValue]];
return [self reject:reject withError:error];
};

Expand Down