nixos/renovate: set service type to simple (NixOS#334557)

Author: SuperSandro2000

nixos/modules/services/misc/renovate.nix

@@ -100,12 +100,10 @@ in
       ] ++ cfg.runtimePackages;
 
       serviceConfig = {
-        Type = "oneshot";
         User = "renovate";
         Group = "renovate";
         DynamicUser = true;
         LoadCredential = lib.mapAttrsToList (name: value: "SECRET-${name}:${value}") cfg.credentials;
-        RemainAfterExit = false;
         Restart = "on-failure";
         CacheDirectory = "renovate";
         StateDirectory = "renovate";

nixos/tests/renovate.nix

@@ -58,12 +58,12 @@ import ./make-test-python.nix (
       machine.succeed("git -C /tmp/kitty push origin")
 
       machine.succeed(f"echo '{accessToken}' > /etc/renovate-token")
-      machine.systemctl("start renovate.service")
+      machine.systemctl("start --wait renovate.service")
 
       machine.succeed("tea pulls list --repo meow/kitty | grep 'Configure Renovate'")
       machine.succeed("tea pulls merge --repo meow/kitty 1")
 
-      machine.systemctl("start renovate.service")
+      machine.systemctl("start --wait renovate.service")
     '';
   }
 )