Merge pull request #48 from ivyleavedtoadflax/feature/improve-ci-pipeline

feat: Improve CI/CD pipeline with test coverage

Author: ivyleavedtoadflax

.github/workflows/test.yml

@@ -33,9 +33,9 @@ jobs:
       run: |
         uv run ruff format --check .
 
-    - name: Run tests with pytest
+    - name: Run tests with pytest and coverage
       run: |
-        uv run pytest -v --tb=short
+        uv run pytest -v --tb=short --cov=remotepy --cov-report=term-missing
       env:
         AWS_DEFAULT_REGION: us-east-1
         AWS_ACCESS_KEY_ID: dummy

.pre-commit-config.yaml

@@ -1,31 +1,31 @@
-default_stages: [pre-push]
-
-repos:
-  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.8.4
-    hooks:
-      # 1. Ruff lint (check-only)
-      - id: ruff
-        name: ruff-check
-        args: []
-
-      # 2. Ruff fix (format)
-      - id: ruff
-        name: ruff-fix
-        args: [--fix]
-        stages: [manual]  # only runs if you explicitly run it
-
-      # 3. Ruff formatter
-      - id: ruff-format
-        stages: [manual]  # also opt-in, to avoid auto-formatting on push
-
-  - repo: local
-    hooks:
-      - id: pytest
-        name: pytest
-        entry: uv run pytest
-        language: system
-        pass_filenames: false
-        always_run: true
-        stages: [pre-push]
-
+default_stages: [pre-push]
+
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.8.4
+    hooks:
+      # 1. Ruff lint (check-only)
+      - id: ruff
+        name: ruff-check
+        args: []
+
+      # 2. Ruff fix (format)
+      - id: ruff
+        name: ruff-fix
+        args: [--fix]
+        stages: [manual]  # only runs if you explicitly run it
+
+      # 3. Ruff formatter
+      - id: ruff-format
+        stages: [pre-push]  # automatically format on push
+
+  - repo: local
+    hooks:
+      - id: pytest
+        name: pytest
+        entry: uv run pytest
+        language: system
+        pass_filenames: false
+        always_run: true
+        stages: [pre-push]
+

pyproject.toml

@@ -76,10 +76,66 @@ line-ending = "auto"
 dev = [
     "pre-commit>=4.2.0",
     "pytest>=8.4.1",
+    "pytest-cov>=6.2.1",
     "pytest-mock>=3.14.1",
     "ruff>=0.12.0",
     "tox>=4.27.0",
 ]
 
 [tool.ruff.lint.isort]
 known-first-party = ["src"]
+
+# ============================================================================
+# Test Coverage Configuration
+# ============================================================================
+
+[tool.coverage.run]
+source = ["remotepy"]
+omit = [
+    "tests/*",
+    "remotepy/__init__.py",
+    "*/__pycache__/*",
+    "*/migrations/*",
+    "*/venv/*",
+    "*/.venv/*",
+]
+
+[tool.coverage.report]
+exclude_lines = [
+    "pragma: no cover",
+    "def __repr__",
+    "if self.debug:",
+    "if settings.DEBUG",
+    "raise AssertionError",
+    "raise NotImplementedError",
+    "if 0:",
+    "if __name__ == .__main__.:",
+    "class .*\bProtocol\\):",
+    "@(abc\\.)?abstractmethod",
+]
+show_missing = true
+skip_covered = false
+skip_empty = false
+
+# Minimum coverage thresholds - fail if below these percentages
+fail_under = 85
+precision = 1
+
+[tool.coverage.html]
+directory = "htmlcov"
+title = "RemotePy Test Coverage Report"
+
+[tool.coverage.xml]
+output = "coverage.xml"
+
+# Per-module minimum coverage requirements
+[tool.coverage.report.coverage_thresholds]
+# Core modules should maintain high coverage
+"remotepy/utils.py" = 95
+"remotepy/config.py" = 90
+"remotepy/ecs.py" = 95
+"remotepy/instance.py" = 60  # Allow lower for now due to complex CLI interactions
+"remotepy/ami.py" = 95
+"remotepy/volume.py" = 90
+"remotepy/snapshot.py" = 90
+"remotepy/__main__.py" = 90

remotepy/ami.py

@@ -188,7 +188,6 @@ def launch(
     """
 
     # if no launch template is specified, list all the launch templates
-
     if not launch_template:
         typer.secho("Please specify a launch template", fg=typer.colors.RED)
         typer.secho("Available launch templates:", fg=typer.colors.YELLOW)
@@ -205,9 +204,12 @@ def launch(
             fg=typer.colors.YELLOW,
         )
         typer.secho(f"Launching instance based on launch template {launch_template_name}")
+    else:
+        # launch template name was provided, get the ID and set variables
+        launch_template_name = launch_template
+        launch_template_id = get_launch_template_id(launch_template)
 
     # if no name is specified, ask the user for the name
-
     if not name:
         random_string = "".join(random.choices(string.ascii_letters + string.digits, k=6))
         name_suggestion = launch_template_name + "-" + random_string