refactor: Use config_manager.remove_value() in unset_value command (#63)

The unset_value() CLI command was directly manipulating the config file
instead of using the ConfigManager.remove_value() method like other
similar commands (set_value, add). This violated encapsulation and
missed proper state management (cache invalidation).

Also fixed ConfigManager.remove_value() to read from the specified
config_path parameter instead of the default path.

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 8c0f8ca)

Author: ivyleavedtoadflax

progress.md

@@ -780,3 +780,30 @@ This places the comment immediately before the code it documents, following the
 
 ---
 
+## 2026-01-18: Use `config_manager.remove_value()` in `unset_value()` CLI command
+
+**File:** `remote/config.py`
+
+**Issue:** The `unset_value()` CLI command (lines 500-519) bypassed the `ConfigManager.remove_value()` method and directly manipulated the config file, while other similar CLI commands properly used the ConfigManager abstraction:
+
+- `set_value()` correctly used `config_manager.set_value(key, value, config_path)` (line 472)
+- `add()` correctly used `config_manager.set_instance_name(instance_name, config_path)` (line 449)
+- `unset_value()` incorrectly bypassed the manager:
+  ```python
+  config = read_config(config_path)
+  config.remove_option("DEFAULT", key)
+  write_config(config, config_path)
+  ```
+
+This was problematic because:
+1. **Violated encapsulation**: The proper `ConfigManager.remove_value()` method exists but wasn't used
+2. **Broke consistency**: Other similar operations use the manager abstraction
+3. **Missing state management**: `ConfigManager.remove_value()` properly resets the cached pydantic config with `self._pydantic_config = None`, but the direct approach didn't, which could lead to stale cached configuration data
+
+**Changes:**
+- Replaced direct config file manipulation with `config_manager.remove_value(key, config_path)`
+- Simplified the logic using the boolean return value to check if the key existed
+- Reduced code duplication by using the existing abstraction
+
+---
+

remote/config.py

@@ -320,17 +320,17 @@ def remove_value(self, key: str, config_path: str | None = None) -> bool:
         if config_path is None:
             config_path = str(Settings.get_config_path())
 
-        # Reload config to get latest state
-        self.reload()
-        config = self.file_config
+        # Read from specified config path
+        config = read_config(config_path)
 
         if "DEFAULT" not in config or key not in config["DEFAULT"]:
             return False
 
         config.remove_option("DEFAULT", key)
         write_config(config, config_path)
 
-        # Reset pydantic config to reload on next access
+        # Reset cached configs to reload on next access
+        self._file_config = None
         self._pydantic_config = None
         return True
 
@@ -508,14 +508,10 @@ def unset_value(
     Examples:
         remote config unset ssh_key_path
     """
-    config = read_config(config_path)
-
-    if "DEFAULT" not in config or key not in config["DEFAULT"]:
+    if not config_manager.remove_value(key, config_path):
         typer.secho(f"Key '{key}' not found in config", fg=typer.colors.YELLOW)
         raise typer.Exit(1)
 
-    config.remove_option("DEFAULT", key)
-    write_config(config, config_path)
     typer.secho(f"Removed {key}", fg=typer.colors.GREEN)