refactor: Rename in_duration parameter to stop_in for consistency (#33)

The stop() function used parameter name 'in_duration' while the start()
function used 'stop_in' for the same purpose (scheduling automatic
shutdown). This inconsistency created cognitive overhead.

Renamed the parameter to 'stop_in' to match the pattern used in start().
The CLI flag '--in' remains unchanged for backwards compatibility.

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 5e34587)

Author: ivyleavedtoadflax

progress.md

@@ -167,3 +167,20 @@ This is similar to the `ec2_client` shim that was removed from `utils.py` in a p
 **Changes:**
 - Removed the unused `ENV_PREFIX = "REMOTE_"` constant
 - Removed the associated comment "Environment variable mapping for config values"
+
+---
+
+## 2026-01-18: Rename `in_duration` parameter to `stop_in` for consistency
+
+**File:** `remote/instance.py`
+
+**Issue:** The `stop()` function used parameter name `in_duration` while the `start()` function used `stop_in` for the same purpose (scheduling automatic shutdown). This inconsistency created cognitive overhead when working with both functions:
+- `start()` (line 375): parameter `stop_in` with CLI flag `--stop-in`
+- `stop()` (line 601): parameter `in_duration` with CLI flag `--in`
+
+Both parameters serve the same purpose: specifying a duration after which the instance should be stopped.
+
+**Changes:**
+- Renamed `in_duration` to `stop_in` in the `stop()` function signature (line 601)
+- Updated all references to `in_duration` within the function body (lines 641, 649)
+- The CLI flag `--in` remains unchanged for backwards compatibility

remote/instance.py

@@ -598,7 +598,7 @@ def _cancel_scheduled_shutdown(instance_name: str, instance_id: str) -> None:
 @app.command()
 def stop(
     instance_name: str | None = typer.Argument(None, help="Instance name"),
-    in_duration: str | None = typer.Option(
+    stop_in: str | None = typer.Option(
         None,
         "--in",
         help="Schedule stop after duration (e.g., 3h, 30m, 1h30m). Uses SSH to run 'shutdown -h'.",
@@ -638,15 +638,15 @@ def stop(
         return
 
     # Handle scheduled shutdown
-    if in_duration:
+    if stop_in:
         if not is_instance_running(instance_id):
             typer.secho(
                 f"Instance {instance_name} is not running - cannot schedule shutdown",
                 fg=typer.colors.YELLOW,
             )
             return
         try:
-            minutes = parse_duration_to_minutes(in_duration)
+            minutes = parse_duration_to_minutes(stop_in)
             _schedule_shutdown(instance_name, instance_id, minutes)
         except ValidationError as e:
             typer.secho(f"Error: {e}", fg=typer.colors.RED)