Merge pull request #21 from ivyleavedtoadflax/fix/issue-36-config-validate-output

fix: Remove hardcoded console width and simplify validate output

Author: ivyleavedtoadflax

remote/config.py

@@ -15,7 +15,7 @@
 from remote.utils import get_instance_ids, get_instance_info, get_instances
 
 app = typer.Typer()
-console = Console(force_terminal=True, width=200)
+console = Console(force_terminal=True)
 
 # Valid configuration keys with descriptions
 VALID_KEYS: dict[str, str] = {
@@ -586,23 +586,17 @@ def validate(
     for warning in result.warnings:
         output_lines.append(f"[yellow]⚠ WARNING:[/yellow] {warning}")
 
-    # Determine status
+    # Determine status and border style
     if not result.is_valid:
-        status = "[red]Status: Invalid - errors must be fixed[/red]"
+        output_lines.append("[red]✗ Configuration is invalid[/red]")
         border_style = "red"
     elif result.warnings:
-        status = "[yellow]Status: Has warnings but usable[/yellow]"
+        output_lines.append("[yellow]⚠ Configuration has warnings[/yellow]")
         border_style = "yellow"
     else:
-        output_lines.append("[green]✓ All checks passed[/green]")
-        status = "[green]Status: Valid[/green]"
+        output_lines.append("[green]✓ Configuration is valid[/green]")
         border_style = "green"
 
-    # Add status line
-    if output_lines:
-        output_lines.append("")
-    output_lines.append(status)
-
     # Display as Rich panel
     panel_content = "\n".join(output_lines)
     panel = Panel(panel_content, title="Config Validation", border_style=border_style)

specs/issue-36-config-validate-output.md

@@ -0,0 +1,61 @@
+# Issue 36: Config Validate Panel Too Wide
+
+**Status:** COMPLETED
+**Priority:** Low
+**Target Version:** v1.1.0
+**Files:** `remote/config.py`, `tests/test_config.py`
+
+## Problem
+
+The `remote config validate` command had two issues:
+
+1. **Panel stretches beyond console width**: The Rich Console was created with a hardcoded `width=200`, causing the validation panel to stretch beyond the actual terminal width.
+
+2. **Redundant output messages**: When config is valid, the output showed both:
+   - "All checks passed"
+   - "Status: Valid"
+
+This was redundant - only one success message is needed.
+
+## Solution
+
+### 1. Remove hardcoded console width
+
+Changed from:
+```python
+console = Console(force_terminal=True, width=200)
+```
+
+To:
+```python
+console = Console(force_terminal=True)
+```
+
+This allows Rich to automatically detect and use the terminal's actual width.
+
+### 2. Simplify validation output
+
+Replaced the redundant output with a single, clear status message:
+
+- Invalid: "Configuration is invalid" (red)
+- Warnings: "Configuration has warnings" (yellow)
+- Valid: "Configuration is valid" (green)
+
+## Changes Made
+
+### `remote/config.py`
+- Line 18: Removed `width=200` from Console initialization
+- Lines 589-604: Simplified validation output to show single status message
+
+### `tests/test_config.py`
+- Line 616: Updated test assertion from "Status: Valid" to "Configuration is valid"
+
+## Acceptance Criteria
+
+- [x] Console uses terminal's actual width instead of hardcoded 200
+- [x] Valid config shows single "Configuration is valid" message
+- [x] Invalid config shows errors plus "Configuration is invalid" message
+- [x] Config with warnings shows warnings plus "Configuration has warnings" message
+- [x] All tests pass
+- [x] Type check passes
+- [x] Linter passes

specs/plan.md

@@ -70,6 +70,6 @@ Features and improvements for future releases.
 | Order | ID | Issue | Rationale | Spec | Status |
 |-------|-----|-------|-----------|------|--------|
 | 18 | 35 | Built-in watch mode | Fix garbled output when using `watch` command with Rich | [issue-35](./issue-35-watch-mode.md) | COMPLETED |
-| 19 | 36 | Config validate panel too wide | Panel stretches beyond console width; also redundant "All checks passed" and "Status: Valid" | [issue-36](./issue-36-config-validate-output.md) | TODO |
+| 19 | 36 | Config validate panel too wide | Panel stretches beyond console width; also redundant "All checks passed" and "Status: Valid" | [issue-36](./issue-36-config-validate-output.md) | COMPLETED |
 | 20 | 37 | Pricing API region fallback | Pricing API only works in us-east-1; fallback to us-east-1 pricing for other regions | [issue-37](./issue-37-pricing-region-fallback.md) | TODO |
 | 21 | 38 | Instance cost command | Add command to show estimated cost of instance based on uptime | [issue-38](./issue-38-instance-cost-command.md) | TODO |

tests/test_config.py

@@ -613,7 +613,7 @@ def test_validate_valid_config(self, tmpdir):
         assert result.exit_code == 0
         # Rich panel displays validation result
         assert "Config Validation" in result.stdout
-        assert "Status: Valid" in result.stdout
+        assert "Configuration is valid" in result.stdout
 
     def test_validate_missing_config(self, tmpdir):
         """Should report missing config file."""