Fix crash when NPC trying use destroyed object

Author: v2v3v4

src/xrGame/danger_manager.cpp

@@ -234,7 +234,7 @@ float CDangerManager::do_evaluate	(const CDangerObject &object) const
 
 void CDangerManager::add			(const CVisibleObject &object)
 {
-	if (!object.m_enabled)
+	if (!object.m_enabled || object.m_object->getDestroy())
 		return;
 
 	const CEntityAlive		*obj = smart_cast<const CEntityAlive*>(object.m_object);
@@ -246,7 +246,7 @@ void CDangerManager::add			(const CVisibleObject &object)
 
 void CDangerManager::add			(const CSoundObject &object)
 {
-	if (!object.m_enabled)
+	if (!object.m_enabled || object.m_object->getDestroy())
 		return;
 
 	const CEntityAlive		*obj = smart_cast<const CEntityAlive*>(object.m_object);
@@ -286,7 +286,7 @@ void CDangerManager::add			(const CSoundObject &object)
 
 void CDangerManager::add			(const CHitObject &object)
 {
-	if (!object.m_enabled)
+	if (!object.m_enabled || object.m_object->getDestroy())
 		return;
 
 	if (fis_zero(object.m_amount))

src/xrGame/item_manager.cpp

@@ -35,18 +35,28 @@ bool CItemManager::is_useful		(const CGameObject *object) const
 
 bool CItemManager::useful			(const CGameObject *object) const
 {
+	if (object->getDestroy())
+		return false;
+
+	if (!object->getEnabled())
+		return false;
+
+	if (!&object->ai_location())
+		return false;
+
 	if (!inherited::is_useful(object))
-		return				(false);
+		return false;
 
 	if (m_object->getDestroy())
-		return				(false);
+		return false;
 
 	// we do not want to keep in memory attached objects
 	if (m_object->H_Parent())
-		return				(false);
+		return false;
 
-	if (!const_cast<CGameObject*>(object)->UsedAI_Locations())
-		return				(false);
+	auto gameObject = const_cast<CGameObject*>(object);
+	if (gameObject == nullptr && gameObject->UsedAI_Locations())
+		return false;
 
 	if (!m_object->movement().restrictions().accessible(object->Position()))
 		return				(false);

src/xrGame/memory_manager.cpp

@@ -170,10 +170,14 @@ void CMemoryManager::update			(const xr_vector<T> &objects, bool add_enemies)
 		if (m_stalker && !(*I).m_squad_mask.test(mask))
 			continue;
 
+		if ((*I).m_object->getDestroy()) {
+			continue;
+		}
+
 		danger().add				(*I);
 
 		if (add_enemies) {
-			const CEntityAlive		*entity_alive = smart_cast<const CEntityAlive*>((*I).m_object);
+			const CEntityAlive *entity_alive = smart_cast<const CEntityAlive*>((*I).m_object);
 			if (entity_alive && enemy().add(entity_alive))
 				continue;
 		}