feat(v0.9): Phase 7 — CategoryTab sectioning#73
Merged
Conversation
Replace the flat A–Z list per category with a sectioned page: Leaving this month / Available now / Out of season / Already donated. Empty groups hidden; donated items always land in Already donated. December→January wrap handled. Fossils/art (no months) collapse cleanly to Available now + Already donated. CategoryTab owns its own expandedId so only one row is open per tab and reacts to highlightId so jumps from Home shelves expand the row before ACCanvas's scroll-to fires. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Implements Phase 7 of the v0.9 UI revamp by moving category pages (fish/bugs/fossils/art/sea creatures) onto a new CategoryTab component that sections items into seasonally-aware groups and adds a new category header presentation.
Changes:
- Added
CategoryTabto own category-page header UI, per-tab search UI, section grouping (Leaving / Available / Out of season / Already donated), and per-tab inline row expansion state. - Refactored
ACCanvasto delegate category rendering toCategoryTabwhile keeping existing highlight scroll/pulse behavior and art modal behavior. - Appended Phase 7 styling for the new header and grouped sections, and updated docs/changelog to mark Phase 7 complete.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.css | Adds layout + typography styles for the new category header and section group headers/counts. |
| src/components/CategoryTab.tsx | New component implementing section grouping, per-tab search UI, and per-tab expandedId handling (with highlightId expansion for non-art). |
| src/components/ACCanvas.tsx | Replaces inline category list render with CategoryTab and removes now-unneeded local expansion/filtering logic. |
| docs/v0.9-plan.md | Marks Phase 7 as complete. |
| CLAUDE.md | Updates component inventory to include CategoryTab. |
| CHANGELOG.md | Documents Phase 7 additions/removals/decisions for v0.9.0-beta. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Surfaced during review — filed #74 for follow-up (missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 7 of the v0.9.0-beta UI revamp — rebuild the category pages (fish, bugs, fossils, art, sea creatures) on top of the row primitives that landed in Phase 5.
The flat A–Z list is replaced by four ordered sections, each with an eyebrow header + count:
Empty groups are hidden, so non-seasonal categories (fossils, art) collapse cleanly to Available now + Already donated. Donated items always go to Already donated regardless of season. December→January wrap is handled (
next = currentMonth === 12 ? 1 : currentMonth + 1).A new
CategoryTabcomponent owns the page header (Fraunces 44<em>{donated}</em> of {total} {category}+X% complete+ month note), per-tab search bar, sectioning, andexpandedId(one row open at a time per tab). It reacts tohighlightIdby opening the matching row beforeACCanvas's existing scroll-to effect fires, so jumps from Home shelves land on a pre-expanded row that then pulses.Decisions
CategoryTabso filtering recomputes the section grouping without re-flowing the page header. The header always reflects the full category total — narrowing the list shouldn't make progress look smaller than it is.DetailModalbottom-sheet. The plan's "row click toggles inline expand" applies to fish/bugs/fossils; art was on a different pattern in v0.8 and the v0.9 design preserves it. CategoryTab routes art clicks back up toACCanvasviaonItemSelectand renders no inline panel.ItemExpandPanelcontinues to render as a sibling ofCollectibleRowinside.ac-list— the row primitives are locked from Phase 5 and the existing.ac-row-pulsekeyframe + divider CSS depend on that arrangement.CategoryProgressretained for now. It's no longer referenced fromACCanvas, but the plan calls for retiring it during Phase 9's stats rebuild. Deleting it now would require touching that scope.Test plan
npm run buildpasses (zero TS errors)npm testpasses (63/63)npm run lintcleanCloses Phase 7 of
docs/v0.9-plan.md.🤖 Generated with Claude Code