Move param type conversion util out of tracestore API into v1adapter (#8255)

`internal/storage/v2/api/tracestore/reader.go` imported
`internal/storage/v1/api/spanstore` solely to support the
`ToSpanStoreQueryParameters()` conversion helper — an undesirable v1
dependency in a v2 API package.

## Changes

- **`tracestore/reader.go`**: Remove `ToSpanStoreQueryParameters()`
method from `TraceQueryParams` and drop `spanstore`/`jptrace` imports.
The v2 tracestore API package is now free of v1 dependencies.
- **`v1adapter/tracereader.go`**: Add `GetV1QueryParameters(query
tracestore.TraceQueryParams) *spanstore.TraceQueryParameters` as an
exported function. The v1adapter package is the correct home for v1↔v2
conversion logic.
- **Tests**: Move `TestToSpanStoreQueryParameters` →
`TestGetV1QueryParameters` into `v1adapter/tracereader_test.go`.

```go
// Before (in tracestore package — wrong layer):
func (t *TraceQueryParams) ToSpanStoreQueryParameters() *spanstore.TraceQueryParameters { ... }

// After (in v1adapter package — correct layer):
func GetV1QueryParameters(query tracestore.TraceQueryParams) *spanstore.TraceQueryParameters { ... }
```

<!-- START COPILOT CODING AGENT TIPS -->
---

📱 Kick off Copilot coding agent tasks wherever you are with [GitHub
Mobile](https://gh.io/cca-mobile-docs), available on iOS and Android.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>

Author: Copilot

internal/storage/v2/api/tracestore/reader.go

@@ -10,9 +10,6 @@ import (
 
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
-
-	"github.com/jaegertracing/jaeger/internal/jptrace"
-	"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
 )
 
 // Reader finds and loads traces and other data from storage.
@@ -105,19 +102,6 @@ type FoundTraceID struct {
 	End     time.Time
 }
 
-func (t *TraceQueryParams) ToSpanStoreQueryParameters() *spanstore.TraceQueryParameters {
-	return &spanstore.TraceQueryParameters{
-		ServiceName:   t.ServiceName,
-		OperationName: t.OperationName,
-		Tags:          jptrace.PcommonMapToPlainMap(t.Attributes),
-		StartTimeMin:  t.StartTimeMin,
-		StartTimeMax:  t.StartTimeMax,
-		DurationMin:   t.DurationMin,
-		DurationMax:   t.DurationMax,
-		NumTraces:     t.SearchDepth,
-	}
-}
-
 // OperationQueryParams contains parameters of query operations, empty spanKind means get operations for all kinds of span.
 type OperationQueryParams struct {
 	ServiceName string

internal/storage/v2/api/tracestore/reader_test.go

@@ -2,41 +2,3 @@
 // SPDX-License-Identifier: Apache-2.0
 
 package tracestore
-
-import (
-	"testing"
-	"time"
-
-	"github.com/stretchr/testify/require"
-	"go.opentelemetry.io/collector/pdata/pcommon"
-
-	"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
-)
-
-func TestToSpanStoreQueryParameters(t *testing.T) {
-	now := time.Now()
-	attributes := pcommon.NewMap()
-	attributes.PutStr("tag-a", "val-a")
-
-	query := &TraceQueryParams{
-		ServiceName:   "service",
-		OperationName: "operation",
-		Attributes:    attributes,
-		StartTimeMin:  now,
-		StartTimeMax:  now.Add(time.Minute),
-		DurationMin:   time.Minute,
-		DurationMax:   time.Hour,
-		SearchDepth:   10,
-	}
-	expected := &spanstore.TraceQueryParameters{
-		ServiceName:   "service",
-		OperationName: "operation",
-		Tags:          map[string]string{"tag-a": "val-a"},
-		StartTimeMin:  now,
-		StartTimeMax:  now.Add(time.Minute),
-		DurationMin:   time.Minute,
-		DurationMax:   time.Hour,
-		NumTraces:     10,
-	}
-	require.Equal(t, expected, query.ToSpanStoreQueryParameters())
-}

internal/storage/v2/v1adapter/tracereader.go

@@ -11,6 +11,7 @@ import (
 	"go.opentelemetry.io/collector/pdata/ptrace"
 
 	"github.com/jaegertracing/jaeger-idl/model/v1"
+	"github.com/jaegertracing/jaeger/internal/jptrace"
 	"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
 	"github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore"
 )
@@ -86,7 +87,7 @@ func (tr *TraceReader) FindTraces(
 	query tracestore.TraceQueryParams,
 ) iter.Seq2[[]ptrace.Traces, error] {
 	return func(yield func([]ptrace.Traces, error) bool) {
-		traces, err := tr.spanReader.FindTraces(ctx, query.ToSpanStoreQueryParameters())
+		traces, err := tr.spanReader.FindTraces(ctx, GetV1QueryParameters(query))
 		if err != nil {
 			yield(nil, err)
 			return
@@ -106,7 +107,7 @@ func (tr *TraceReader) FindTraceIDs(
 	query tracestore.TraceQueryParams,
 ) iter.Seq2[[]tracestore.FoundTraceID, error] {
 	return func(yield func([]tracestore.FoundTraceID, error) bool) {
-		traceIDs, err := tr.spanReader.FindTraceIDs(ctx, query.ToSpanStoreQueryParameters())
+		traceIDs, err := tr.spanReader.FindTraceIDs(ctx, GetV1QueryParameters(query))
 		if err != nil {
 			yield(nil, err)
 			return
@@ -120,3 +121,17 @@ func (tr *TraceReader) FindTraceIDs(
 		yield(otelIDs, nil)
 	}
 }
+
+// GetV1QueryParameters converts a tracestore.TraceQueryParams to a spanstore.TraceQueryParameters.
+func GetV1QueryParameters(query tracestore.TraceQueryParams) *spanstore.TraceQueryParameters {
+	return &spanstore.TraceQueryParameters{
+		ServiceName:   query.ServiceName,
+		OperationName: query.OperationName,
+		Tags:          jptrace.PcommonMapToPlainMap(query.Attributes),
+		StartTimeMin:  query.StartTimeMin,
+		StartTimeMax:  query.StartTimeMax,
+		DurationMin:   query.DurationMin,
+		DurationMax:   query.DurationMax,
+		NumTraces:     query.SearchDepth,
+	}
+}

internal/storage/v2/v1adapter/tracereader_test.go

@@ -22,6 +22,34 @@ import (
 	"github.com/jaegertracing/jaeger/internal/storage/v2/api/tracestore"
 )
 
+func TestGetV1QueryParameters(t *testing.T) {
+	now := time.Now()
+	attributes := pcommon.NewMap()
+	attributes.PutStr("tag-a", "val-a")
+
+	query := tracestore.TraceQueryParams{
+		ServiceName:   "service",
+		OperationName: "operation",
+		Attributes:    attributes,
+		StartTimeMin:  now,
+		StartTimeMax:  now.Add(time.Minute),
+		DurationMin:   time.Minute,
+		DurationMax:   time.Hour,
+		SearchDepth:   10,
+	}
+	expected := &spanstore.TraceQueryParameters{
+		ServiceName:   "service",
+		OperationName: "operation",
+		Tags:          map[string]string{"tag-a": "val-a"},
+		StartTimeMin:  now,
+		StartTimeMax:  now.Add(time.Minute),
+		DurationMin:   time.Minute,
+		DurationMax:   time.Hour,
+		NumTraces:     10,
+	}
+	require.Equal(t, expected, GetV1QueryParameters(query))
+}
+
 func TestTraceReader_GetTracesDelegatesSuccessResponse(t *testing.T) {
 	sr := new(spanstoremocks.Reader)
 	modelTrace := &model.Trace{