Several changes:

 - WTableView:
   - silence -Wimplicit-fallthrough warning
   - fix row deletion
 - AuthWidget:
   - letUpdatePassword: reinstate the dialog self-deletion for the
     default implementation (with dialog)
 - WWebWidget:
   - Do not emit childrenChanged when being deleted
 - Dbo tutorial: fixed code example error
 - WLocale: We don't plan to do that anymore

Author: RockinRoel

doc/tutorial/dbo.doc

@@ -133,7 +133,7 @@ void run()
     /*
      * Setup a session, would typically be done once at application startup.
      */
-    std::unique_ptr<dbo::backend::Sqlite3> sqlite3{"blog.db"};
+    std::unique_ptr<dbo::backend::Sqlite3> sqlite3{new dbo::backend::Sqlite3("blog.db")};
     dbo::Session session;
     session.setConnection(std::move(sqlite3));
 

src/Wt/Auth/AuthWidget.C

@@ -213,8 +213,17 @@ std::unique_ptr<WWidget> AuthWidget::createLostPasswordView()
 
 void AuthWidget::letUpdatePassword(const User& user, bool promptPassword)
 {
-  showDialog(tr("Wt.Auth.updatepassword"),
-	     createUpdatePasswordView(user, promptPassword));
+  std::unique_ptr<WWidget> updatePasswordView = createUpdatePasswordView(user, promptPassword);
+
+  UpdatePasswordWidget *defaultUpdatePasswordWidget =
+      dynamic_cast<UpdatePasswordWidget*>(updatePasswordView.get());
+
+  showDialog(tr("Wt.Auth.updatepassword"), std::move(updatePasswordView));
+
+  if (defaultUpdatePasswordWidget) {
+    defaultUpdatePasswordWidget->updated().connect(this, &AuthWidget::closeDialog);
+    defaultUpdatePasswordWidget->canceled().connect(this, &AuthWidget::closeDialog);
+  }
 }
 
 std::unique_ptr<WWidget> AuthWidget

src/Wt/WLocale.h

@@ -28,9 +28,6 @@ namespace Wt {
  * from the browser, if possible, and message resources are deduced
  * based on that. All other parameters have to be configured.
  *
- * We plan to leverage the C++ std::locale to deduce these parameters,
- * but this is currently not implemented.
- *
  * \sa WApplication::locale()
  */
 class WT_API WLocale

src/Wt/WTableView.C

@@ -923,6 +923,7 @@ void WTableView::render(WFlags<RenderFlag> flags)
 	break;
       case RenderState::NeedUpdateModelIndexes:
 	updateModelIndexes();
+        /* fallthrough */
       case RenderState::NeedAdjustViewPort:
 	adjustToViewport();
 	break;
@@ -1495,6 +1496,18 @@ void WTableView::modelRowsInserted(const WModelIndex& parent,
   adjustSize();
 }
 
+namespace {
+
+int calcOverlap(int start1, int end1,
+		int start2, int end2)
+{
+  int s = std::max(start1, start2);
+  int e = std::min(end1, end2);
+  return std::max(0, e - s);
+}
+
+}
+
 void WTableView::modelRowsAboutToBeRemoved(const WModelIndex& parent,
 					   int start, int end)
 {
@@ -1508,9 +1521,32 @@ void WTableView::modelRowsAboutToBeRemoved(const WModelIndex& parent,
   }
 
   shiftModelIndexRows(start, -(end - start + 1));  
+
+  int overlapTop = calcOverlap(0, spannerCount(Side::Top),
+			       start, end + 1);
+  int overlapMiddle = calcOverlap(firstRow(), lastRow() + 1,
+				  start, end + 1);
+
+  if (overlapMiddle > 0) {
+    int first = std::min(start, firstRow());
+  
+    for (int i = 0; i < renderedColumnsCount(); ++i) {
+      ColumnWidget *column = columnContainer(i);
+      for (int j = 0; j < overlapMiddle; ++j)
+        column->widget(first)->removeFromParent();
+    }
+
+    setSpannerCount(Side::Bottom, spannerCount(Side::Bottom) + overlapMiddle);
+  }
+
+  if (overlapTop > 0) {
+    setSpannerCount(Side::Top, spannerCount(Side::Top) - overlapTop);
+    setSpannerCount(Side::Bottom, spannerCount(Side::Bottom) + overlapTop);
+  }
 }
 
-void WTableView::modelRowsRemoved(const WModelIndex& parent, int start, int end)
+void WTableView::modelRowsRemoved(const WModelIndex& parent,
+				  int start, int end)
 {
   if (parent != rootIndex())
     return;
@@ -1519,29 +1555,14 @@ void WTableView::modelRowsRemoved(const WModelIndex& parent, int start, int end)
     canvas_->setHeight(canvasHeight());
     headerColumnsCanvas_->setHeight(canvasHeight());
     scheduleRerender(RenderState::NeedAdjustViewPort);
-
-    if (start >= firstRow() && start <= lastRow()) {
-      int toRemove = std::min(lastRow(), end) - start + 1;
-      int first = start - firstRow();
-      
-      for (int i = 0; i < renderedColumnsCount(); ++i) {
-	ColumnWidget *column = columnContainer(i);
-	for (int j = 0; j < toRemove; ++j)
-	  column->widget(first)->removeFromParent();
-      }
-
-      setSpannerCount(Side::Bottom, spannerCount(Side::Bottom) + toRemove);
-    }
   }
 
-  if (start <= lastRow())
-    scheduleRerender(RenderState::NeedUpdateModelIndexes);
+  scheduleRerender(RenderState::NeedUpdateModelIndexes);
 
   computeRenderedArea();
   adjustSize();
 }
 
-
 void WTableView::modelDataChanged(const WModelIndex& topLeft, 
 				  const WModelIndex& bottomRight)
 {
@@ -1735,6 +1756,8 @@ void WTableView::adjustToViewport()
 {
   assert(ajaxMode());
 
+  computeRenderedArea();
+
   if (renderedFirstRow_ != firstRow() || 
       renderedLastRow_ != lastRow() ||
       renderedFirstColumn_ != firstColumn()||

src/Wt/WWebWidget.C

@@ -343,8 +343,7 @@ void WWebWidget::widgetRemoved(WWidget *child, bool renderRemove)
   WApplication::instance()
     ->session()->renderer().updateFormObjects(child->webWidget(), true);
 
-  if (otherImpl_)
-    otherImpl_->childrenChanged_.emit();
+  emitChildrenChanged();
 }
 
 Signal<>& WWebWidget::childrenChanged()
@@ -1197,8 +1196,7 @@ void WWebWidget::widgetAdded(WWidget *child)
     transientImpl_.reset(new TransientImpl());
   ++transientImpl_->addedChildren_;
 
-  if (otherImpl_)
-    otherImpl_->childrenChanged_.emit();
+  emitChildrenChanged();
 }
 
 std::vector<WWidget *> WWebWidget::children() const
@@ -2789,4 +2787,11 @@ void WWebWidget::setBaseZIndex(int zIndex)
   layoutImpl_->baseZIndex_ = zIndex;
 }
 
+void WWebWidget::emitChildrenChanged()
+{
+  if (!flags_.test(BIT_BEING_DELETED) && otherImpl_) {
+    otherImpl_->childrenChanged_.emit();
+  }
+}
+
 }

src/Wt/WWebWidget.h

@@ -548,6 +548,8 @@ class WT_API WWebWidget : public WWidget
 
   void jsScrollVisibilityChanged(bool visible);
 
+  void emitChildrenChanged();
+
 protected:
   virtual void setParentWidget(WWidget *parent) override;
   void setRendered(bool rendered);