From fb03ff19b0fb646833e6c79f278870f42cb7231c Mon Sep 17 00:00:00 2001 From: James Alexander Lee Date: Thu, 11 Apr 2024 23:42:21 +0100 Subject: [PATCH] Fix deviations with missing image data causing crash --- getDeviations.js | 6 +++--- getDeviations.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/getDeviations.js b/getDeviations.js index c191628..06b8a67 100644 --- a/getDeviations.js +++ b/getDeviations.js @@ -22,9 +22,9 @@ function getDeviations(url, limit, start) { object.link = items[i].link; object.date = items[i].pubDate; object.desc = items[i]['media:description']['#text']; - object.thumbS = items[i]['media:thumbnail'][0]['@url']; - object.thumbL = items[i]['media:thumbnail'][1]['@url']; - object.image = items[i]['media:content']['@url']; + object.thumbS = items[i]['media:thumbnail']?.[0]['@url'] || null; + object.thumbL = items[i]['media:thumbnail']?.[1]['@url'] || null; + object.image = items[i]['media:content']?.['@url'] || null; object.rating = items[i]['media:rating']; object.category = items[i]['media:category']['#text']; object.categoryUrl = 'https://www.deviantart.com/' + object.category; diff --git a/getDeviations.php b/getDeviations.php index 09408db..4b61173 100644 --- a/getDeviations.php +++ b/getDeviations.php @@ -21,9 +21,9 @@ function getDeviations($url, $limit = null, $start = 0) { "url" => $item->link, "date" => $item->pubDate, "desc" => $item->children('media', true)->description, - "thumbS" => $item->children('media', true)->thumbnail[0]->attributes()->url, - "thumbL" => $item->children('media', true)->thumbnail[1]->attributes()->url, - "image" => $item->children('media', true)->content->attributes()->url, + "thumbS" => ($item->children('media', true)->thumbnail) ? $item->children('media', true)->thumbnail[0]->attributes()->url : null, + "thumbL" => ($item->children('media', true)->thumbnail) ? $item->children('media', true)->thumbnail[1]->attributes()->url : null, + "image" => ($item->children('media', true)->content) ? $item->children('media', true)->content->attributes()->url : null, "rating" => $item->children('media', true)->rating, "categoryUrl" => $item->children('media', true)->category, "category" => $item->children('media', true)->category->attributes()->label,