Merge pull request #6 from jamiebergen/bugfix/1.2.1

Bugfix/1.2.1

Author: jamiebergen

README.txt

@@ -5,7 +5,7 @@ Donate link: https://jamiebergen.com/donate/
 Requires at least: 4.0
 Tested up to: 5.2.2
 Requires PHP: 5.5.24
-Stable tag: 1.2.0
+Stable tag: 1.2.1
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -80,6 +80,10 @@ Each site within a multisite install maintains its own plugin notes. Additionall
 
 == Changelog ==
 
+= 1.2.1 =
+* Fixed: JavaScript error that sometimes happened on update-core.php if a plugin had no notes. Thanks to @brianhenryie for bringing this to my attention.
+* Added: Hungarian translation. Thanks to @tomek00.
+
 = 1.2.0 =
 * Added: Plugin notes now display in a read-only format on the WordPress Updates page (update-core.php). Thanks to @douglsmith for the suggestion.
 * Fixed: Removed unnecessary multisite hook. Thanks to @foomagoo for pointing this out.
@@ -102,6 +106,9 @@ Each site within a multisite install maintains its own plugin notes. Additionall
 
 == Upgrade Notice ==
 
+= 1.2.1 =
+This version fixes a rare JavaScript error on the WordPress Updates page and adds a Hungarian translation.
+
 = 1.2.0 =
 This version adds a feature to display plugin notes on the WordPress Updates page.
 

admin/class-plugin-notes-plus-admin.php

@@ -109,12 +109,13 @@ public function enqueue_scripts() {
 
 		if ( $hook_suffix == 'update-core.php' ) {
 			$updates = $this->get_notes_for_plugin_updates_page();
+			$updates_json_str = json_encode( $updates );
 			$labels = array (
 				'col_title' => esc_html__( 'Plugin Notes', $this->plugin->get_plugin_name() ),
 				'no_note' => esc_html__( 'No Plugin Notes', $this->plugin->get_plugin_name() ),
 			);
 			wp_enqueue_script( 'pnp_updates_script', plugin_dir_url( __FILE__ ) . 'js/plugin-notes-plus-updates.js', array( 'jquery' ), $this->plugin->get_version(), false );
-			wp_localize_script( 'pnp_updates_script', 'updates', $updates );
+			wp_localize_script( 'pnp_updates_script', 'updates', $updates_json_str );
 			wp_localize_script( 'pnp_updates_script', 'labels', $labels );
 		}
 	}

admin/js/plugin-notes-plus-updates.js

@@ -8,18 +8,22 @@
 
         $('#update-plugins-table thead tr, #update-plugins-table tfoot tr').append( '<td id="pnp_plugin_notes_col">'+ labels.col_title +'</td>' );
 
+        var notes_for_plugin_updates = $.parseJSON(updates);
+
         var i = 0;
 
         $('#update-plugins-table .plugins tr').each(function() {
 
-            const values = Object.values(updates[i]);
+            var plugin_notes = notes_for_plugin_updates[i];
 
-            if (values === undefined || values.length === 0) {
+            if (plugin_notes === undefined || plugin_notes.length === 0) {
 
                 $(this).append( '<td>'+ labels.no_note +'</td>' );
 
             } else {
 
+                var values = Object.values(plugin_notes);
+
                 var noteMarkup = '<div class="pnp-wrapper">';
 
                 for (const value of values) {

languages/plugin-notes-plus-hu_HU.mo

@@ -0,0 +1,96 @@
+# WordPress Blank Pot
+# Copyright (C) 2014 ...
+# This file is distributed under the GNU General Public License v2 or later.
+msgid ""
+msgstr ""
+"Project-Id-Version: Plugin Notes Plus 1.0.0\n"
+"Report-Msgid-Bugs-To: Translator Name <translations@example.com>\n"
+"POT-Creation-Date: 2019-08-12 19:22+0200\n"
+"PO-Revision-Date: \n"
+"Last-Translator: \n"
+"Language-Team: Tomek <tomek.maestro@gmail.com>\n"
+"Language: hu_HU\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Textdomain-Support: yesX-Generator: Poedit 1.6.4\n"
+"X-Poedit-SourceCharset: UTF-8\n"
+"X-Poedit-KeywordsList: __;_e;esc_html_e;esc_html_x:1,2c;esc_html__;"
+"esc_attr_e;esc_attr_x:1,2c;esc_attr__;_ex:1,2c;_nx:4c,1,2;"
+"_nx_noop:4c,1,2;_x:1,2c;_n:1,2;_n_noop:1,2;__ngettext:1,2;"
+"__ngettext_noop:1,2;_c,_nc:4c,1,2\n"
+"X-Poedit-Basepath: ..\n"
+"X-Generator: Poedit 1.8.7\n"
+"X-Poedit-SearchPath-0: .\n"
+
+#: admin/class-plugin-notes-plus-admin.php:93
+#: admin/partials/plugin-note-markup.php:27
+msgid "edit"
+msgstr "Szerkeszt"
+
+#: admin/class-plugin-notes-plus-admin.php:94
+#: admin/partials/plugin-note-markup.php:28
+msgid "delete"
+msgstr "Töröl"
+
+#: admin/class-plugin-notes-plus-admin.php:95
+msgid "Are you sure you want to delete this note?"
+msgstr "¿Biztosan törlöd a megjegyzést?"
+
+#: admin/class-plugin-notes-plus-admin.php:96
+msgid "The note must contain content."
+msgstr "A megjegyzés nem lehet üres."
+
+#: admin/class-plugin-notes-plus-admin.php:113
+#: admin/class-plugin-notes-plus-admin.php:128
+msgid "Plugin Notes"
+msgstr "Bővítmények megjegyzései"
+
+#: admin/class-plugin-notes-plus-admin.php:114
+msgid "No Plugin Notes"
+msgstr "Nincsenek megjegyzéásek"
+
+#: admin/class-plugin-notes-plus-admin.php:277
+msgid "Note"
+msgstr "Megjegyzés"
+
+#: admin/class-plugin-notes-plus-admin.php:278
+msgid "Info"
+msgstr "Információ"
+
+#: admin/class-plugin-notes-plus-admin.php:279
+msgid "Link"
+msgstr "Hivatkozás"
+
+#: admin/class-plugin-notes-plus-admin.php:280
+msgid "Warning"
+msgstr "Figyelmeztetés"
+
+#: admin/class-plugin-notes-plus-admin.php:281
+msgid "Key"
+msgstr "Kulcs"
+
+#: admin/class-plugin-notes-plus-admin.php:282
+msgid "Checkmark"
+msgstr "Pipa"
+
+#: admin/partials/plugin-note-markup.php:45
+msgid "+ Add plugin note"
+msgstr "+Megjegyzés hozzáadása"
+
+#: admin/partials/plugin-note-markup.php:49
+msgid "Note type:"
+msgstr "Megjegyzés típusa:"
+
+#: admin/partials/plugin-note-markup.php:58
+msgid "Save note"
+msgstr "Megjegyzés mentése"
+
+#: admin/partials/plugin-note-markup.php:61
+msgid "Cancel"
+msgstr "Megszakít"
+
+#: admin/partials/plugin-note-markup.php:72
+msgid "You are not authorized to perform this operation."
+msgstr "Nem vagy jogosult a művelet végrehajtására."

languages/plugin-notes-plus-hu_HU.po

@@ -34,7 +34,7 @@
  * Current plugin version.
  * Start at version 1.0.0 and use SemVer - https://semver.org
  */
-define( 'PLUGIN_NOTES_PLUS_VERSION', '1.2.0' );
+define( 'PLUGIN_NOTES_PLUS_VERSION', '1.2.1' );
 
 /**
  * The code that runs during plugin activation.