Migrate on_conflict_statement to statement adapters

Author: sobstel

lib/bulk_insert/statement_adapters/generic_adapter.rb

@@ -5,10 +5,8 @@ def insert_ignore_statement
         ''
       end
 
-      def on_conflict_ignore_statement
-      end
-
-      def on_conflict_update_statement
+      def on_conflict_statement(columns, ignore, update_duplicates)
+        ''
       end
 
       def primary_key_return_statement(primary_key)

lib/bulk_insert/statement_adapters/mysql_adapter.rb

@@ -5,10 +5,13 @@ def insert_ignore_statement
         'IGNORE'
       end
 
-      def on_conflict_ignore_statement
-      end
+      def on_conflict_statement(columns, ignore, update_duplicates)
+        return '' unless update_duplicates
 
-      def on_conflict_update_statement
+        update_values = columns.map do |column|
+          "`#{column.name}`=VALUES(`#{column.name}`)"
+        end.join(', ')
+        ' ON DUPLICATE KEY UPDATE ' + update_values
       end
 
       def primary_key_return_statement(primary_key)

lib/bulk_insert/statement_adapters/postgresql_adapter.rb

@@ -5,10 +5,15 @@ def insert_ignore_statement
         ''
       end
 
-      def on_conflict_ignore_statement
-      end
-
-      def on_conflict_update_statement
+      def on_conflict_statement(columns, ignore, update_duplicates)
+        if ignore
+          ' ON CONFLICT DO NOTHING'
+        elsif update_duplicates
+          update_values = columns.map do |column|
+            "#{column.name}=EXCLUDED.#{column.name}"
+          end.join(', ')
+          ' ON CONFLICT(' + update_duplicates.join(', ') + ') DO UPDATE SET ' + update_values
+        end
       end
 
       def primary_key_return_statement(primary_key)

lib/bulk_insert/statement_adapters/sqlite_adapter.rb

@@ -5,10 +5,8 @@ def insert_ignore_statement
         'OR IGNORE'
       end
 
-      def on_conflict_ignore_statement
-      end
-
-      def on_conflict_update_statement
+      def on_conflict_statement(columns, ignore, update_duplicates)
+        ''
       end
 
       def primary_key_return_statement(primary_key)

lib/bulk_insert/worker.rb

@@ -120,7 +120,7 @@ def compose_insert_query
 
       if !rows.empty?
         sql << rows.join(",")
-        sql << on_conflict_statement
+        sql << @statement_adapter.on_conflict_statement(@columns, ignore, update_duplicates)
         sql << @statement_adapter.primary_key_return_statement(@primary_key) if @return_primary_keys
         sql
       else
@@ -132,24 +132,5 @@ def insert_sql_statement
       insert_ignore = @ignore ? @statement_adapter.insert_ignore_statement : ''
       "INSERT #{insert_ignore} INTO #{@table_name} (#{@column_names}) VALUES "
     end
-
-    def on_conflict_statement
-      is_postgres = adapter_name =~ /\APost(?:greSQL|GIS)/i
-      if is_postgres && ignore
-        ' ON CONFLICT DO NOTHING'
-      elsif is_postgres && update_duplicates
-        update_values = @columns.map do |column|
-          "#{column.name}=EXCLUDED.#{column.name}"
-        end.join(', ')
-        ' ON CONFLICT(' + update_duplicates.join(', ') + ') DO UPDATE SET ' + update_values
-      elsif adapter_name =~ /^mysql/i && update_duplicates
-        update_values = @columns.map do |column|
-          "`#{column.name}`=VALUES(`#{column.name}`)"
-        end.join(', ')
-        ' ON DUPLICATE KEY UPDATE ' + update_values
-      else
-        ''
-      end
-    end
   end
 end

test/bulk_insert/worker_test.rb

@@ -420,17 +420,20 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
   end
 
   test "mysql adapter can update duplicates" do
-    mysql_worker = BulkInsert::Worker.new(
-      Testing.connection,
-      Testing.table_name,
-      'id',
-      %w(greeting age happy created_at updated_at color),
-      500, # batch size
-      false, # ignore
-      true) # update_duplicates
-    mysql_worker.adapter_name = 'MySQL'
-    mysql_worker.add ["Yo", 15, false, nil, nil]
+    connection = Testing.connection
+    connection.stub :adapter_name, 'MySQL' do
+      mysql_worker = BulkInsert::Worker.new(
+        connection,
+        Testing.table_name,
+        'id',
+        %w(greeting age happy created_at updated_at color),
+        500, # batch size
+        false, # ignore
+        true # update_duplicates
+      )
+      mysql_worker.add ["Yo", 15, false, nil, nil]
 
-    assert_equal mysql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
+      assert_equal mysql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
+    end
   end
 end