Drop support for Rails 5.1

Author: janko

.github/workflows/ci.yml

@@ -16,32 +16,22 @@ jobs:
       fail-fast: false
       matrix:
         ruby: ["ruby-3.0", "ruby-3.1", "ruby-3.2", "ruby-3.3", "ruby-3.4", "ruby-4.0", "jruby-9.4"]
-        gemfile: ["rails-5.1", "rails-5.2", "rails-6.0", "rails-6.1", "rails-7.0", "rails-7.1", "rails-7.2", "rails-8.0", "rails-8.1"]
+        gemfile: ["rails-5.2", "rails-6.0", "rails-6.1", "rails-7.0", "rails-7.1", "rails-7.2", "rails-8.0", "rails-8.1"]
         exclude:
           - ruby: "ruby-4.0"
             gemfile: "rails-5.2"
-          - ruby: "ruby-4.0"
-            gemfile: "rails-5.1"
           - ruby: "ruby-3.4"
             gemfile: "rails-5.2"
-          - ruby: "ruby-3.4"
-            gemfile: "rails-5.1"
           - ruby: "ruby-3.3"
             gemfile: "rails-5.2"
-          - ruby: "ruby-3.3"
-            gemfile: "rails-5.1"
           - ruby: "ruby-3.2"
             gemfile: "rails-5.2"
-          - ruby: "ruby-3.2"
-            gemfile: "rails-5.1"
           - ruby: "ruby-3.1"
             gemfile: "rails-8.1"
           - ruby: "ruby-3.1"
             gemfile: "rails-8.0"
           - ruby: "ruby-3.1"
             gemfile: "rails-5.2"
-          - ruby: "ruby-3.1"
-            gemfile: "rails-5.1"
           - ruby: "ruby-3.0"
             gemfile: "rails-8.1"
           - ruby: "ruby-3.0"
@@ -50,8 +40,6 @@ jobs:
             gemfile: "rails-7.2"
           - ruby: "ruby-3.0"
             gemfile: "rails-5.2"
-          - ruby: "ruby-3.0"
-            gemfile: "rails-5.1"
           - ruby: "jruby-9.4"
             gemfile: "rails-8.1"
           - ruby: "jruby-9.4"
@@ -62,8 +50,6 @@ jobs:
             gemfile: "rails-7.1"
           - ruby: "jruby-9.4"
             gemfile: "rails-5.2"
-          - ruby: "jruby-9.4"
-            gemfile: "rails-5.1"
     env:
       BUNDLE_GEMFILE: gemfiles/Gemfile.${{ matrix.gemfile }}
 

lib/rodauth/rails.rb

@@ -67,14 +67,8 @@ def authenticate(name = nil, &condition)
         end
       end
 
-      if ::Rails.gem_version >= Gem::Version.new("5.2")
-        def secret_key_base
-          ::Rails.application.secret_key_base
-        end
-      else
-        def secret_key_base
-          ::Rails.application.secrets.secret_key_base
-        end
+      def secret_key_base
+        ::Rails.application.secret_key_base
       end
 
       def configure

rodauth-rails.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.files         = Dir["README.md", "LICENSE.txt", "lib/**/*", "*.gemspec"]
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "railties", ">= 5.1"
+  spec.add_dependency "railties", ">= 5.2"
   spec.add_dependency "rodauth", "~> 2.36"
   spec.add_dependency "roda", "~> 3.76"
   spec.add_dependency "rodauth-model", "~> 0.2"

test/rails_app/db/migrate/20200411171322_create_rodauth.rb

@@ -52,11 +52,7 @@ def change
       t.references :account, foreign_key: true, null: false
       t.datetime :at, null: false, default: -> { "CURRENT_TIMESTAMP" }
       t.text :message, null: false
-      if ActiveRecord.version >= Gem::Version.new("5.2")
-        t.json :metadata
-      else
-        t.text :metadata
-      end
+      t.json :metadata
       t.index [:account_id, :at]
       t.index :at
     end

test/rodauth_test.rb

@@ -41,18 +41,16 @@ class RodauthTest < UnitTest
       assert_equal "secret", Rodauth::Rails.secret_key_base
     end
 
-    if Rails.gem_version >= Gem::Version.new("5.2")
-      Rails.application.credentials.secret_key_base = "credential"
-      reset_secret_key_base do
-        assert_equal "credential", Rodauth::Rails.secret_key_base
-      end
-
-      ENV["SECRET_KEY_BASE"] = "environment"
-      reset_secret_key_base do
-        assert_equal "environment", Rodauth::Rails.secret_key_base
-      end
-      ENV.delete("SECRET_KEY_BASE")
+    Rails.application.credentials.secret_key_base = "credential"
+    reset_secret_key_base do
+      assert_equal "credential", Rodauth::Rails.secret_key_base
     end
+
+    ENV["SECRET_KEY_BASE"] = "environment"
+    reset_secret_key_base do
+      assert_equal "environment", Rodauth::Rails.secret_key_base
+    end
+    ENV.delete("SECRET_KEY_BASE")
   ensure
     Rails.env = "test"
   end

test/test_helper.rb

@@ -19,21 +19,17 @@ def setup
     super
     if ActiveRecord.version >= Gem::Version.new("7.2")
       ActiveRecord::Base.connection_pool.migration_context.up
-    elsif ActiveRecord.version >= Gem::Version.new("5.2")
-      ActiveRecord::Base.connection.migration_context.up
     else
-      ActiveRecord::Migrator.up(Rails.application.paths["db/migrate"].to_a)
+      ActiveRecord::Base.connection.migration_context.up
     end
   end
 
   def teardown
     super
     if ActiveRecord.version >= Gem::Version.new("7.2")
       ActiveRecord::Base.connection_pool.migration_context.up
-    elsif ActiveRecord.version >= Gem::Version.new("5.2")
-      ActiveRecord::Base.connection.migration_context.down
     else
-      ActiveRecord::Migrator.down(Rails.application.paths["db/migrate"].to_a)
+      ActiveRecord::Base.connection.migration_context.down
     end
     ActiveRecord::Base.clear_cache! # clear schema cache
     ActionMailer::Base.deliveries.clear