Skip to content

Commit 87150c8

Browse files
committed
Don't test Rails 8.0 on Ruby 3.1
Also fix a deprecation warning.
1 parent 3943f08 commit 87150c8

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
ruby: ["ruby-2.5", "ruby-2.6", "ruby-2.7", "ruby-3.0", "ruby-3.1", "ruby-3.2", "ruby-3.3", "jruby-9.4"]
19-
gemfile: ["rails-5.0", "rails-5.1", "rails-5.2", "rails-6.0", "rails-6.1", "rails-7.0", "rails-7.1", "rails-7.2", "rails-main"]
19+
gemfile: ["rails-5.0", "rails-5.1", "rails-5.2", "rails-6.0", "rails-6.1", "rails-7.0", "rails-7.1", "rails-7.2", "rails-8.0"]
2020
exclude:
2121
- ruby: "ruby-3.3"
2222
gemfile: "rails-5.2"
@@ -30,14 +30,16 @@ jobs:
3030
gemfile: "rails-5.1"
3131
- ruby: "ruby-3.2"
3232
gemfile: "rails-5.0"
33+
- ruby: "ruby-3.1"
34+
gemfile: "rails-8.0"
3335
- ruby: "ruby-3.1"
3436
gemfile: "rails-5.2"
3537
- ruby: "ruby-3.1"
3638
gemfile: "rails-5.1"
3739
- ruby: "ruby-3.1"
3840
gemfile: "rails-5.0"
3941
- ruby: "ruby-3.0"
40-
gemfile: "rails-main"
42+
gemfile: "rails-8.0"
4143
- ruby: "ruby-3.0"
4244
gemfile: "rails-7.2"
4345
- ruby: "ruby-3.0"
@@ -47,11 +49,11 @@ jobs:
4749
- ruby: "ruby-3.0"
4850
gemfile: "rails-5.0"
4951
- ruby: "ruby-2.7"
50-
gemfile: "rails-main"
52+
gemfile: "rails-8.0"
5153
- ruby: "ruby-2.7"
5254
gemfile: "rails-7.2"
5355
- ruby: "jruby-9.4"
54-
gemfile: "rails-main"
56+
gemfile: "rails-8.0"
5557
- ruby: "jruby-9.4"
5658
gemfile: "rails-7.2"
5759
- ruby: "jruby-9.4"
@@ -63,15 +65,15 @@ jobs:
6365
- ruby: "jruby-9.4"
6466
gemfile: "rails-5.0"
6567
- ruby: "ruby-2.6"
66-
gemfile: "rails-main"
68+
gemfile: "rails-8.0"
6769
- ruby: "ruby-2.6"
6870
gemfile: "rails-7.2"
6971
- ruby: "ruby-2.6"
7072
gemfile: "rails-7.1"
7173
- ruby: "ruby-2.6"
7274
gemfile: "rails-7.0"
7375
- ruby: "ruby-2.5"
74-
gemfile: "rails-main"
76+
gemfile: "rails-8.0"
7577
- ruby: "ruby-2.5"
7678
gemfile: "rails-7.2"
7779
- ruby: "ruby-2.5"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ gemspec path: ".."
55
gem "rake", "~> 12.0"
66
gem "warning"
77

8-
gem "rails", github: "rails/rails"
8+
gem "rails", "~> 8.0.0.beta1"
99
gem "sqlite3", "~> 2.0", platforms: :mri
1010
gem "activerecord-jdbcsqlite3-adapter", platforms: :jruby
1111

lib/rodauth/rails/feature/instrumentation.rb

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def return_response(*)
2525
def rails_render(*)
2626
render_output = nil
2727
rails_controller_instance.view_runtime = rails_controller_instance.send(:cleanup_view_runtime) do
28-
Benchmark.ms { render_output = super }
28+
rails_benchmark { render_output = super }
2929
end
3030
render_output
3131
end
@@ -79,6 +79,16 @@ def build_rails_response(args)
7979
response.request = rails_request
8080
response
8181
end
82+
83+
if ActionPack.version >= Gem::Version.new("8.0.0.beta1")
84+
def rails_benchmark(&block)
85+
ActiveSupport::Benchmark.realtime(:float_millisecond, &block)
86+
end
87+
else
88+
def rails_benchmark(&block)
89+
Benchmark.ms(&block)
90+
end
91+
end
8292
end
8393
end
8494
end

0 commit comments

Comments
 (0)