Skip to content

fix(loader): Prevent foreign loaders from compile lodash#905

Merged
jantimon merged 1 commit into
masterfrom
feature/lodash-fix
Mar 25, 2018
Merged

fix(loader): Prevent foreign loaders from compile lodash#905
jantimon merged 1 commit into
masterfrom
feature/lodash-fix

Conversation

@jantimon
Copy link
Copy Markdown
Owner

Fixes #786

@mastilver
Copy link
Copy Markdown
Collaborator

That would prevent confusing issue with html-loader and co, right? That's amazing! ⭐

@jantimon
Copy link
Copy Markdown
Owner Author

Unfortunately I would only help with only remove the following warning:

[BABEL] Note: The code generator has deoptimised the styling of "~/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".

Stop using webpack module rules inside the loader to get rid of the babel 500kb warning

fix #786
@jantimon jantimon force-pushed the feature/lodash-fix branch from 19df18b to b19204c Compare March 25, 2018 16:18
@jantimon jantimon merged commit 7b4eb7f into master Mar 25, 2018
@lock
Copy link
Copy Markdown

lock Bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators May 31, 2018
@jantimon jantimon deleted the feature/lodash-fix branch February 16, 2019 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants