Fix stats count tracking to only increment for new keys, not updates#1525
Closed
Copilot wants to merge 5 commits into
Closed
Fix stats count tracking to only increment for new keys, not updates#1525Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
2 tasks
Co-authored-by: jaredwray <1205481+jaredwray@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update node-cache implementation based on review feedback
Fix stats count tracking to only increment for new keys, not updates
Jan 5, 2026
Base automatically changed from
node-cache---feat-(breaking)-moving-to-Keyv-as-the-storage
to
main
January 5, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stats count was being incremented unconditionally after every
set()operation, causing overcounting when updating existing keys.Changes
set()method: Check if key exists viathis._keyv.has()before incrementing count. Only new keys increment the counter.mset()method: Apply same logic for batch operations - each item checks existence before count increment.Example
Tests added to verify count behavior for both single and batch operations.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.