Fix stats count overcount on key updates in NodeCacheStore#1526
Closed
Copilot wants to merge 6 commits into
Closed
Fix stats count overcount on key updates in NodeCacheStore#1526Copilot wants to merge 6 commits into
Copilot wants to merge 6 commits into
Conversation
2 tasks
Co-authored-by: jaredwray <1205481+jaredwray@users.noreply.github.com>
Co-authored-by: jaredwray <1205481+jaredwray@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update storage implementation to use Keyv in node-cache
Fix stats count overcount on key updates in NodeCacheStore
Jan 5, 2026
Base automatically changed from
node-cache---feat-(breaking)-moving-to-Keyv-as-the-storage
to
main
January 5, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
setandmsetmethods unconditionally incremented the stats count, causing overcount when updating existing keys instead of only tracking unique keys.Changes
setmethod: Check key existence viakeyv.has()before incrementing count; only increment for new keysmsetmethod: Check each key's existence before incrementing countsetTtlto acceptnumber | stringTTL like other methodsExample
The
has()check adds one async operation per set but is necessary since Keyv'ssetdoesn't distinguish inserts from updates.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.