From 7c71d39e83d74e141d01d8f721bfeaff317802ae Mon Sep 17 00:00:00 2001 From: Jared Wray Date: Wed, 6 May 2026 17:34:52 -0700 Subject: [PATCH] @cacheable/benchmark - fix: upgrade @faker-js/faker to 10.4.0 (breaking) Upgrade @faker-js/faker dependency from 9.8.0 to 10.4.0 to align with the workspace root which is already on 10.4.0. Faker 10 dropped CommonJS support and requires Node.js >= 20. The benchmark package is private (not published) and only consumes the modern API, so this should be a no-op at the call sites. Co-Authored-By: Claude Opus 4.7 (1M context) --- packages/benchmark/package.json | 2 +- pnpm-lock.yaml | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/benchmark/package.json b/packages/benchmark/package.json index 555a9d96..db37ab94 100644 --- a/packages/benchmark/package.json +++ b/packages/benchmark/package.json @@ -48,7 +48,7 @@ }, "dependencies": { "@cacheable/memory": "workspace:^", - "@faker-js/faker": "^9.8.0", + "@faker-js/faker": "^10.4.0", "@monstermann/tinybench-pretty-printer": "^0.1.0", "bentocache": "^1.4.0", "cache-manager": "workspace:^", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index b7161fbe..76bf3d37 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -39,8 +39,8 @@ importers: specifier: workspace:^ version: link:../memory '@faker-js/faker': - specifier: ^9.8.0 - version: 9.8.0 + specifier: ^10.4.0 + version: 10.4.0 '@monstermann/tinybench-pretty-printer': specifier: ^0.1.0 version: 0.1.0(tinybench@4.0.1) @@ -1123,10 +1123,6 @@ packages: resolution: {integrity: sha512-sDBWI3yLy8EcDzgobvJTWq1MJYzAkQdpjXuPukga9wXonhpMRvd1Izuo2Qgwey2OiEoRIBr35RMU9HJRoOHzpw==} engines: {node: ^20.19.0 || ^22.13.0 || ^23.5.0 || >=24.0.0, npm: '>=10'} - '@faker-js/faker@9.8.0': - resolution: {integrity: sha512-U9wpuSrJC93jZBxx/Qq2wPjCuYISBueyVUGK7qqdmj7r/nxaxwW8AQDCLeRO7wZnjj94sh3p246cAYjUKuqgfg==} - engines: {node: '>=18.0.0', npm: '>=9.0.0'} - '@gar/promisify@1.1.3': resolution: {integrity: sha512-k2Ty1JcVojjJFwrg/ThKi2ujJ7XNLYaFGNB/bWT9wGR+oSMJHMa5w+CUq6p/pVrKeNNgA7pCqEcjSnHVoqJQFw==} @@ -4908,8 +4904,6 @@ snapshots: '@faker-js/faker@10.4.0': {} - '@faker-js/faker@9.8.0': {} - '@gar/promisify@1.1.3': optional: true