Skip to content

Commit 6261769

Browse files
jasonlongclaude
andcommitted
Fix installer signing hang in CI
Build unsigned pkg first, then sign with productsign using explicit keychain path. Also expand keychain partition list for productbuild and productsign. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2d70a9d commit 6261769

1 file changed

Lines changed: 13 additions & 6 deletions

File tree

.github/workflows/release-safari.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ jobs:
7979
-T /usr/bin/xcrun \
8080
-T /usr/bin/productbuild
8181
82-
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH"
82+
security set-key-partition-list -S apple-tool:,apple:,codesign:,productsign:,productbuild: -s -k "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH"
83+
echo "KEYCHAIN_PASSWORD=$KEYCHAIN_PASSWORD" >> "$GITHUB_ENV"
8384
security list-keychains -d user -s "$KEYCHAIN_PATH"
8485
security default-keychain -d user -s "$KEYCHAIN_PATH"
8586
@@ -126,8 +127,6 @@ jobs:
126127
CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO
127128
128129
- name: Build installer package
129-
env:
130-
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
131130
run: |
132131
APP_PATH="$ARCHIVE_PATH/Products/Applications/Isometric Contributions.app"
133132
@@ -137,12 +136,20 @@ jobs:
137136
cp ~/Library/MobileDevice/Provisioning\ Profiles/extension.provisionprofile \
138137
"$APP_PATH/Contents/PlugIns/Isometric Contributions Extension.appex/Contents/embedded.provisionprofile"
139138
140-
# Build the .pkg with productbuild
141-
INSTALLER_IDENTITY="3rd Party Mac Developer Installer: Jason Long (DC57SSRSQE)"
139+
# Unlock keychain again before signing
140+
security unlock-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_PATH"
141+
142+
# Build unsigned .pkg, then sign it
142143
productbuild \
143144
--component "$APP_PATH" /Applications \
145+
IsometricContributions-unsigned.pkg
146+
147+
INSTALLER_IDENTITY="3rd Party Mac Developer Installer: Jason Long (DC57SSRSQE)"
148+
productsign \
144149
--sign "$INSTALLER_IDENTITY" \
145-
"IsometricContributions.pkg"
150+
--keychain "$KEYCHAIN_PATH" \
151+
IsometricContributions-unsigned.pkg \
152+
IsometricContributions.pkg
146153
147154
ls -la IsometricContributions.pkg
148155

0 commit comments

Comments
 (0)