Fix error in seeding elastic log_id template (apache#24960)

There was a mistake in seeding the elastic log id. We used hyphens instead of underscores

Author: ephraimbuddy

airflow/utils/db.py

@@ -835,10 +835,15 @@ def log_template_exists():
             session.add(
                 LogTemplate(
                     filename="{{ ti.dag_id }}/{{ ti.task_id }}/{{ ts }}/{{ try_number }}.log",
-                    elasticsearch_id="{dag_id}-{task_id}-{execution_date}-{try_number}",
+                    elasticsearch_id="{dag_id}_{task_id}_{execution_date}_{try_number}",
                 )
             )
             session.flush()
+    wrong_log_id = "{dag_id}-{task_id}-{execution_date}-{try_number}"
+    correct_log_id = "{dag_id}_{task_id}_{execution_date}_{try_number}"
+    session.query(LogTemplate).filter(LogTemplate.elasticsearch_id == wrong_log_id).update(
+        {LogTemplate.elasticsearch_id: correct_log_id}, synchronize_session='fetch'
+    )
 
     # Before checking if the _current_ value exists, we need to check if the old config value we upgraded in
     # place exists!