fix: Mask flicker while navigating on Android (callstack#171)

gabrieldonadel · web-flow · commit 0a5a71fca7b9 · 2022-09-30T14:02:04.000+09:00
diff --git a/android/src/main/java/org/reactnative/maskedview/RNCMaskedView.java b/android/src/main/java/org/reactnative/maskedview/RNCMaskedView.java
@@ -77,17 +77,14 @@ protected void onAttachedToWindow() {
   }
 
   private void updateBitmapMask() {
-    if (this.mBitmapMask != null) {
-      this.mBitmapMask.recycle();
-    }
-
     View maskView = getChildAt(0);
     if (maskView != null) {
       maskView.setVisibility(View.VISIBLE);
+      if (this.mBitmapMask != null) {
+        this.mBitmapMask.recycle();
+      }
       this.mBitmapMask = getBitmapFromView(maskView);
       maskView.setVisibility(View.INVISIBLE);
-    } else{
-      this.mBitmapMask = null;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -77,17 +77,14 @@ protected void onAttachedToWindow() {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`private void updateBitmapMask() {`
`80`		`- if (this.mBitmapMask != null) {`
`81`		`- this.mBitmapMask.recycle();`
`82`		`- }`
`83`		`-`
`84`	`80`	`View maskView = getChildAt(0);`
`85`	`81`	`if (maskView != null) {`
`86`	`82`	`maskView.setVisibility(View.VISIBLE);`
	`83`	`+ if (this.mBitmapMask != null) {`
	`84`	`+ this.mBitmapMask.recycle();`
	`85`	`+ }`
`87`	`86`	`this.mBitmapMask = getBitmapFromView(maskView);`
`88`	`87`	`maskView.setVisibility(View.INVISIBLE);`
`89`		`- } else{`
`90`		`- this.mBitmapMask = null;`
`91`	`88`	`}`
`92`	`89`	`}`
`93`	`90`