Include xyz_value_types-export-set.cmake in package config file#625
Merged
Conversation
CMake fails to find 'xyz_value_types-target.cmake' because it does not exist. It seems like `xyz_value_types-export-set.cmake` should be included instead. Fixes jbcoe#624
Owner
|
@Twon - can you take a look? Looks good to me. |
Twon
approved these changes
Feb 24, 2026
Twon
left a comment
Twon
left a comment
Collaborator
There was a problem hiding this comment.
Looks right to me. Thanks for the contribution!
Contributor
Author
Owner
|
That sounds like a great idea. |
Collaborator
|
I've created a new release here: https://github.com/jbcoe/value_types/releases/tag/v1.0.1 |
Contributor
Author
|
I created a PR to update vcpkg. Does it look OK to you? microsoft/vcpkg#50156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake fails to find 'xyz_value_types-target.cmake' because it does not exist. It seems like
xyz_value_types-export-set.cmakeshould be included instead.Fixes #624