added tests

Author: jessitron

src/cli/support/describeMove.ts

@@ -0,0 +1,15 @@
+import * as path from "path";
+
+export function describeMove(fromDir: string, toDir: string): string {
+    const relativeForward = path.relative(fromDir, toDir);
+    const relativeBackward = path.relative(toDir, fromDir);
+    const upSteps = relativeBackward.split("node_modules").length - 1;
+    const downSteps = relativeForward.split("node_modules").length - 1;
+    if (upSteps > 0) {
+        return `up ${upSteps} stairs and down ${downSteps}.`
+    } else if (downSteps > 0) {
+        return `down ${downSteps} stair.` // should always be 1.
+    } else {
+        return `right through.`;
+    }
+}

src/cli/support/youAreIn.ts

@@ -9,6 +9,7 @@ import { outputCurrentState, output, outputDoom, outputDebug } from "./output";
 import { promisify } from "util";
 import { Crawl as LocalCrawl, NodeModuleResolutionExposed, isModuleResolutionError } from "./SecretDungeonCrawl";
 import { injectSecretDungeonCrawl } from "./injectSecretDungeonCrawl";
+import { describeMove } from "./describeMove";
 
 // want to: 
 // - make it find roots of packages, because it fails when it goes into a lib
@@ -70,6 +71,7 @@ function tryToTeleport(room: Room, past: Room[], destination: string) {
     const otherSide = findLibraryRoot(destination, room.crawl);
     if (itsaTrap(otherSide)) {
         outputDoom(chalk.yellow("Your teleport fails."));
+        outputDebug(otherSide.details || otherSide.error.message);
         return youAreIn(room.appDir, past);
     }
     output("Magic! " + describeMove(room.appDir, otherSide));
@@ -89,20 +91,6 @@ function goThroughDoor(room: Room, past: Room[], destination: string) {
     return youAreIn(otherSide, past);
 }
 
-export function describeMove(fromDir: string, toDir: string): string {
-    const relativeForward = path.relative(fromDir, toDir);
-    const relativeBackward = path.relative(toDir, fromDir);
-    const upSteps = relativeBackward.split("node_modules").length - 1;
-    const downSteps = relativeForward.split("node_modules").length - 1;
-    if (upSteps > 0) {
-        return `up ${upSteps} stairs and down ${downSteps}.`
-    } else if (downSteps > 0) {
-        return `down ${downSteps} stair.` // should always be 1.
-    } else {
-        return `right through.`;
-    }
-}
-
 type Trap = {
     error: Error,
     details?: string

test/cli/support/describeMoveTest.ts

@@ -1,19 +1,32 @@
+import { describeMove } from "../../../src/cli/support/describeMove";
+import * as assert from "assert";
+
 describe("color text for moving to another directory", () => {
 
     it("move into an adjacent lib", () => {
+        const result = describeMove("/Users/jessitron/code/other/yargs/node_modules/chai",
+            "/Users/jessitron/code/other/yargs/node_modules/ucui");
+        assert.strictEqual(result, "You step across into ucui.")
+    });
 
-    })
 
     it("move down one", () => {
-
+        const result = describeMove("/Users/jessitron/code/other/yargs",
+            "/Users/jessitron/code/other/yargs/node_modules/ucui");
+        assert.strictEqual(result, "You descend into ucui.")
     })
 
-    it("move into a global lib", () => {
+    it("move into a global lib") // how does this work? it doesn't look in the places that my libs go
 
+    it("move up some random directories", () => {
+        const result = describeMove("/Users/jessitron/code/other/yargs",
+            "/Users/jessitron/code/node_modules/@atomist/automation-client");
+        assert.strictEqual(result, "You climb two flights of stairs, then descend into @atomist/automation-client")
     })
 
-    it("move up some distance"), () => {
-
-    }
-
-})
+    it("move up some node_module directories", () => {
+        const result = describeMove("/Users/jessitron/code/other/yargs/node_modules/chai/node_modules/subchai",
+            "/Users/jessitron/code/other/yargs/node_modules/ucui");
+        assert.strictEqual(result, "You climb one flight of stairs, then step into ucui")
+    });
+});

tsconfig.json

@@ -14,7 +14,7 @@
     // "checkJs": true,                       /* Report errors in .js files. */
     // "jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
     "declaration": true, /* Generates corresponding '.d.ts' file. */
-    "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
+    // "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
     "sourceMap": true, /* Generates corresponding '.map' file. */
     // "outFile": "./",                       /* Concatenate and emit output to single file. */
     "outDir": "build", /* Redirect output structure to the directory. */