artifactory_test.go

package main

import (
	"archive/zip"
	"bytes"
	"crypto/tls"
	"encoding/csv"
	"encoding/json"
	"errors"
	"fmt"
	"io"
	"net"
	"net/http"
	"net/url"
	"os"
	"os/exec"
	"path"
	"path/filepath"
	"reflect"
	"runtime"
	"sort"
	"strconv"
	"strings"
	"testing"
	"time"

	"github.com/jfrog/jfrog-cli-artifactory/cliutils/flagkit"

	biutils "github.com/jfrog/build-info-go/utils"

	"github.com/buger/jsonparser"
	"github.com/jfrog/archiver/v3"
	gofrogio "github.com/jfrog/gofrog/io"
	"github.com/jfrog/gofrog/version"
	"github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/generic"
	"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils"
	commonCliUtils "github.com/jfrog/jfrog-cli-core/v2/common/cliutils"
	"github.com/jfrog/jfrog-cli-core/v2/common/commands"
	"github.com/jfrog/jfrog-cli-core/v2/common/spec"
	commontests "github.com/jfrog/jfrog-cli-core/v2/common/tests"
	"github.com/jfrog/jfrog-cli-core/v2/utils/config"
	"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
	"github.com/jfrog/jfrog-cli-core/v2/utils/dependencies"
	coretests "github.com/jfrog/jfrog-cli-core/v2/utils/tests"
	"github.com/jfrog/jfrog-cli/inttestutils"
	"github.com/jfrog/jfrog-cli/utils/tests"
	cliproxy "github.com/jfrog/jfrog-cli/utils/tests/proxy/server"
	"github.com/jfrog/jfrog-cli/utils/tests/proxy/server/certificate"
	"github.com/jfrog/jfrog-client-go/access"
	accessServices "github.com/jfrog/jfrog-client-go/access/services"
	"github.com/jfrog/jfrog-client-go/artifactory"
	"github.com/jfrog/jfrog-client-go/artifactory/services"
	rtutils "github.com/jfrog/jfrog-client-go/artifactory/services/utils"
	"github.com/jfrog/jfrog-client-go/artifactory/services/utils/tests/xray"
	"github.com/jfrog/jfrog-client-go/auth"
	"github.com/jfrog/jfrog-client-go/http/httpclient"
	clientutils "github.com/jfrog/jfrog-client-go/utils"
	"github.com/jfrog/jfrog-client-go/utils/errorutils"
	"github.com/jfrog/jfrog-client-go/utils/io/content"
	"github.com/jfrog/jfrog-client-go/utils/io/fileutils"
	"github.com/jfrog/jfrog-client-go/utils/io/httputils"
	"github.com/jfrog/jfrog-client-go/utils/log"
	clientTestUtils "github.com/jfrog/jfrog-client-go/utils/tests"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

// Access does not support creating an admin token without UI. Skipping projects tests till this functionality will be implemented.
// https://jira.jfrog.org/browse/JA-2620
// Minimum Artifactory version with Terraform support
const terraformMinArtifactoryVersion = "7.38.4"
const deleteReleaseBundleV1ApiUrl = "artifactory/api/release/bundles/"
const deleteReleaseBundleV2ApiUrl = "lifecycle/api/v2/release_bundle/records/"

// JFrog CLI for Artifactory sub-commands (jfrog rt ...)
var artifactoryCli *coretests.JfrogCli

// JFrog CLI for Platform commands (jfrog ...)
var platformCli *coretests.JfrogCli

// JFrog CLI for config command only (doesn't pass the --ssh-passphrase flag)
var configCli *coretests.JfrogCli

var serverDetails *config.ServerDetails
var artAuth auth.ServiceDetails
var artHttpDetails httputils.HttpClientDetails

// Run `jfrog rt` command
func runRt(t *testing.T, args ...string) {
	assert.NoError(t, artifactoryCli.Exec(args...))
}

func InitArtifactoryTests() {
	initArtifactoryCli()
	cleanUpOldBuilds()
	cleanUpOldRepositories()
	cleanUpOldUsers()
	tests.AddTimestampToGlobalVars()
	createRequiredRepos()
	cleanArtifactoryTest()
}

func authenticate(configCli bool) string {
	*tests.JfrogUrl = clientutils.AddTrailingSlashIfNeeded(*tests.JfrogUrl)
	serverDetails = &config.ServerDetails{Url: *tests.JfrogUrl, ArtifactoryUrl: *tests.JfrogUrl + tests.ArtifactoryEndpoint, SshKeyPath: *tests.JfrogSshKeyPath, SshPassphrase: *tests.JfrogSshPassphrase}
	var cred string
	if configCli {
		cred += "--artifactory-url=" + serverDetails.ArtifactoryUrl
	} else {
		cred += "--url=" + serverDetails.ArtifactoryUrl
	}
	if !fileutils.IsSshUrl(serverDetails.ArtifactoryUrl) {
		if *tests.JfrogAccessToken != "" {
			serverDetails.AccessToken = *tests.JfrogAccessToken
		} else {
			serverDetails.User = *tests.JfrogUser
			serverDetails.Password = *tests.JfrogPassword
		}
	}
	cred += getArtifactoryTestCredentials()
	var err error
	if artAuth, err = serverDetails.CreateArtAuthConfig(); err != nil {
		coreutils.ExitOnErr(errors.New("Failed while attempting to authenticate with Artifactory: " + err.Error()))
	}
	serverDetails.ArtifactoryUrl = artAuth.GetUrl()
	serverDetails.SshUrl = artAuth.GetSshUrl()
	serverDetails.AccessUrl = clientutils.AddTrailingSlashIfNeeded(*tests.JfrogUrl) + tests.AccessEndpoint
	artHttpDetails = artAuth.CreateHttpClientDetails()
	return cred
}

// A Jfrog CLI to be used to execute a config task.
// Removed the ssh-passphrase flag that cannot be passed to with a config command
func createConfigJfrogCLI(cred string) *coretests.JfrogCli {
	if strings.Contains(cred, " --ssh-passphrase=") {
		cred = strings.ReplaceAll(cred, " --ssh-passphrase="+*tests.JfrogSshPassphrase, "")
	}
	return coretests.NewJfrogCli(execMain, "jfrog config", cred)
}

func getArtifactoryTestCredentials() string {
	if fileutils.IsSshUrl(serverDetails.ArtifactoryUrl) {
		return getSshCredentials()
	}
	if *tests.JfrogAccessToken != "" {
		return " --access-token=" + *tests.JfrogAccessToken
	}
	return " --user=" + *tests.JfrogUser + " --password=" + *tests.JfrogPassword
}

func getSshCredentials() string {
	cred := ""
	if *tests.JfrogSshKeyPath != "" {
		cred += " --ssh-key-path=" + *tests.JfrogSshKeyPath
	}
	if *tests.JfrogSshPassphrase != "" {
		cred += " --ssh-passphrase=" + *tests.JfrogSshPassphrase
	}
	return cred
}

func TestArtifactorySimpleUploadSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.UploadFlatRecursive)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryExcludeUpload(t *testing.T) {
	testData := []struct {
		uploadSpec string
		res        []string
	}{
		{tests.UploadExcludeRepo, tests.GetExpectedExcludeUpload()},
		{tests.UploadExcludeRepoContent, tests.GetExpectedExcludeUpload()},
		{tests.UploadExcludeRepoContentPart2, tests.GetExpectedExcludeUploadPart2()},
		{tests.UploadExcludeIncludeDirs, tests.GetExpectedExcludeUploadIncludeDir()},
		{tests.UploadExcludeIncludeDir, tests.GetExpectedExcludeUpload()},
		{tests.UploadExcludeIncludeDirsFlat, tests.GetExpectedExcludeUploadIncludeDir()},
		{tests.UploadExcludeIncludeDirAntPattern, tests.GetExpectedExcludeUpload()},
		{tests.UploadExcludeIncludeDirAntPattern2, tests.GetExpectedExcludeUpload()},
	}
	for _, d := range testData {
		initArtifactoryTest(t, "")
		specFile, err := tests.CreateSpec(d.uploadSpec)
		assert.NoError(t, err)
		runRt(t, "upload", "--spec="+specFile)
		searchFilePath, err := tests.CreateSpec(tests.SearchRepo1IncludeDirs)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(d.res, searchFilePath, serverDetails, t)
		cleanArtifactoryTest()
	}
}

func TestSearchWithBuildNameSpecialChars(t *testing.T) {
	initArtifactoryTest(t, "")
	defer cleanArtifactoryTest()

	testCases := []struct {
		name      string
		buildName string
	}{
		{"buildName with space", "my build"},
		{"buildName with special chars", "my-build with#special@chars"},
		{"buildName with colon", "build:with:colon"},
		{"buildName with spaces and colons", "build :: with :: colon"},
	}

	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			buildNumber := "1"
			artifactPath := filepath.Join("testdata", "a", "a1.in")

			runRt(t, "upload", artifactPath, tests.RtRepo1, "--build-name="+tc.buildName, "--build-number="+buildNumber)
			runRt(t, "build-publish", tc.buildName, buildNumber)

			searchCmd := []string{"search", "--build=" + tc.buildName}
			err := artifactoryCli.Exec(searchCmd...)
			assert.NoError(t, err)
		})
	}
}

func TestArtifactorySimpleUploadWithWildcardSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	// Init tmp dir
	specFile, err := tests.CreateSpec(tests.UploadTempWildcard)
	assert.NoError(t, err)
	err = biutils.CopyDir(tests.GetTestResourcesPath()+"cache", filepath.Dir(specFile), true, nil)
	assert.NoError(t, err)
	// Upload
	runRt(t, "upload", "--spec="+specFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleWildcardUploadExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

// This test is similar to TestArtifactorySimpleUploadSpec but using "--server-id" flag
func TestArtifactorySimpleUploadSpecUsingConfig(t *testing.T) {
	initArtifactoryTest(t, "")
	passphrase, err := createServerConfigAndReturnPassphrase(t)
	defer deleteServerConfig(t)
	assert.NoError(t, err)
	artifactoryCommandExecutor := coretests.NewJfrogCli(execMain, "jfrog rt", "")
	specFile, err := tests.CreateSpec(tests.UploadFlatRecursive)
	assert.NoError(t, err)
	assert.NoError(t, artifactoryCommandExecutor.Exec("upload", "--spec="+specFile, "--server-id="+tests.ServerId, passphrase))

	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestReleaseBundleImportOnPrem(t *testing.T) {
	// Cleanup
	defer func() {
		deleteReceivedReleaseBundle(t, deleteReleaseBundleV1ApiUrl, "cli-tests", "2")
		cleanArtifactoryTest()
	}()
	initArtifactoryTest(t, "")
	initLifecycleCli()
	// Sets the public key in Artifactory to accept the signed release bundle.
	sendArtifactoryTrustedPublicKey(t, artHttpDetails)
	// Import the release bundle
	wd, err := os.Getwd()
	assert.NoError(t, err)
	testFilePath := filepath.Join(wd, "testdata", "lifecycle", "import", "cli-tests-2.zip")
	assert.NoError(t, lcCli.Exec("rbi", testFilePath))
}

func TestReleaseBundleV2Download(t *testing.T) {
	buildNumber := "5"
	initArtifactoryTest(t, "")
	initLifecycleTest(t, signingKeyOptionalArtifactoryMinVersion)
	defer func() {
		deleteReceivedReleaseBundle(t, deleteReleaseBundleV2ApiUrl, tests.LcRbName1, buildNumber)
		inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
		cleanArtifactoryTest()
	}()

	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)

	// Create RBV2
	err := lcCli.Exec("rbc", tests.LcRbName1, buildNumber, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	assert.NoError(t, err)

	runRt(t, "download", "--bundle="+tests.LcRbName1+"/"+buildNumber)

	wd, err := os.Getwd()
	assert.NoError(t, err, "Failed to get current dir")
	exists, err := fileutils.IsDirExists(filepath.Join(wd, tests.LcRbName1), false)

	assert.NoError(t, err)
	assert.True(t, exists)

	clientTestUtils.RemoveAllAndAssert(t, filepath.Join(wd, tests.LcRbName1))
}

func TestArtifactoryUploadPathWithSpecialCharsAsNoRegex(t *testing.T) {
	initArtifactoryTest(t, "")
	filePath := getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1, "--flat")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryIgnoreChecksumOnFilteredResource(t *testing.T) {
	initArtifactoryTest(t, "")
	filePath := "testdata/filtered/a.txt"

	// Upload a filtered resource
	runRt(t, "upload", filePath, tests.RtRepo1, "--flat", "--target-props", "artifactory.filtered=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadFilteredRepo1(), searchFilePath, serverDetails, t)

	// Discard output logging to prevent negative logs
	previousLogger := tests.RedirectLogOutputToNil()
	defer log.SetLogger(previousLogger)

	// Attempt to download the filtered resource (this will fail the checksum check)
	err = artifactoryCli.Exec([]string{"download", tests.RtRepo1 + "/a.txt", tests.Out + "/mypath2/filtered.txt"}...)
	assert.Error(t, err)

	// Attempt to download the filtered resource but skip the checksum
	runRt(t, "download", tests.RtRepo1+"/a.txt", tests.Out+"/mypath2/filtered.txt", "--skip-checksum")

	cleanArtifactoryTest()
}

func TestArtifactoryEmptyBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	buildNumber := "5"

	// Try to upload with non-existent pattern
	runRt(t, "upload", "*.notExist", tests.RtRepo1, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)

	// Try to download with non-existent pattern
	runRt(t, "download", tests.RtRepo1+"/*.notExist", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)

	// Publish empty build info
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)

	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryPublishBuildUsingBuildFile(t *testing.T) {
	initArtifactoryTest(t, "")
	defer cleanArtifactoryTest()
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	// Create temp folder.
	tmpDir, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()
	// Create build config in temp folder
	_, err := tests.ReplaceTemplateVariables(filepath.Join("testdata", "buildspecs", "build.yaml"), filepath.Join(tmpDir, ".jfrog", "projects"))
	assert.NoError(t, err)

	// Run cd command to temp dir.
	wdCopy, err := os.Getwd()
	require.NoError(t, err)
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wdCopy, tmpDir)
	defer chdirCallback()
	// Upload file to create build-info data using the build.yaml file.
	runRt(t, "upload", filepath.Join(wdCopy, "testdata", "a", "a1.in"), tests.RtRepo1+"/foo")

	// Publish build-info using the build.yaml file.
	runRt(t, "build-publish")

	// Search artifacts based on the published build.
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Build(tests.RtBuildName1 + "/1")
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())

	// Validate the search result.
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	searchResultLength, err := reader.Length()
	assert.NoError(t, err)
	assert.Equal(t, 1, searchResultLength)

	// Upload file to create a second build-info data.
	runRt(t, "upload", filepath.Join(wdCopy, "testdata", "a", "a1.in"), tests.RtRepo1+"/bla-bla")

	// Publish the second build-info build.yaml file.
	runRt(t, "build-publish")

	// Search artifacts based on the second published build.
	searchSpecBuilder = spec.NewBuilder().Pattern(tests.RtRepo1).Build(tests.RtBuildName1 + "/2")
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())

	// Validate the search result.
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	searchResultLength, err = reader.Length()
	assert.NoError(t, err)
	assert.Equal(t, 1, searchResultLength)

	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
}

func TestArtifactoryDownloadFromVirtual(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/a/*", tests.RtRepo1, "--flat=false")
	runRt(t, "dl", tests.RtVirtualRepo+"/testdata/(*)", tests.Out+"/"+"{1}", "--flat=true")

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally(tests.GetVirtualDownloadExpected(), paths, t)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndUploadWithProgressBar(t *testing.T) {
	initArtifactoryTest(t, "")

	callback := commontests.MockProgressInitialization()
	defer callback()

	runRt(t, "upload", "testdata/a/*", tests.RtRepo1, "--flat=false")
	runRt(t, "dl", tests.RtVirtualRepo+"/testdata/(*)", tests.Out+"/"+"{1}", "--flat=true")

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally(tests.GetVirtualDownloadExpected(), paths, t)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadPathWithSpecialChars(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", getSpecialCharFilePath(), tests.RtRepo1, "--flat=false")
	runRt(t, "upload", "testdata/c#/a#1.in", tests.RtRepo1, "--flat=false")

	runRt(t, "dl", tests.RtRepo1+"/testdata/a$+~&^a#/a*", tests.Out+fileutils.GetFileSeparator(), "--flat=true")
	runRt(t, "dl", tests.RtRepo1+"/testdata/c#/a#1.in", tests.Out+fileutils.GetFileSeparator(), "--flat=true")

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a1.in"), filepath.Join(tests.Out, "a#1.in")}, paths, t)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadPatternWithUnicodeChars(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/unicode/", tests.RtRepo1, "--flat=false")

	// Verify files exist
	specFile, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetDownloadUnicode(), specFile, serverDetails, t)

	runRt(t, "dl", tests.RtRepo1+"/testdata/unicode/(dirλrectory)/", filepath.Join(tests.Out, "{1}")+fileutils.GetFileSeparator(), "--flat=true")

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical([]string{
		tests.Out,
		filepath.Join(tests.Out, "dirλrectory"),
		filepath.Join(tests.Out, "dirλrectory", "文件.in"),
		filepath.Join(tests.Out, "dirλrectory", "aȩ.ȥ1"),
	}, paths)
	assert.NoError(t, err)

	cleanArtifactoryTest()
}

func TestArtifactoryConcurrentDownload(t *testing.T) {
	testArtifactoryDownload(flagkit.DownloadMinSplitKb*1000, t)
}

func TestArtifactoryBulkDownload(t *testing.T) {
	testArtifactoryDownload(flagkit.DownloadMinSplitKb*1000-1, t)
}

func testArtifactoryDownload(fileSize int, t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)
	randFile, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "randFile"), fileSize)
	assert.NoError(t, err)
	localFileDetails, err := fileutils.GetFileDetails(randFile.Name(), true)
	assert.NoError(t, err)

	runRt(t, "u", randFile.Name(), tests.RtRepo1+"/testdata/", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "dl", tests.RtRepo1+"/testdata/", tests.Out+fileutils.GetFileSeparator(), "--flat=true")

	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "randFile")}, paths, t)
	tests.ValidateChecksums(filepath.Join(tests.Out, "randFile"), localFileDetails.Checksum, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadWildcardInRepo(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	// Upload a file to repo1 and another one to repo2
	runRt(t, "upload", filePath, tests.RtRepo1+"/path/a1.in")
	runRt(t, "upload", filePath, tests.RtRepo2+"/path/a2.in")

	specFile, err := tests.CreateSpec(tests.DownloadWildcardRepo)
	assert.NoError(t, err)

	// Verify the 2 files exist using `*` in the repository name
	inttestutils.VerifyExistInArtifactory(tests.GetDownloadWildcardRepo(), specFile, serverDetails, t)

	// Download the 2 files with `*` in the repository name
	runRt(t, "dl", "--spec="+specFile)
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a1.in"), filepath.Join(tests.Out, "a2.in")}, paths, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadPlaceholderInRepo(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	// Upload a file to repo1 and another one to repo2
	runRt(t, "upload", filePath, tests.RtRepo1+"/path/a1.in")
	runRt(t, "upload", filePath, tests.RtRepo2+"/path/a2.in")

	specFile, err := tests.CreateSpec(tests.DownloadWildcardRepo)
	assert.NoError(t, err)

	// Verify the 2 files exist
	inttestutils.VerifyExistInArtifactory(tests.GetDownloadWildcardRepo(), specFile, serverDetails, t)

	// Download the 2 files with placeholders in the repository name
	runRt(t, "dl", tests.RtRepo1And2Placeholder, tests.Out+"/a/{1}/", "--flat=true")
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a", "1", "a1.in"), filepath.Join(tests.Out, "a", "2", "a2.in")}, paths, t)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadPlaceholderFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	for _, flatValue := range []string{"true", "false"} {
		runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo1+"/path/{1}", "--flat="+flatValue)
		searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")

		runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo1+"/path/{1}/", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolderlashSlashSuffix(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")

		runRt(t, "upload", "testdata/a/b/(*)/(*)", tests.RtRepo1+"/path/{1}/{2}", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedDoublePlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")
	}
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadWithPlaceholderFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload test data to Artifactory
	runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo1+"/path/{1}")
	// Download the tests data using placeholder with flat
	for _, flatValue := range []string{"true", "false"} {
		runRt(t, "download", tests.RtRepo1+"/path/(*)", tests.Out+"/mypath2/{1}", "--flat="+flatValue)
		paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
		assert.NoError(t, err)
		checkSyncedDirContent(tests.GetFileWithDownloadedPlaceHolder(), paths, t)
		clientTestUtils.RemoveAllAndAssert(t, tests.Out)

		runRt(t, "download", tests.RtRepo1+"/path/(*)", tests.Out+"/mypath2/{1}/", "--flat="+flatValue)
		paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
		assert.NoError(t, err)
		checkSyncedDirContent(tests.GetFileWithDownloadedPlaceHolderSlashSuffix(), paths, t)
		clientTestUtils.RemoveAllAndAssert(t, tests.Out)

		runRt(t, "download", tests.RtRepo1+"/path/(*)/(*)", tests.Out+"/mypath2/{1}/{2}", "--flat="+flatValue)
		paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
		assert.NoError(t, err)
		checkSyncedDirContent(tests.GetFileWithDownloadedDoublePlaceHolder(), paths, t)
		clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	}
	cleanArtifactoryTest()
}

func TestArtifactoryCopyWithPlaceholderFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload test data to Artifactory
	runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo2+"/mypath2/{1}")
	// Download the tests data using placeholder with flat
	for _, flatValue := range []string{"true", "false"} {
		runRt(t, "copy", tests.RtRepo2+"/mypath2/(*)", tests.RtRepo1+"/path/{1}", "--flat="+flatValue)
		searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")

		runRt(t, "copy", tests.RtRepo2+"/mypath2/(*)", tests.RtRepo1+"/path/{1}/", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolderlashSlashSuffix(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")

		runRt(t, "copy", tests.RtRepo2+"/mypath2/(*)/(*)", tests.RtRepo1+"/path/{1}/{2}", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedDoublePlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")
	}
	cleanArtifactoryTest()
}

func TestArtifactoryMoveWithPlaceholderFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	// Download the tests data using placeholder with flat
	for _, flatValue := range []string{"true", "false"} {
		runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo2+"/mypath2/{1}")
		runRt(t, "move", tests.RtRepo2+"/mypath2/(*)", tests.RtRepo1+"/path/{1}", "--flat="+flatValue)
		searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")
		runRt(t, "del", tests.RtRepo2+"/*")

		runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo2+"/mypath2/{1}")
		runRt(t, "move", tests.RtRepo2+"/mypath2/(*)", tests.RtRepo1+"/path/{1}/", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedPlaceHolderlashSlashSuffix(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")
		runRt(t, "del", tests.RtRepo2+"/*")

		runRt(t, "upload", "testdata/a/b/(*)", tests.RtRepo2+"/mypath2/{1}")
		runRt(t, "move", tests.RtRepo2+"/mypath2/(*)/(*)", tests.RtRepo1+"/path/{1}/{2}", "--flat="+flatValue)
		searchPath, err = tests.CreateSpec(tests.SearchAllRepo1)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetUploadedFileWithDownloadedDoublePlaceHolder(), searchPath, serverDetails, t)
		runRt(t, "del", tests.RtRepo1+"/*")
		runRt(t, "del", tests.RtRepo2+"/*")
	}
	cleanArtifactoryTest()
}

func TestArtifactoryCopySingleFileNonFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/", "--flat")
	runRt(t, "cp", tests.RtRepo1+"/path/a1.in", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyPrefixFilesFlat(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/prefix/(*)", tests.RtRepo1+"/prefix/prefix-{1}")
	runRt(t, "cp", tests.RtRepo1+"/prefix/*", tests.RtRepo2, "--flat")
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetPrefixFilesCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestAqlFindingItemOnRoot(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/", "--flat=true")
	runRt(t, "upload", filePath, tests.RtRepo1+"/someFile", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/*", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAnyItemCopy(), searchPath, serverDetails, t)
	runRt(t, "del", tests.RtRepo2+"/*")
	runRt(t, "del", tests.RtRepo1+"/*")
	runRt(t, "upload", filePath, tests.RtRepo1+"/path/", "--flat=true")
	runRt(t, "upload", filePath, tests.RtRepo1+"/someFile", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/*/", tests.RtRepo2)
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestExitCode(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload dummy file in order to test move and copy commands
	runRt(t, "upload", path.Join("testdata", "a", "a1.in"), tests.RtRepo1)

	// Discard output logging to prevent negative logs
	previousLogger := tests.RedirectLogOutputToNil()
	defer log.SetLogger(previousLogger)
	defer clientTestUtils.UnSetEnvAndAssert(t, coreutils.FailNoOp)

	// Test upload commands
	err := artifactoryCli.Exec("upload", "DummyText", tests.RtRepo1, "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeError, err)
	err = artifactoryCli.Exec("upload", path.Join("testdata", "a", "a1.in"), "DummyTargetPath")
	checkExitCode(t, coreutils.ExitCodeError, err)
	err = artifactoryCli.Exec("upload", "testdata/a/(*.dummyExt)", tests.RtRepo1+"/{1}.in", "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("upload", "testdata/a/(*.dummyExt)", tests.RtRepo1+"/{1}.in")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test download command
	err = artifactoryCli.Exec("dl", "DummyFolder", "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("dl", "DummyFolder")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test move commands
	err = artifactoryCli.Exec("move", tests.RtRepo1, "DummyTargetPath")
	checkExitCode(t, coreutils.ExitCodeError, err)
	err = artifactoryCli.Exec("move", "DummyText", tests.RtRepo1, "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("move", "DummyText", tests.RtRepo1)
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test copy commands
	err = artifactoryCli.Exec("copy", tests.RtRepo1, "DummyTargetPath")
	checkExitCode(t, coreutils.ExitCodeError, err)
	err = artifactoryCli.Exec("copy", "DummyText", tests.RtRepo1, "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("copy", "DummyText", tests.RtRepo1)
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test delete command
	err = artifactoryCli.Exec("delete", "DummyText", "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("delete", "DummyText")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test search command
	err = artifactoryCli.Exec("s", "DummyText", "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("s", "DummyText")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	// Test props commands
	err = artifactoryCli.Exec("sp", "DummyText", "prop=val;key=value", "--fail-no-op=true")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("sp", "DummyText", "prop=val;key=value")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	err = artifactoryCli.Exec("delp", "DummyText", "prop=val;key=valuos.Unsetenv(coreutils.FailNoOp)e", "--fail-no-op=true")

	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Setenv(coreutils.FailNoOp, "true"))
	err = artifactoryCli.Exec("delp", "DummyText", "prop=val;key=value")
	checkExitCode(t, coreutils.ExitCodeFailNoOp, err)
	assert.NoError(t, os.Unsetenv(coreutils.FailNoOp))

	cleanArtifactoryTest()
}

func checkExitCode(t *testing.T, expected coreutils.ExitCode, er error) {
	switch underlyingType := er.(type) {
	case coreutils.CliError:
		assert.Equal(t, expected, underlyingType.ExitCode)
	default:
		assert.Fail(t, "Exit code expected error code %v, got %v", expected.Code, er)
	}
}
func TestArtifactoryDirectoryCopy(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/path/", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDirectoryCopyUsingWildcard(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/*/", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyFilesNameWithParentheses(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/b/*", tests.RtRepo1, "--flat=false")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(/(.in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(b/(b.in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/b(/b(.in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/b)/b).in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(b)/(b).in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/)b/)b.in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/)b)/)b).in", tests.RtRepo2)
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(b/(b.in", tests.RtRepo2+"/()/", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(b)/(b).in", tests.RtRepo2+"/()/")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/b(/b(.in", tests.RtRepo2+"/(/", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(/(*.in)", tests.RtRepo2+"/c/{1}.zip", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/(/(*.in)", tests.RtRepo2+"/(/{1}.zip")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/b(/(b*.in)", tests.RtRepo2+"/(/{1}-up", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/testdata/b/b(/(*).(*)", tests.RtRepo2+"/(/{2}-{1}", "--flat=true")

	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetCopyFileNameWithParentheses(), searchPath, serverDetails, t)

	cleanArtifactoryTest()
}

func TestArtifactoryCreateUsers(t *testing.T) {
	initArtifactoryTest(t, "")
	usersCSVPath := "testdata/usersmanagement/users.csv"
	randomUsersCSVPath, err := tests.ReplaceTemplateVariables(usersCSVPath, "")
	assert.NoError(t, err)
	runRt(t, "users-create", "--csv="+randomUsersCSVPath)
	// Clean up
	defer func() {
		runRt(t, "users-delete", "--csv="+randomUsersCSVPath)
		cleanArtifactoryTest()
	}()

	verifyUsersExistInArtifactory(randomUsersCSVPath, t)
}

func verifyUsersExistInArtifactory(csvFilePath string, t *testing.T) {
	// Parse input CSV
	output, err := os.Open(csvFilePath)
	assert.NoError(t, err)
	csvReader := csv.NewReader(output)
	// Ignore the header
	_, err = csvReader.Read()
	assert.NoError(t, err)
	for {
		// Read each record from csv
		record, err := csvReader.Read()
		if err == io.EOF {
			break
		}
		user, password := record[0], record[1]
		err = coretests.NewJfrogCli(execMain, "jfrog rt", "--url="+serverDetails.ArtifactoryUrl+" --user="+user+" --password="+password).Exec("ping")
		assert.NoError(t, err)
	}

}

// Upload files with parenthesis in their path.
func TestArtifactoryUploadFilesNameWithParenthesis(t *testing.T) {
	initArtifactoryTest(t, "")

	specFile, err := tests.CreateSpec(tests.UploadFileWithParenthesesSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadFileNameWithParentheses(), searchPath, serverDetails, t)

	cleanArtifactoryTest()
}

// Upload files with parenthesis in their path, combining regexp.
func TestArtifactoryUploadFilesNameWithParenthesisAndRegexp(t *testing.T) {
	initArtifactoryTest(t, "")

	specFile, err := tests.CreateSpec(tests.UploadFileWithParenthesesAndRegexpSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadFileNameWithParenthesesAndRegexp(), searchPath, serverDetails, t)

	cleanArtifactoryTest()
}

// Upload files with parenthesis in their path, combining placeholders.
func TestArtifactoryUploadFilesNameWithParenthesisAndPlaceholders(t *testing.T) {
	initArtifactoryTest(t, "")

	specFile, err := tests.CreateSpec(tests.UploadFileWithParenthesesAndPlaceholdersSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadFileNameWithParenthesesAndPlaceholders(), searchPath, serverDetails, t)

	cleanArtifactoryTest()
}

// Upload files with parenthesis in their path, combining placeholders and regexp.
func TestArtifactoryUploadFilesNameWithParenthesisAndPlaceHoldersAndRegexp(t *testing.T) {
	initArtifactoryTest(t, "")

	specFile, err := tests.CreateSpec(tests.UploadFileWithParenthesesAndPlaceholdersAndRegexpSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	searchPath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadFileNameWithParenthesesAndPlaceholdersAndRegexp(), searchPath, serverDetails, t)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadFilesNameWithParenthesis(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/b/*", tests.RtRepo1, "--flat=false")
	runRt(t, "download", path.Join(tests.RtRepo1), tests.Out+"/")

	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally(tests.GetFileWithParenthesesDownload(), paths, t)

	cleanArtifactoryTest()
}
func TestArtifactoryDownloadDotAsTarget(t *testing.T) {
	initArtifactoryTest(t, "")
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
	_, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "DownloadDotAsTarget"), 100000)
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1+"/p-modules/", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))

	wd, err := os.Getwd()
	assert.NoError(t, err, "Failed to get current dir")
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, tests.Out)
	defer chdirCallback()

	runRt(t, "download", tests.RtRepo1+"/p-modules/DownloadDotAsTarget", ".")
	chdirCallback()

	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally([]string{tests.Out, filepath.Join(tests.Out, "p-modules"), filepath.Join(tests.Out, "p-modules", "DownloadDotAsTarget")}, paths, t)
	assert.NoError(t, fileutils.RemoveTempDir(tests.Out), "Couldn't remove temp dir")
	cleanArtifactoryTest()
}

func TestArtifactoryDirectoryCopyUsingWildcardFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/path/inner", tests.RtRepo2, "--flat=true")
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetSingleDirectoryCopyFlat(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyPathsTwice(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()
	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/", "--flat")

	log.Info("Copy Folder to root twice")
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopyFullPath(), searchPath, serverDetails, t)
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2)
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopyFullPath(), searchPath, serverDetails, t)
	runRt(t, "del", tests.RtRepo2)

	log.Info("Copy to from repo1/path to repo2/path twice")
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2+"/path")
	inttestutils.VerifyExistInArtifactory(tests.GetSingleFileCopyFullPath(), searchPath, serverDetails, t)
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2+"/path")
	inttestutils.VerifyExistInArtifactory(tests.GetFolderCopyTwice(), searchPath, serverDetails, t)
	runRt(t, "del", tests.RtRepo2)

	log.Info("Copy to from repo1/path/ to repo2/path/ twice")
	runRt(t, "cp", tests.RtRepo1+"/path/", tests.RtRepo2+"/path/")
	inttestutils.VerifyExistInArtifactory(tests.GetSingleInnerFileCopyFullPath(), searchPath, serverDetails, t)
	runRt(t, "cp", tests.RtRepo1+"/path/", tests.RtRepo2+"/path/")
	inttestutils.VerifyExistInArtifactory(tests.GetSingleInnerFileCopyFullPath(), searchPath, serverDetails, t)
	runRt(t, "del", tests.RtRepo2)

	log.Info("Copy to from repo1/path/ to repo2/path/ twice")
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2+"/path/")
	inttestutils.VerifyExistInArtifactory(tests.GetFolderCopyIntoFolder(), searchPath, serverDetails, t)
	runRt(t, "cp", tests.RtRepo1+"/path", tests.RtRepo2+"/path/")
	inttestutils.VerifyExistInArtifactory(tests.GetFolderCopyIntoFolder(), searchPath, serverDetails, t)
	runRt(t, "del", tests.RtRepo2)

	cleanArtifactoryTest()
}

func TestArtifactoryDirectoryCopyPatternEndsWithSlash(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/")
	runRt(t, "cp", tests.RtRepo1+"/path/", tests.RtRepo2, "--flat=true")
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAnyItemCopyUsingSpec(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyAnyItemUsingWildcardFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/", "--flat")
	runRt(t, "upload", filePath, tests.RtRepo1+"/someFile", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/*", tests.RtRepo2)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetAnyItemCopy(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyAnyItemRecursive(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/a/b/", "--flat")
	runRt(t, "upload", filePath, tests.RtRepo1+"/aFile", "--flat=true")
	runRt(t, "cp", tests.RtRepo1+"/a*", tests.RtRepo2, "--recursive=true")
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAnyItemCopyRecursive(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyAndRenameFolder(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/", "--flat")
	runRt(t, "cp", tests.RtRepo1+"/path/(*)", tests.RtRepo2+"/newPath/{1}")
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetCopyFolderRename(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyAnyItemUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	var filePath = getSpecialCharFilePath()

	specFile, err := tests.CreateSpec(tests.CopyItemsSpec)
	assert.NoError(t, err)
	searchPath, err := tests.CreateSpec(tests.SearchRepo2)
	assert.NoError(t, err)
	runRt(t, "upload", filePath, tests.RtRepo1+"/path/inner/")
	runRt(t, "upload", filePath, tests.RtRepo1+"/someFile", "--flat=true")
	runRt(t, "cp", "--spec="+specFile)
	inttestutils.VerifyExistInArtifactory(tests.GetAnyItemCopyUsingSpec(), searchPath, serverDetails, t)
	cleanArtifactoryTest()
}

func getSpecialCharFilePath() string {
	return "testdata/a$+~&^a#/a*"
}

func getAntPatternFilePath() string {
	return "testdata/cache/downloa?/**/*.in"
}

func TestArtifactoryCopyNoSpec(t *testing.T) {
	testCopyMoveNoSpec("cp", tests.GetBuildBeforeCopyExpected(), tests.GetBuildCopyExpected(), t)
}

func TestArtifactoryCopyExcludeByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Copy by pattern
	runRt(t, "cp", tests.RtRepo1+"/data/", tests.RtRepo2+"/", "--exclusions=*/*b*;*/*c*")

	// Validate files are moved by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetBuildCopyExclude(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadDebian(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.DebianUploadSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile, "--deb=bionic/main/i386")
	verifyExistInArtifactoryByProps(tests.GetUploadDebianExpected(), tests.RtDebianRepo+"/*", "deb.distribution=bionic;deb.component=main;deb.architecture=i386", t)
	runRt(t, "upload", "--spec="+specFile, "--deb=cosmic/main\\/18.10/amd64")
	verifyExistInArtifactoryByProps(tests.GetUploadDebianExpected(), tests.RtDebianRepo+"/*", "deb.distribution=cosmic;deb.component=main/18.10;deb.architecture=amd64", t)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadAndExplode(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", filepath.Join("testdata", "archives", "a.zip"), tests.RtRepo1, "--explode=true", "--flat")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetExplodeUploadExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestUploadAndSyncDeleteCaseSensitivity(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "--sync-deletes", tests.RtRepo1+"/", path.Join("testdata", "syncdeletes", "*"), tests.RtRepo1+"/")
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	resultItems, err := inttestutils.SearchInArtifactory(searchFilePath, serverDetails, t)
	assert.NoError(t, err)
	assert.Len(t, resultItems, 5)
	// Make sure files are being deleted for the second sync-deletes upload
	runRt(t, "upload", "--sync-deletes", tests.RtRepo1+"/", path.Join("testdata", "syncdeletes", "industrial-os-7.4.3", "TestReport", "*"), tests.RtRepo1+"/")
	resultItems, err = inttestutils.SearchInArtifactory(searchFilePath, serverDetails, t)
	assert.NoError(t, err)
	assert.Len(t, resultItems, 1)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadAndSyncDelete(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload all testdata/a/
	runRt(t, "upload", path.Join("testdata", "a", "*"), tests.RtRepo1+"/syncDir/", "--flat=false")
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadExpectedRepo1SyncDeleteStep1(), searchFilePath, serverDetails, t)
	// Upload testdata/a/b/*1.in and sync syncDir/testdata/a/b/
	runRt(t, "upload", path.Join("testdata", "a", "b", "*1.in"), tests.RtRepo1+"/syncDir/", "--sync-deletes="+tests.RtRepo1+"/syncDir/testdata/a/b/", "--flat=false")
	searchFilePath, err = tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadExpectedRepo1SyncDeleteStep2(), searchFilePath, serverDetails, t)
	// Upload testdata/archives/* and sync syncDir/
	runRt(t, "upload", path.Join("testdata", "archives", "*"), tests.RtRepo1+"/syncDir/", "--sync-deletes="+tests.RtRepo1+"/syncDir/", "--flat=true")
	searchFilePath, err = tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadExpectedRepo1SyncDeleteStep3(), searchFilePath, serverDetails, t)
	// Upload testdata/b/ and sync syncDir/testdata/b/b
	// Noticed that testdata/c/ includes sub folders with special chars like '-' and '#'
	runRt(t, "upload", path.Join("testdata", "c", "*"), tests.RtRepo1+"/syncDir/", "--sync-deletes="+tests.RtRepo1+"/syncDir/", "--flat=false")
	searchFilePath, err = tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadExpectedRepo1SyncDeleteStep4(), searchFilePath, serverDetails, t)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndExplode(t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	randFile, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "randFile"), 100000)
	assert.NoError(t, err)

	err = archiver.Archive([]string{randFile.Name()}, filepath.Join(tests.Out, "concurrent.tar.gz"))
	assert.NoError(t, err)
	err = archiver.Archive([]string{randFile.Name()}, filepath.Join(tests.Out, "bulk.tar"))
	assert.NoError(t, err)
	err = archiver.Archive([]string{randFile.Name()}, filepath.Join(tests.Out, "zipFile.zip"))
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1, "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	// Download 'concurrent.tar.gz' as 'concurrent' file name and explode it.
	runRt(t, "download", path.Join(tests.RtRepo1, "concurrent.tar.gz"), tests.Out+"/concurrent", "--explode=true")
	// Download 'concurrent.tar.gz' and explode it.
	runRt(t, "download", path.Join(tests.RtRepo1, "concurrent.tar.gz"), tests.Out+"/", "--explode=true")
	// Download 'concurrent.tar.gz' without explode it.
	runRt(t, "download", path.Join(tests.RtRepo1, "concurrent.tar.gz"), tests.Out+"/", "--explode=false")
	// Try to explode the archive that already been downloaded.
	runRt(t, "download", path.Join(tests.RtRepo1, "concurrent.tar.gz"), tests.Out+"/", "--explode=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "download", path.Join(tests.RtRepo1, "randFile"), tests.Out+"/", "--explode=true")
	runRt(t, "download", path.Join(tests.RtRepo1, "concurrent.tar.gz"), tests.Out+"/", "--explode=false")
	runRt(t, "download", path.Join(tests.RtRepo1, "bulk.tar"), tests.Out+"/", "--explode=true")
	runRt(t, "download", path.Join(tests.RtRepo1, "zipFile.zip"), tests.Out+"/", "--explode=true")
	verifyExistAndCleanDir(t, tests.GetExtractedDownload)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndExplodeCurDirAsTarget(t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	randFile, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "DownloadAndExplodeCurDirTarget"), 100000)
	assert.NoError(t, err)

	err = archiver.Archive([]string{randFile.Name()}, filepath.Join(tests.Out, "curDir.tar.gz"))
	assert.NoError(t, err)

	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1, "--flat=true")
	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1+"/p-modules/", "--flat=true")
	assert.NoError(t, fileutils.RemoveTempDir(tests.Out), "Couldn't remove temp dir")

	// Change working dir to tests temp "out" dir
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
	wd, err := os.Getwd()
	assert.NoError(t, err, "Failed to get current dir")
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, tests.Out)
	defer chdirCallback()

	// Dot as target
	runRt(t, "download", tests.RtRepo1+"/p-modules/curDir.tar.gz", ".", "--explode=true")
	// Changing current working dir to "out" dir
	chdirCallback()
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadCurDir)
	clientTestUtils.ChangeDirAndAssert(t, tests.Out)

	// No target
	runRt(t, "download", tests.RtRepo1+"/p-modules/curDir.tar.gz", "--explode=true")
	// Changing working dir for testing
	chdirCallback()
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadCurDir)
	clientTestUtils.ChangeDirAndAssert(t, tests.Out)

	chdirCallback()
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndExplodeFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	file1, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "file1"), 100000)
	assert.NoError(t, err)

	err = archiver.Archive([]string{file1.Name()}, filepath.Join(tests.Out, "flat.tar"))
	assert.NoError(t, err)
	err = archiver.Archive([]string{tests.Out + "/flat.tar"}, filepath.Join(tests.Out, "tarZipFile.zip"))
	assert.NoError(t, err)

	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1+"/checkFlat/dir/", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))

	runRt(t, "download", path.Join(tests.RtRepo1, "checkFlat", "dir", "flat.tar"), tests.Out+"/checkFlat/", "--explode=true", "--flat=true", "--min-split=50")
	runRt(t, "download", path.Join(tests.RtRepo1, "checkFlat", "dir", "tarZipFile.zip"), tests.Out+"/", "--explode=true", "--flat=false")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadFlatFalse)
	// Explode 'flat.tar' while the file exists in the file system using --flat
	runRt(t, "download", path.Join(tests.RtRepo1, "checkFlat", "dir", "tarZipFile.zip"), tests.Out+"/", "--explode=true", "--flat=false")
	runRt(t, "download", path.Join(tests.RtRepo1, "checkFlat", "dir", "flat.tar"), tests.Out+"/checkFlat/dir/", "--explode=true", "--flat", "--min-split=50")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadTarFileFlatFalse)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndExplodeConcurrent(t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	runRt(t, "upload", path.Join("testdata", "archives", "a.zip"), tests.RtRepo1, "--flat=true")
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
	runRt(t, "download", path.Join(tests.RtRepo1, "a.zip"), tests.Out+"/", "--explode=true", "--min-split=50")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadConcurrent)
	runRt(t, "download", path.Join(tests.RtRepo1, "a.zip"), tests.Out+"/", "--explode=false", "--min-split=50")
	verifyExistAndCleanDir(t, tests.GetArchiveConcurrent)
	runRt(t, "download", path.Join(tests.RtRepo1, "a.zip"), tests.Out+"/", "--explode=true", "--split-count=15", "--min-split=50")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadConcurrent)

	cleanArtifactoryTest()
}

func TestArtifactoryDownloadAndExplodeSpecialChars(t *testing.T) {
	initArtifactoryTest(t, "")
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)
	file1, err := gofrogio.CreateRandFile(filepath.Join(tests.Out, "file $+~&^a#1"), 1000)
	assert.NoError(t, err)
	err = archiver.Archive([]string{file1.Name()}, filepath.Join(tests.Out, "a$+~&^a#.tar"))
	assert.NoError(t, err)

	runRt(t, "upload", tests.Out+"/*", tests.RtRepo1+"/dir/", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	err = fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)
	runRt(t, "dl", tests.RtRepo1+"/dir/a$+~&^a#.tar", tests.Out+"/dir $+~&^a# test/", "--flat=true", "--explode")
	runRt(t, "dl", tests.RtRepo1+"/dir/a$+~&^a#.tar", tests.Out+"/dir $+~&^a# test/", "--flat=false", "--explode")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadTarFileSpecialChars)
	// Concurrently download
	runRt(t, "dl", tests.RtRepo1+"/dir/a$+~&^a#.tar", tests.Out+"/dir $+~&^a# test/", "--flat=true", "--explode", "--min-split=50")
	runRt(t, "dl", tests.RtRepo1+"/dir/a$+~&^a#.tar", tests.Out+"/dir $+~&^a# test/", "--flat=false", "--explode", "--min-split=50")
	verifyExistAndCleanDir(t, tests.GetExtractedDownloadTarFileSpecialChars)
	cleanArtifactoryTest()
}

func verifyExistAndCleanDir(t *testing.T, getExtractedDownload func() []string) {
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally(getExtractedDownload(), paths, t)
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
}

func TestArtifactoryUploadAsArchive(t *testing.T) {
	initArtifactoryTest(t, "")

	uploadSpecFile, err := tests.CreateSpec(tests.UploadAsArchive)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+uploadSpecFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadAsArchive(), searchFilePath, serverDetails, t)

	// Verify the properties are valid
	resultItems := searchItemsInArtifactory(t, tests.SearchAllRepo1)
	assert.NotZero(t, len(resultItems))
	for _, item := range resultItems {
		if item.Name != "a.zip" {
			assert.Zero(t, len(item.Properties))
			continue
		}
		properties := item.Properties
		// Commented since CIVCS props will get auto added on upload in this feature
		// And the expected value becomes 6 but the test is expecting 3, so skipping this assertion
		// assert.Equal(t, 3, len(properties))

		// Sort the properties alphabetically by key and value to make the comparison easier
		sort.Slice(properties, func(i, j int) bool {
			if properties[i].Key == properties[j].Key {
				return properties[i].Value < properties[j].Value
			}
			return properties[i].Key < properties[j].Key
		})
		assert.Contains(t, properties, rtutils.Property{Key: "k1", Value: "v11"})
		assert.Contains(t, properties, rtutils.Property{Key: "k1", Value: "v12"})
		assert.Contains(t, properties, rtutils.Property{Key: "k2", Value: "v2"})
	}

	// Check the files inside the archives by downloading and exploding them
	downloadSpecFile, err := tests.CreateSpec(tests.DownloadAndExplodeArchives)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+downloadSpecFile)
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally(tests.GetDownloadArchiveAndExplode(), paths, t)

	cleanArtifactoryTest()
}

func TestArtifactoryUploadAsArchiveWithExplodeAndSymlinks(t *testing.T) {
	initArtifactoryTest(t, "")

	uploadSpecFile, err := tests.CreateSpec(tests.UploadAsArchive)
	assert.NoError(t, err)
	err = artifactoryCli.Exec("upload", "--spec="+uploadSpecFile, "--symlinks", "--explode")
	assert.Error(t, err)

	cleanArtifactoryTest()
}

func TestArtifactoryUploadAsArchiveToDir(t *testing.T) {
	initArtifactoryTest(t, "")

	uploadSpecFile, err := tests.CreateSpec(tests.UploadAsArchiveToDir)
	assert.NoError(t, err)
	err = artifactoryCli.Exec("upload", "--spec="+uploadSpecFile)
	assert.Error(t, err)

	cleanArtifactoryTest()
}

func TestArtifactoryUploadAsArchiveWithIncludeDirs(t *testing.T) {
	initArtifactoryTest(t, "")
	assert.NoError(t, createEmptyTestDir())
	uploadSpecFile, err := tests.CreateSpec(tests.UploadAsArchiveEmptyDirs)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+uploadSpecFile)

	// Check the empty directories inside the archive by downloading and exploding it.
	downloadSpecFile, err := tests.CreateSpec(tests.DownloadAndExplodeArchives)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+downloadSpecFile)
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	downloadedEmptyDirs := tests.GetDownloadArchiveAndExplodeWithIncludeDirs()
	// Verify dirs exists.
	tests.VerifyExistLocally(downloadedEmptyDirs, paths, t)
	// Verify empty dirs.
	verifyEmptyDirs(t, downloadedEmptyDirs)

	// Check the empty directories inside the archive by downloading without exploding it, using os "unzip" command.
	assert.NoError(t, fileutils.RemoveTempDir(tests.Out), "Couldn't remove temp dir")
	assert.NoError(t, os.MkdirAll(tests.Out, 0777))
	downloadSpecFile, err = tests.CreateSpec(tests.DownloadWithoutExplodeArchives)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+downloadSpecFile)
	// Change working directory to the zip file's location and unzip it.
	wd, err := os.Getwd()
	assert.NoError(t, err, "Failed to get current dir")
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, path.Join(tests.Out, "archive", "archive"))
	defer chdirCallback()
	cmd := exec.Command("unzip", "archive.zip")
	assert.NoError(t, errorutils.CheckError(cmd.Run()))
	chdirCallback()
	verifyEmptyDirs(t, downloadedEmptyDirs)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadWorkDirAsArchive(t *testing.T) {
	initArtifactoryTest(t, "")

	uploadSpecFile, err := tests.CreateSpec(tests.UploadWorkingDirectoryAsArchive)
	assert.NoError(t, err)

	// Move to the b directory.
	wd, err := os.Getwd()
	assert.NoError(t, err)
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, path.Join(wd, "testdata", "a", "b"))
	defer chdirCallback()

	// Upload wd.
	runRt(t, "upload", "--spec="+uploadSpecFile)

	// Verify all contents except the top-level directory itself (directory "b") are included in the archive by downloading and exploding it.
	chdirCallback()
	downloadSpecFile, err := tests.CreateSpec(tests.DownloadAndExplodeArchives)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+downloadSpecFile)
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally(tests.GetUploadWorkingDirAsArchive(), paths, t)

	cleanArtifactoryTest()
}

func verifyEmptyDirs(t *testing.T, dirPaths []string) {
	for _, dirPath := range dirPaths {
		empty, err := fileutils.IsDirEmpty(dirPath)
		assert.NoError(t, err)
		assert.True(t, empty)
	}
}

func createEmptyTestDir() error {
	dirInnerPath := filepath.Join("empty", "folder")
	canonicalPath := tests.GetTestResourcesPath() + dirInnerPath
	err := os.MkdirAll(canonicalPath, 0777)
	if err != nil {
		return err
	}
	return os.MkdirAll(filepath.Join(tests.GetTestResourcesPath(), "empty2", "c"), 0777)
}

func TestArtifactoryDownloadAndSyncDeletes(t *testing.T) {
	initArtifactoryTest(t, "")

	outDirPath := tests.Out + string(os.PathSeparator)
	// Upload all testdata/a/ to repo1/syncDir/
	runRt(t, "upload", path.Join("testdata", "a", "*"), tests.RtRepo1+"/syncDir/", "--flat=false")
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetUploadExpectedRepo1SyncDeleteStep1(), searchFilePath, serverDetails, t)

	// Download repo1/syncDir/ to out/
	runRt(t, "download", tests.RtRepo1+"/syncDir/", tests.Out+"/")
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	tests.VerifyExistLocally(tests.GetExpectedSyncDeletesDownloadStep2(), paths, t)

	// Download repo1/syncDir/ to out/ with flat=true and sync out/
	runRt(t, "download", tests.RtRepo1+"/syncDir/", outDirPath, "--flat=true", "--sync-deletes="+outDirPath)
	paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	checkSyncedDirContent(tests.GetExpectedSyncDeletesDownloadStep3(), paths, t)

	// Download all files ended with 2.in from repo1/syncDir/ to out/ and sync out/
	runRt(t, "download", tests.RtRepo1+"/syncDir/*2.in", outDirPath, "--flat=true", "--sync-deletes="+outDirPath)
	paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	checkSyncedDirContent(tests.GetExpectedSyncDeletesDownloadStep4(), paths, t)

	// Download repo1/syncDir/ to out/, exclude the pattern "*c*.in" and sync out/
	runRt(t, "download", tests.RtRepo1+"/syncDir/", outDirPath, "--sync-deletes="+outDirPath+"syncDir"+string(os.PathSeparator), "--exclusions=*/syncDir/testdata/*c*in")
	paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+string(os.PathSeparator)+"syncDir"+string(os.PathSeparator), false)
	assert.NoError(t, err)
	checkSyncedDirContent(tests.GetSyncExpectedDeletesDownloadStep5(), paths, t)

	// Delete all files from repo1/syncDir/
	runRt(t, "delete", tests.RtRepo1+"/syncDir/")
	searchFilePath, err = tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	verifyDoesntExistInArtifactory(searchFilePath, t)

	// Upload all testdata/archives/ to repo1/syncDir/
	runRt(t, "upload", path.Join("testdata", "archives", "*"), tests.RtRepo1+"/syncDir/", "--flat=false")
	searchFilePath, err = tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSyncExpectedDeletesDownloadStep6(), searchFilePath, serverDetails, t)

	// Download repo1/syncDir/ to out/ and sync out/
	runRt(t, "download", tests.RtRepo1+"/syncDir/", outDirPath, "--sync-deletes="+outDirPath+"syncDir"+string(os.PathSeparator))
	paths, err = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+string(os.PathSeparator)+"syncDir"+string(os.PathSeparator), false)
	assert.NoError(t, err)
	checkSyncedDirContent(tests.GetSyncExpectedDeletesDownloadStep7(), paths, t)

	cleanArtifactoryTest()
}

// After syncDeletes we must make sure that the content of the synced directory contains the last operation result only.
// Therefore, we verify that there are no other files in the synced directory, other than the list of the expected files.
func checkSyncedDirContent(expected, actual []string, t *testing.T) {
	// Check if all expected files are actually exist
	tests.VerifyExistLocally(expected, actual, t)
	// Check if all the existing files were expected
	err := isExclusivelyExistLocally(expected, actual)
	assert.NoError(t, err)
}

// Check if only the files we were expecting, exist locally, i.e. return an error if there is a local file we didn't expect.
// Since the "actual" list contains paths of both directories and files, for each element in the "actual" list:
// Check if the path equals to an existing file (for a file) OR
// if the path is a prefix of some path of an existing file (for a dir).
func isExclusivelyExistLocally(expected, actual []string) error {
	expectedLastIndex := len(expected) - 1
	for _, v := range actual {
		for i, r := range expected {
			if strings.HasPrefix(r, v) || v == r {
				break
			}
			if i == expectedLastIndex {
				return errors.New("Should not have : " + v)
			}
		}
	}
	return nil
}

// Test self-signed certificates with Artifactory. For the test, we set up a reverse proxy server.
func TestArtifactorySelfSignedCert(t *testing.T) {
	initArtifactoryTest(t, "")
	tempDirPath, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.HomeDir, tempDirPath)
	defer setEnvCallBack()
	setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, tests.HttpsProxyEnvVar, "1024")
	defer setEnvCallBack()
	go cliproxy.StartLocalReverseHttpProxy(serverDetails.ArtifactoryUrl, false)

	// The two certificate files are created by the reverse proxy on startup in the current directory.
	defer clientTestUtils.RemoveAndAssert(t, certificate.KeyFile)
	defer clientTestUtils.RemoveAndAssert(t, certificate.CertFile)
	// Let's wait for the reverse proxy to start up.
	err := checkIfServerIsUp(cliproxy.GetProxyHttpsPort(), "https", false)
	assert.NoError(t, err)

	fileSpec := spec.NewBuilder().Pattern(tests.RtRepo1 + "/*.zip").Recursive(true).BuildSpec()
	assert.NoError(t, err)
	parsedUrl, err := url.Parse(serverDetails.ArtifactoryUrl)
	assert.NoError(t, err)
	serverDetails.ArtifactoryUrl = "https://127.0.0.1:" + cliproxy.GetProxyHttpsPort() + parsedUrl.RequestURI()

	// The server is using self-signed certificates
	// Without loading the certificates (or skipping verification) we expect all actions to fail due to error: "x509: certificate signed by unknown authority"
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(fileSpec)
	reader, err := searchCmd.Search()
	if reader != nil {
		readerCloseAndAssert(t, reader)
	}
	assert.ErrorContains(t, err, "certificate", "Expected a connection failure, since reverse proxy didn't load self-signed-certs. Connection however is successful")

	// Set insecureTls to true and run again. We expect the command to succeed.
	serverDetails.InsecureTls = true
	searchCmd = generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(fileSpec)
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	readerCloseAndAssert(t, reader)

	// Set insecureTls back to false.
	// Copy the server certificates to the CLI security dir and run again. We expect the command to succeed.
	serverDetails.InsecureTls = false
	certsPath, err := coreutils.GetJfrogCertsDir()
	assert.NoError(t, err)
	err = biutils.CopyFile(certsPath, certificate.KeyFile)
	assert.NoError(t, err)
	err = biutils.CopyFile(certsPath, certificate.CertFile)
	assert.NoError(t, err)
	searchCmd = generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(fileSpec)
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	readerCloseAndAssert(t, reader)

	serverDetails.ArtifactoryUrl = artAuth.GetUrl()
	cleanArtifactoryTest()
}

// Test client certificates with Artifactory. For the test, we set up a reverse proxy server.
func TestArtifactoryClientCert(t *testing.T) {
	initArtifactoryTest(t, "")
	tempDirPath, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.HomeDir, tempDirPath)
	defer setEnvCallBack()
	setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, tests.HttpsProxyEnvVar, "1025")
	defer setEnvCallBack()
	go cliproxy.StartLocalReverseHttpProxy(serverDetails.ArtifactoryUrl, true)

	// The two certificate files are created by the reverse proxy on startup in the current directory.
	defer clientTestUtils.RemoveAndAssert(t, certificate.KeyFile)
	defer clientTestUtils.RemoveAndAssert(t, certificate.CertFile)
	// Let's wait for the reverse proxy to start up.
	err := checkIfServerIsUp(cliproxy.GetProxyHttpsPort(), "https", true)
	assert.NoError(t, err)

	fileSpec := spec.NewBuilder().Pattern(tests.RtRepo1 + "/*.zip").Recursive(true).BuildSpec()
	assert.NoError(t, err)
	parsedUrl, err := url.Parse(serverDetails.ArtifactoryUrl)
	assert.NoError(t, err)
	serverDetails.ArtifactoryUrl = "https://127.0.0.1:" + cliproxy.GetProxyHttpsPort() + parsedUrl.RequestURI()
	serverDetails.InsecureTls = true

	// The server is requiring client certificates
	// Without loading a valid client certificate, we expect all actions to fail due to error: "tls: bad certificate"
	// On Windows, the error can be "wsarecv: An established connection was aborted" (flaky).
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(fileSpec)

	reader, err := searchCmd.Search()
	if reader != nil {
		readerCloseAndAssert(t, reader)
	}
	require.Error(t, err, "Expected a connection failure, since client did not provide a client certificate. Connection however is successful")

	if runtime.GOOS == "windows" && strings.Contains(err.Error(), "wsarecv") {
		for attempt := 1; attempt < 3; attempt++ {
			reader, err = searchCmd.Search()
			if reader != nil {
				readerCloseAndAssert(t, reader)
			}
			require.Error(t, err, "Expected a connection failure, since client did not provide a client certificate. Connection however is successful")
			if !strings.Contains(err.Error(), "wsarecv") {
				break
			}
			time.Sleep(200 * time.Millisecond)
		}
	}
	assert.ErrorContains(t, err, "certificate", "Expected a connection failure, since client did not provide a client certificate. Connection however is successful")

	// Inject client certificates, we expect the search to succeed
	serverDetails.ClientCertPath = certificate.CertFile
	serverDetails.ClientCertKeyPath = certificate.KeyFile

	searchCmd = generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(fileSpec)
	reader, err = searchCmd.Search()
	if reader != nil {
		readerCloseAndAssert(t, reader)
	}
	assert.NoError(t, err)

	serverDetails.ArtifactoryUrl = artAuth.GetUrl()
	serverDetails.InsecureTls = false
	serverDetails.ClientCertPath = ""
	serverDetails.ClientCertKeyPath = ""
	cleanArtifactoryTest()
}

func getExternalIP() (string, error) {
	ifaces, err := net.Interfaces()
	if err != nil {
		return "", err
	}
	for _, iface := range ifaces {
		if iface.Flags&net.FlagUp == 0 {
			continue // interface down
		}
		if iface.Flags&net.FlagLoopback != 0 {
			continue // loopback interface
		}
		addrs, err := iface.Addrs()
		if err != nil {
			return "", err
		}
		for _, addr := range addrs {
			var ip net.IP
			switch v := addr.(type) {
			case *net.IPNet:
				ip = v.IP
			case *net.IPAddr:
				ip = v.IP
			}
			if ip == nil || ip.IsLoopback() {
				continue
			}
			ip = ip.To4()
			if ip == nil {
				continue // not an ipv4 address
			}
			return ip.String(), nil
		}
	}
	return "", errors.New("check connection to the network")
}

// Due to the fact that go reads the HTTP_PROXY and the HTTPS_PROXY
// argument only once we can't set the env var for specific test.
// We need to start a new process with the env var set to the value we want.
// We decide which var to set by the rtUrl scheme.
func TestArtifactoryProxy(t *testing.T) {
	initArtifactoryTest(t, "")
	rtUrl, err := url.Parse(serverDetails.ArtifactoryUrl)
	assert.NoError(t, err)
	var proxyTestArgs []string
	var httpProxyEnv string
	testArgs := []string{"-test.artifactoryProxy=true", "-jfrog.url=" + *tests.JfrogUrl, "-jfrog.user=" + *tests.JfrogUser, "-jfrog.password=" + *tests.JfrogPassword, "-jfrog.sshKeyPath=" + *tests.JfrogSshKeyPath, "-jfrog.sshPassphrase=" + *tests.JfrogSshPassphrase, "-jfrog.adminToken=" + *tests.JfrogAccessToken}
	if rtUrl.Scheme == "https" {
		setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, tests.HttpsProxyEnvVar, "1026")
		defer setEnvCallBack()
		proxyTestArgs = append([]string{"test", "-run=TestArtifactoryHttpsProxyEnvironmentVariableDelegator"}, testArgs...)
		httpProxyEnv = "HTTPS_PROXY=localhost:" + cliproxy.GetProxyHttpsPort()
	} else {
		proxyTestArgs = append([]string{"test", "-run=TestArtifactoryHttpProxyEnvironmentVariableDelegator"}, testArgs...)
		httpProxyEnv = "HTTP_PROXY=localhost:" + cliproxy.GetProxyHttpPort()
	}
	runProxyTest(t, proxyTestArgs, httpProxyEnv)
	cleanArtifactoryTest()
}

func runProxyTest(t *testing.T, proxyTestArgs []string, httpProxyEnv string) {
	cmd := exec.Command("go", proxyTestArgs...)
	cmd.Env = append(os.Environ(), httpProxyEnv)

	tempDirPath, err := tests.GetTestsLogsDir()
	assert.NoError(t, err)
	f, err := os.Create(filepath.Join(tempDirPath, "artifactory_proxy_tests.log"))
	assert.NoError(t, err)

	cmd.Stdout, cmd.Stderr = f, f
	assert.NoError(t, cmd.Run(), "Artifactory proxy tests failed, full report available at the following path:", f.Name())
	log.Info("Full Artifactory proxy testing report available at the following path:", f.Name())
}

// Should be run only by @TestArtifactoryProxy test.
func TestArtifactoryHttpProxyEnvironmentVariableDelegator(t *testing.T) {
	testArtifactoryProxy(t, false)
}

// Should be run only by @TestArtifactoryProxy test.
func TestArtifactoryHttpsProxyEnvironmentVariableDelegator(t *testing.T) {
	testArtifactoryProxy(t, true)
}

func testArtifactoryProxy(t *testing.T, isHttps bool) {
	// Value is set to 'true' via testArgs @TestArtifactoryProxy
	if !*tests.TestArtifactoryProxy {
		t.SkipNow()
	}
	authenticate(true)
	proxyRtUrl := prepareArtifactoryUrlForProxyTest(t)
	searchSpec := spec.NewBuilder().Pattern(tests.RtRepo1 + "/*.zip").Recursive(true).BuildSpec()
	serverDetails.ArtifactoryUrl = proxyRtUrl
	checkForErrDueToMissingProxy(searchSpec, t)
	var port string
	if isHttps {
		go cliproxy.StartHttpsProxy()
		port = cliproxy.GetProxyHttpsPort()
	} else {
		go cliproxy.StartHttpProxy()
		port = cliproxy.GetProxyHttpPort()
	}
	// Let's wait for the reverse proxy to start up.
	err := checkIfServerIsUp(port, "http", false)
	assert.NoError(t, err)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	if reader != nil {
		readerCloseAndAssert(t, reader)
	}
	serverDetails.ArtifactoryUrl = artAuth.GetUrl()
}

func prepareArtifactoryUrlForProxyTest(t *testing.T) string {
	rtUrl, err := url.Parse(serverDetails.ArtifactoryUrl)
	assert.NoError(t, err)
	rtHost := rtUrl.Hostname()
	port := rtUrl.Port()
	if rtHost == "localhost" || rtHost == "127.0.0.1" {
		externalIp, err := getExternalIP()
		assert.NoError(t, err)
		rtUrl.Host = externalIp + ":" + port
	}
	return rtUrl.String()
}

func checkForErrDueToMissingProxy(spec *spec.SpecFiles, t *testing.T) {
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(spec)
	reader, err := searchCmd.Search()
	if reader != nil {
		readerCloseAndAssert(t, reader)
	}
	assert.ErrorContains(t, err, "proxy", "Expected the request to fails, since the proxy is down.", err)
}

func checkIfServerIsUp(port, proxyScheme string, useClientCerts bool) error {
	tr := &http.Transport{
		//#nosec G402 jfrog-ignore - false positive
		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
	}

	if useClientCerts {
		for attempt := 0; attempt < 10; attempt++ {
			if _, err := os.Stat(certificate.CertFile); os.IsNotExist(err) {
				log.Info("Waiting for certificate to appear...")
				time.Sleep(time.Second)
				continue
			}

			if _, err := os.Stat(certificate.KeyFile); os.IsNotExist(err) {
				log.Info("Waiting for key to appear...")
				time.Sleep(time.Second)
				continue
			}

			break
		}

		cert, err := tls.LoadX509KeyPair(certificate.CertFile, certificate.KeyFile)
		if err != nil {
			return fmt.Errorf("failed loading client certificate")
		}
		tr.TLSClientConfig.Certificates = []tls.Certificate{cert}
	}
	// jfrog-ignore - false positive
	client := &http.Client{Transport: tr}

	for attempt := 0; attempt < 20; attempt++ {
		log.Info("Checking if proxy server is up and running.", strconv.Itoa(attempt+1), "attempt.", "URL:", proxyScheme+"://localhost:"+port)
		resp, err := client.Get(proxyScheme + "://localhost:" + port)
		if err != nil {
			time.Sleep(time.Second)
			continue
		}
		err = resp.Body.Close()
		if err != nil {
			log.Error(fmt.Sprintf("Couldn't close response body. Error: %s", err.Error()))
		}
		if resp.StatusCode != http.StatusOK {
			time.Sleep(time.Second)
			continue
		}
		return nil
	}
	return fmt.Errorf("failed while waiting for the proxy server to be accessible")
}

func TestXrayScanBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	xrayServerPort := xray.StartXrayMockServer(t)
	serverUrl := "--url=http://localhost:" + strconv.Itoa(xrayServerPort)
	artifactoryCommandExecutor := coretests.NewJfrogCli(execMain, "jfrog rt", serverUrl+getArtifactoryTestCredentials())
	assert.NoError(t, artifactoryCommandExecutor.Exec("build-scan", xray.CleanScanBuildName, "3"))

	cleanArtifactoryTest()
}

func TestArtifactorySetProperties(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload a file.
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/a.in")
	// Set the 'prop=red' property to the file.
	runRt(t, "sp", tests.RtRepo1+"/a.*", "prop=red")
	// Now let's change the property value, by searching for the 'prop=red'.
	specFile, err := tests.CreateSpec(tests.SetDeletePropsSpec)
	assert.NoError(t, err)
	runRt(t, "sp", "prop=green", "--spec="+specFile)

	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")
	for _, item := range resultItems {
		properties := item.Properties
		assert.GreaterOrEqual(t, len(properties), 1, "Failed setting properties on item:", item.GetItemRelativePath())
		for i, prop := range properties {
			assert.Zero(t, i, "Expected a single property.")
			assert.Equal(t, "prop", prop.Key, "Wrong property key")
			assert.Equal(t, "green", prop.Value, "Wrong property value")
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactorySetPropertiesOnSpecialCharsArtifact(t *testing.T) {
	initArtifactoryTest(t, "")
	targetPath := path.Join(tests.RtRepo1, "a$+~&^a#")
	// Upload a file with special chars.
	runRt(t, "upload", "testdata/a/a1.in", targetPath)
	// Set the 'prop=red' property to the file.
	runRt(t, "sp", targetPath, "prop=red")

	searchSpec, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	resultItems, err := inttestutils.SearchInArtifactory(searchSpec, serverDetails, t)
	assert.NoError(t, err)

	assert.Equal(t, len(resultItems), 1)
	for _, item := range resultItems {
		properties := item.Props
		assert.Equal(t, len(properties), 1)
		for k, v := range properties {
			assert.Equal(t, "prop", k, "Wrong property key")
			assert.Len(t, v, 1)
			assert.Equal(t, "red", v[0], "Wrong property value")
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactorySetPropertiesExcludeByCli(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/")
	runRt(t, "sp", tests.RtRepo1+"/*", "prop=val", "--exclusions=*/*a1.in;*/*a2.in")
	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")
	for _, item := range resultItems {
		if item.Name != "a3.in" {
			continue
		}
		properties := item.Properties
		assert.GreaterOrEqual(t, len(properties), 1, "Failed setting properties on item:", item.GetItemRelativePath())
		for i, prop := range properties {
			assert.Zero(t, i, "Expected single property.")
			assert.Equal(t, "prop", prop.Key, "Wrong property key")
			assert.Equal(t, "val", prop.Value, "Wrong property value")
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactorySetPropertiesExclusionsByCli(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/")
	runRt(t, "sp", tests.RtRepo1+"/*", "prop=val", "--exclusions=*/*a1.in;*/*a2.in")
	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")
	for _, item := range resultItems {
		if item.Name != "a3.in" {
			continue
		}
		properties := item.Properties
		assert.GreaterOrEqual(t, len(properties), 1, "Failed setting properties on item:", item.GetItemRelativePath())
		for i, prop := range properties {
			assert.Zero(t, i, "Expected single property.")
			assert.Equal(t, "prop", prop.Key, "Wrong property key")
			assert.Equal(t, "val", prop.Value, "Wrong property value")
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteProperties(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/a/")
	runRt(t, "sp", tests.RtRepo1+"/a/*", "color=yellow;prop=red;status=ok")
	// Delete the 'color' property.
	runRt(t, "delp", tests.RtRepo1+"/a/*", "color")
	// Delete the 'status' property, by a spec which filters files by 'prop=red'.
	specFile, err := tests.CreateSpec(tests.SetDeletePropsSpec)
	assert.NoError(t, err)
	runRt(t, "delp", "status", "--spec="+specFile)

	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")

	for _, item := range resultItems {
		properties := item.Properties
		for _, prop := range properties {
			assert.False(t, prop.Key == "color" || prop.Key == "status", "Properties 'color' and/or 'status' were not deleted from artifact", item.Name)
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactoryDeletePropertiesWithExclude(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/")
	runRt(t, "sp", tests.RtRepo1+"/*", "prop=val")

	runRt(t, "delp", tests.RtRepo1+"/*", "prop", "--exclusions=*/*a1.in;*/*a2.in")
	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")

	for _, item := range resultItems {
		properties := item.Properties
		for _, prop := range properties {
			if item.Name == "a1.in" || item.Name == "a2.in" {
				// Check that properties were not removed.
				assert.Equal(t, "prop", prop.Key, "Wrong property key")
				assert.Equal(t, "val", prop.Value, "Wrong property value")
			}
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactoryDeletePropertiesWithExclusions(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/")
	runRt(t, "sp", tests.RtRepo1+"/*", "prop=val")

	runRt(t, "delp", tests.RtRepo1+"/*", "prop", "--exclusions=*/*a1.in;*/*a2.in")
	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")

	for _, item := range resultItems {
		properties := item.Properties
		for _, prop := range properties {
			if item.Name == "a1.in" || item.Name == "a2.in" {
				// Check that properties were not removed.
				assert.False(t, prop.Key != "prop" || prop.Value != "val", "Wrong properties")
			}
		}
	}
	cleanArtifactoryTest()
}

func TestArtifactoryUploadOneArtifactToMultipleLocation(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumber := "333"
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/root/", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)
	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, tests.RtBuildName1, buildNumber)
	if err != nil {
		assert.NoError(t, err)
		return
	}
	if !found {
		assert.True(t, found, "build info was expected to be found")
		return
	}
	assert.Equal(t, 2, len(publishedBuildInfo.BuildInfo.Modules[0].Artifacts))
	cleanArtifactoryTest()
}

func TestArtifactoryUploadFromHomeDir(t *testing.T) {
	initArtifactoryTest(t, "")
	testFileRel, testFileAbs := createFileInHomeDir(t, "cliTestFile.txt")
	runRt(t, "upload", testFileRel, tests.RtRepo1, "--recursive=false", "--flat=true")
	searchTxtPath, err := tests.CreateSpec(tests.SearchTxt)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetTxtUploadExpectedRepo1(), searchTxtPath, serverDetails, t)
	clientTestUtils.RemoveAndAssert(t, testFileAbs)

	cleanArtifactoryTest()
}

func createFileInHomeDir(t *testing.T, fileName string) (testFileRelPath string, testFileAbsPath string) {
	testFileRelPath = filepath.Join("~", fileName)
	testFileAbsPath = filepath.Join(fileutils.GetHomeDir(), fileName)
	d1 := []byte("test file")
	err := os.WriteFile(testFileAbsPath, d1, 0644)
	assert.NoError(t, err, "Couldn't create file")
	return
}

func TestArtifactoryUploadExcludeByCli1Wildcard(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload files
	runRt(t, "upload", "testdata/a/a*", tests.RtRepo1, "--exclusions=*a2*;*a3.in", "--flat=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadExcludeByCli1Regex(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload files
	runRt(t, "upload", "testdata/a/a(.*)", tests.RtRepo1, "--exclusions=(.*)a2.*;.*a3.in", "--regexp=true", "--flat=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpectedRepo1(), searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryUploadExcludeByCli2Wildcard(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create temp dir
	absDirPath, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()

	// Create temp files
	d1 := []byte("test file")
	err := os.WriteFile(filepath.Join(absDirPath, "cliTestFile1.in"), d1, 0644)
	assert.NoError(t, err, "Couldn't create file")
	err = os.WriteFile(filepath.Join(absDirPath, "cliTestFile2.in"), d1, 0644)
	assert.NoError(t, err, "Couldn't create file")

	// Upload files
	runRt(t, "upload", filepath.ToSlash(absDirPath)+"/*", tests.RtRepo1, "--exclusions=*cliTestFile1*", "--flat=true")

	// Check files exists in artifactory
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory([]string{tests.RtRepo1 + "/cliTestFile2.in"}, searchFilePath, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadExcludeByCli2Regex(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create temp dir
	absDirPath, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()

	// Create temp files
	d1 := []byte("test file")
	err := os.WriteFile(filepath.Join(absDirPath, "cliTestFile1.in"), d1, 0644)
	assert.NoError(t, err, "Couldn't create file")
	err = os.WriteFile(filepath.Join(absDirPath, "cliTestFile2.in"), d1, 0644)
	assert.NoError(t, err, "Couldn't create file")

	// Upload files
	runRt(t, "upload", filepath.ToSlash(absDirPath)+"/(.*)", tests.RtRepo1, "--exclusions=(.*c)liTestFile1.*", "--regexp=true", "--flat=true")

	// Check files exists in artifactory
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory([]string{tests.RtRepo1 + "/cliTestFile2.in"}, searchFilePath, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadExcludeBySpecWildcard(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadSpecExclude)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	// Validate files are moved by build number
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetUploadSpecExcludeRepo1(), searchFilePath, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadExcludeBySpecRegex(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadSpecExcludeRegex)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	// Validate files are moved by build number
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetUploadSpecExcludeRepo1(), searchFilePath, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadWithRegexEscaping(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload files
	runRt(t, "upload", "testdata/regexp"+"(.*)"+"\\."+".*", tests.RtRepo1, "--regexp=true", "--flat=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory([]string{tests.RtRepo1 + "/has.dot"}, searchFilePath, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryCopySpec(t *testing.T) {
	testMoveCopySpec("copy", t)
}

func TestArtifactoryMoveSpec(t *testing.T) {
	testMoveCopySpec("move", t)
}

func testMoveCopySpec(command string, t *testing.T) {
	initArtifactoryTest(t, "")
	preUploadBasicTestResources(t)
	specFile, err := tests.CreateSpec(tests.CopyMoveSimpleSpec)
	assert.NoError(t, err)
	runRt(t, command, "--spec="+specFile)

	// Verify files exist in target location successfully
	searchMovedCopiedSpec, err := tests.CreateSpec(tests.SearchTargetInRepo2)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetMoveCopySpecExpected(), searchMovedCopiedSpec, serverDetails, t)

	searchOriginalSpec, err := tests.CreateSpec(tests.SearchRepo1TestResources)
	assert.NoError(t, err)

	if command == "copy" {
		// Verify original files still exist
		inttestutils.VerifyExistInArtifactory(tests.GetRepo1TestResourcesExpected(), searchOriginalSpec, serverDetails, t)
	} else {
		// Verify original files were moved
		verifyDoesntExistInArtifactory(searchOriginalSpec, t)
	}

	cleanArtifactoryTest()
}

// Upload symlink by full path to Artifactory and the link content checksum
// Download the symlink which was uploaded.
// validate the symlink content checksum
func TestValidateValidSymlink(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	// Path to local file
	localFile := filepath.Join(tests.GetTestResourcesPath()+"a", "a1.in")
	// Path to valid symLink
	validLink := filepath.Join(tests.GetTestResourcesPath()+"a", "link")

	// Link valid symLink to local file
	err := os.Symlink(localFile, validLink)
	assert.NoError(t, err)

	// Upload symlink to artifactory
	runRt(t, "u", validLink, tests.RtRepo1, "--symlinks=true", "--flat=true")

	// Delete the local symlink
	clientTestUtils.RemoveAndAssert(t, validLink)

	// Download symlink from artifactory
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/", "--validate-symlinks=true")

	// Should be valid if successful
	validateSymLink(validLink, localFile, t)

	// Delete symlink and clean
	clientTestUtils.RemoveAndAssert(t, validLink)

	cleanArtifactoryTest()
}

// Upload symlink by full path to Artifactory and the link content checksum
// Unlink and delete the pointed file.
// Download the symlink which was uploaded with validation. The command should fail.
func TestValidateBrokenSymlink(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	// Create temporary file in resourcesPath/a/
	tmpFile, err := os.CreateTemp(tests.GetTestResourcesPath()+"a/", "a.in.")
	if assert.NoError(t, err) {
		assert.NoError(t, tmpFile.Close())
	}
	localFile := tmpFile.Name()

	// Path to the symLink
	linkPath := filepath.Join(tests.GetTestResourcesPath()+"a/", "link")
	// Link to the temporary file
	err = os.Symlink(localFile, linkPath)
	assert.NoError(t, err)

	// Upload symlink to artifactory
	runRt(t, "u", linkPath, tests.RtRepo1, "--symlinks=true", "--flat=true")

	// Delete the local symlink and the temporary file
	clientTestUtils.RemoveAndAssert(t, linkPath)
	clientTestUtils.RemoveAndAssert(t, localFile)

	// Try downloading symlink from artifactory. Since the link should be broken, it shouldn't be downloaded
	err = artifactoryCli.Exec("dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/", "--validate-symlinks=true")
	if !assert.Error(t, err, "A broken symLink was downloaded although validate-symlinks flag was set to true") {
		clientTestUtils.RemoveAndAssert(t, linkPath)
	}

	// Clean
	cleanArtifactoryTest()
}

// Testing exclude pattern with symlinks.
// This test should not upload any files.
func TestExcludeBrokenSymlink(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")

	// Creating broken symlink
	assert.NoError(t, os.Mkdir(tests.Out, 0777))
	linkToNonExistingPath := filepath.Join(tests.Out, "link_to_non_existing_path")
	err := os.Symlink("non_existing_path", linkToNonExistingPath)
	assert.NoError(t, err)

	// This command should succeed because all artifacts are excluded.
	runRt(t, "u", filepath.Join(tests.Out, "*"), tests.RtRepo1, "--symlinks=true", "--exclusions=*")
	cleanArtifactoryTest()
}

// Upload symlink to Artifactory using wildcard pattern and the link content checksum
// Download the symlink which was uploaded.
// validate the symlink content checksum.
func TestSymlinkWildcardPathHandling(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localFile := filepath.Join(tests.GetTestResourcesPath()+"a/", "a1.in")
	link := filepath.Join(tests.GetTestResourcesPath()+"a/", "link")
	err := os.Symlink(localFile, link)
	assert.NoError(t, err)
	link1 := filepath.Join(tests.GetTestResourcesPath()+"a/", "link*")
	runRt(t, "u", link1, tests.RtRepo1, "--symlinks=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link)
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/", "--validate-symlinks=true")
	validateSymLink(link, localFile, t)
	clientTestUtils.RemoveAndAssert(t, link)
	cleanArtifactoryTest()
}

func TestUploadWithArchiveAndSymlink(t *testing.T) {
	initArtifactoryTest(t, "")
	// Path to local file with a different name from symlinkTarget
	testFile := filepath.Join(tests.GetTestResourcesPath(), "a", "a1.in")
	tmpDir, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()
	err := biutils.CopyFile(tmpDir, testFile)
	assert.NoError(t, err)
	// Link valid symLink to local file
	symlinkTarget := filepath.Join(tmpDir, "a1.in")
	err = os.Symlink(symlinkTarget, filepath.Join(tmpDir, "symlink"))
	assert.NoError(t, err)
	// Upload symlink and local file to artifactory
	runRt(t, "u", tmpDir+"/*", tests.RtRepo1+"/test-archive.zip", "--archive=zip", "--symlinks=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tmpDir)
	assert.NoError(t, os.Mkdir(tmpDir, 0777))
	runRt(t, "download", tests.RtRepo1+"/test-archive.zip", tmpDir+"/", "--explode=true")
	// Validate
	assert.True(t, fileutils.IsPathExists(filepath.Join(tmpDir, "a1.in"), false), "Failed to download file from Artifactory")
	validateSymLink(filepath.Join(tmpDir, "symlink"), symlinkTarget, t)

	cleanArtifactoryTest()
}

func TestUploadWithArchiveAndSymlinkZipSlip(t *testing.T) {
	initArtifactoryTest(t, "")
	symlinkTarget := filepath.Join(tests.GetTestResourcesPath(), "a", "a2.in")
	tmpDir, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()
	// Link symLink to local file, outside the extraction directory
	err := os.Symlink(symlinkTarget, filepath.Join(tmpDir, "symlink"))
	assert.NoError(t, err)

	// Upload symlink and local file to artifactory
	runRt(t, "u", tmpDir+"/*", tests.RtRepo1+"/test-archive.zip", "--archive=zip", "--symlinks=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tmpDir)
	assert.NoError(t, os.Mkdir(tmpDir, 0777))

	// Discard output logging to prevent negative logs
	previousLogger := tests.RedirectLogOutputToNil()
	defer log.SetLogger(previousLogger)

	// Make sure download failed
	err = artifactoryCli.Exec("download", tests.RtRepo1+"/test-archive.zip", tmpDir+"/", "--explode=true")
	assert.Error(t, err)
	cleanArtifactoryTest()
}

// Upload symlink pointing to directory to Artifactory.
// Download the symlink which was uploaded.
func TestSymlinkToDirHandling(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localFile := filepath.Join(tests.GetTestResourcesPath(), "a")
	link := filepath.Join(tests.GetTestResourcesPath()+"a/", "link")
	err := os.Symlink(localFile, link)
	assert.NoError(t, err)
	runRt(t, "u", link, tests.RtRepo1, "--symlinks=true", "--recursive=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link)
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/")
	validateSymLink(link, localFile, t)
	clientTestUtils.RemoveAndAssert(t, link)
	cleanArtifactoryTest()
}

// Upload symlink pointing to directory using wildcard path to Artifactory.
// Download the symlink which was uploaded.
func TestSymlinkToDirWildcardHandling(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localFile := filepath.Join(tests.GetTestResourcesPath(), "a")
	link := filepath.Join(tests.GetTestResourcesPath()+"a/", "link")
	err := os.Symlink(localFile, link)
	assert.NoError(t, err)
	link1 := filepath.Join(tests.GetTestResourcesPath()+"a/", "lin*")
	runRt(t, "u", link1, tests.RtRepo1, "--symlinks=true", "--recursive=true", "--flat=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link)
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/")
	validateSymLink(link, localFile, t)
	clientTestUtils.RemoveAndAssert(t, link)
	cleanArtifactoryTest()
}

// Upload symlink pointing to directory using wildcard path to Artifactory.
// Download the symlink which was uploaded.
// The test create circular links and the test suppose to prune the circular searching.
func TestSymlinkInsideSymlinkDirWithRecursionIssueUpload(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localDirPath := filepath.Join(tests.GetTestResourcesPath(), "a")
	link1 := filepath.Join(tests.GetTestResourcesPath()+"a/", "link1")
	err := os.Symlink(localDirPath, link1)
	assert.NoError(t, err)
	localFilePath := filepath.Join(tests.GetTestResourcesPath()+"a/", "a1.in")
	link2 := filepath.Join(tests.GetTestResourcesPath()+"a/", "link2")
	err = os.Symlink(localFilePath, link2)
	assert.NoError(t, err)

	runRt(t, "u", localDirPath+"/link*", tests.RtRepo1, "--symlinks=true", "--recursive=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link1)

	clientTestUtils.RemoveAndAssert(t, link2)

	runRt(t, "dl", tests.RtRepo1+"/link*", tests.GetTestResourcesPath()+"a/")
	validateSymLink(link1, localDirPath, t)
	clientTestUtils.RemoveAndAssert(t, link1)
	validateSymLink(link2, localFilePath, t)
	clientTestUtils.RemoveAndAssert(t, link2)
	cleanArtifactoryTest()
}

func validateSymLink(localLinkPath, localFilePath string, t *testing.T) {
	// In macOS, localFilePath may lead to /var/folders/dn instead of /private/var/folders/dn.
	// EvalSymlinks on localFilePath will fix it a head of the comparison at the end of this function.
	localFilePath, err := filepath.EvalSymlinks(localFilePath)
	assert.NoError(t, err)

	exists := fileutils.IsPathSymlink(localLinkPath)
	assert.True(t, exists, "failed to download symlinks from artifactory")
	symlinks, err := filepath.EvalSymlinks(localLinkPath)
	assert.NoError(t, err, "can't eval symlinks")
	assert.Equal(t, localFilePath, symlinks, "Symlinks wasn't created as expected")
}

func TestArtifactoryDeleteNoSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	testArtifactorySimpleDelete(t, "")
}

func TestArtifactoryDeleteBySpec(t *testing.T) {
	initArtifactoryTest(t, "")
	deleteSpecPath, err := tests.CreateSpec(tests.DeleteSimpleSpec)
	assert.NoError(t, err)
	testArtifactorySimpleDelete(t, deleteSpecPath)
}

func testArtifactorySimpleDelete(t *testing.T, deleteSpecPath string) {
	preUploadBasicTestResources(t)

	// Verify exists before deleting
	searchSpec, err := tests.CreateSpec(tests.SearchRepo1TestResources)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetRepo1TestResourcesExpected(), searchSpec, serverDetails, t)

	if deleteSpecPath != "" {
		runRt(t, "delete", "--spec="+deleteSpecPath)
	} else {
		runRt(t, "delete", tests.RtRepo1+"/test_resources/b/*")
	}

	inttestutils.VerifyExistInArtifactory(tests.GetSimpleDelete(), searchSpec, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteFolderWithWildcard(t *testing.T) {
	initArtifactoryTest(t, "")
	preUploadBasicTestResources(t)

	// Verify exists before deleting
	searchSpec, err := tests.CreateSpec(tests.SearchRepo1TestResources)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetRepo1TestResourcesExpected(), searchSpec, serverDetails, t)

	runRt(t, "delete", tests.RtRepo1+"/test_resources/*/c")

	inttestutils.VerifyExistInArtifactory(tests.GetDeleteFolderWithWildcard(), searchSpec, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteFolderCompletelyNoSpec(t *testing.T) {
	testArtifactoryDeleteFoldersNoSpec(t, false)
}

func TestArtifactoryDeleteFolderContentNoSpec(t *testing.T) {
	testArtifactoryDeleteFoldersNoSpec(t, true)
}

func testArtifactoryDeleteFoldersNoSpec(t *testing.T, contentOnly bool) {
	initArtifactoryTest(t, "")
	preUploadBasicTestResources(t)

	// Verify exists before deleting
	searchSpec, err := tests.CreateSpec(tests.SearchRepo1TestResources)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetRepo1TestResourcesExpected(), searchSpec, serverDetails, t)

	// Delete folder
	deletePath := tests.RtRepo1 + "/test_resources"
	// End with separator if content only
	if contentOnly {
		deletePath += "/"
	}
	runRt(t, "delete", deletePath)

	client, err := httpclient.ClientBuilder().Build()
	assert.NoError(t, err)

	// Verify folder exists only if content only
	var expectedStatusCode int
	if contentOnly {
		expectedStatusCode = http.StatusOK
	} else {
		expectedStatusCode = http.StatusNotFound
	}
	resp, body, _, err := client.SendGet(serverDetails.ArtifactoryUrl+"api/storage/"+tests.RtRepo1+"/test_resources", true, artHttpDetails, "")
	assert.NoError(t, err)
	assert.Equal(t, expectedStatusCode, resp.StatusCode, "test_resources shouldn't be deleted: "+tests.RtRepo1+"/test_resources/ "+string(body))

	// Verify no content exists
	verifyDoesntExistInArtifactory(searchSpec, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteFoldersBySpecAllRepo(t *testing.T) {
	testArtifactoryDeleteFoldersBySpec(t, tests.DeleteSpec)
}

func TestArtifactoryDeleteFoldersBySpecWildcardInRepo(t *testing.T) {
	testArtifactoryDeleteFoldersBySpec(t, tests.DeleteSpecWildcardInRepo)
}

func testArtifactoryDeleteFoldersBySpec(t *testing.T, specPath string) {
	initArtifactoryTest(t, "")
	preUploadBasicTestResources(t)

	// Verify exists before deleting
	searchSpec, err := tests.CreateSpec(tests.SearchRepo1TestResources)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetRepo1TestResourcesExpected(), searchSpec, serverDetails, t)

	deleteSpecPath, err := tests.CreateSpec(specPath)
	assert.NoError(t, err)
	runRt(t, "delete", "--spec="+deleteSpecPath)

	completeSearchSpec, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	verifyDoesntExistInArtifactory(completeSearchSpec, t)
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteExcludeByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)

	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Delete by pattern
	runRt(t, "del", tests.RtRepo1+"/data/", "--exclusions=*/*b1.in;*/*b2.in;*/*b3.in;*/*c1.in")

	// Validate files are deleted
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildDeleteExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteExclusionsByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)

	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Delete by pattern
	runRt(t, "del", tests.RtRepo1+"/data/", "--exclusions=*/*b1.in;*/*b2.in;*/*b3.in;*/*c1.in")

	// Validate files are deleted
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildDeleteExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteExclusionsBySpec(t *testing.T) {
	initArtifactoryTest(t, "")
	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	specFile, err := tests.CreateSpec(tests.DelSpecExclusions)
	assert.NoError(t, err)

	// Delete by pattern
	runRt(t, "del", "--spec="+specFile)

	// Validate files are deleted
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildDeleteExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

// Deleting files when one file name is a prefix to another in the same dir
func TestArtifactoryDeletePrefixFiles(t *testing.T) {
	initArtifactoryTest(t, "")

	// Prepare search command
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadPrefixFiles)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	// Delete by pattern
	runRt(t, "delete", tests.RtRepo1+"/*")

	// Validate files are deleted
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	length, err := reader.Length()
	assert.NoError(t, err)
	assert.Equal(t, 0, length)
	readerCloseAndAssert(t, reader)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteByProps(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadWithPropsSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	// Set properties to the directories as well (and their content)
	runRt(t, "sp", tests.RtRepo1+"/a/b/", "D=5", "--include-dirs")
	runRt(t, "sp", tests.RtRepo1+"/a/b/c/", "D=2", "--include-dirs")

	//  Set the property D=5 to c1.in, which is a different value then its directory c/
	runRt(t, "sp", tests.RtRepo1+"/a/b/c/c1.in", "D=5")

	// Prepare search command
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())

	// Delete all artifacts with D=5 but without c=3
	runRt(t, "delete", tests.RtRepo1+"/*", "--props=D=5", "--exclude-props=c=3")

	// Search all artifacts in repo1
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchResultAfterDeleteByPropsStep1())
	readerCloseAndAssert(t, readerNoDate)

	// Delete all artifacts with c=3 but without a=1
	runRt(t, "delete", tests.RtRepo1+"/*", "--props=c=3", "--exclude-props=a=1")

	// Search all artifacts in repo1
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchResultAfterDeleteByPropsStep2())
	readerCloseAndAssert(t, readerNoDate)

	// Delete all artifacts with a=1 but without b=3&c=3
	runRt(t, "delete", tests.RtRepo1+"/*", "--props=a=1", "--exclude-props=b=3;c=3")

	// Search all artifacts in repo1
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchResultAfterDeleteByPropsStep3())
	readerCloseAndAssert(t, readerNoDate)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryMultipleFileSpecsUpload(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.UploadMultipleFileSpecs)
	assert.NoError(t, err)
	resultSpecFile, err := tests.CreateSpec(tests.SearchAllRepo1)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	inttestutils.VerifyExistInArtifactory(tests.GetMultipleFileSpecs(), resultSpecFile, serverDetails, t)
	verifyExistInArtifactoryByProps([]string{tests.RtRepo1 + "/multiple/properties/testdata/a/b/b2.in"}, tests.RtRepo1+"/*/properties/*.in", "searchMe=true", t)
	cleanArtifactoryTest()
}

func TestArtifactorySimplePlaceHolders(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.UploadSimplePlaceholders)
	assert.NoError(t, err)

	resultSpecFile, err := tests.CreateSpec(tests.SearchSimplePlaceholders)
	assert.NoError(t, err)

	runRt(t, "upload", "--spec="+specFile)

	inttestutils.VerifyExistInArtifactory(tests.GetSimplePlaceholders(), resultSpecFile, serverDetails, t)
	cleanArtifactoryTest()
}

func TestArtifactoryFolderUploadRecursiveNonFlat(t *testing.T) {
	initArtifactoryTest(t, "")
	dirInnerPath := fileutils.GetFileSeparator() + filepath.Join("inner", "folder")
	canonicalPath := tests.Out + dirInnerPath

	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/(*)", tests.RtRepo1+"/{1}/", "--include-dirs=true", "--recursive=true", "--flat=false")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.True(t, fileutils.IsPathExists(filepath.Join(tests.Out, "inner", "folder", "folder"), false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryFlatFolderUpload(t *testing.T) {
	initArtifactoryTest(t, "")
	dirInnerPath := fileutils.GetFileSeparator() + filepath.Join("inner", "folder")
	canonicalPath := tests.Out + dirInnerPath
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/(*)", tests.RtRepo1+"/{1}/", "--include-dirs=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	// Non-flat download
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.True(t, fileutils.IsPathExists(filepath.Join(canonicalPath, "folder"), false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

// Test the definition of bottom chain directories - Directories which do not include other directories that match the pattern
func TestArtifactoryIncludeDirFlatNonEmptyFolderUpload(t *testing.T) {
	initArtifactoryTest(t, "")
	// 'c' folder is defined as bottom chain directory therefore should be uploaded when using flat=true even though 'c' is not empty
	runRt(t, "upload", tests.GetTestResourcesPath()+"a/b/*", tests.RtRepo1, "--include-dirs=true", "--flat=true")
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.True(t, fileutils.IsPathExists(tests.Out+"/c", false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

// Test the definition of bottom chain directories - Directories which do not include other directories that match the pattern
func TestArtifactoryDownloadNotIncludeDirs(t *testing.T) {
	initArtifactoryTest(t, "")
	// 'c' folder is defined as bottom chain directory therefore should be uploaded when using flat=true even though 'c' is not empty
	runRt(t, "upload", tests.GetTestResourcesPath()+"*/c", tests.RtRepo1, "--include-dirs=true", "--flat=true")
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--recursive=true")
	assert.False(t, fileutils.IsPathExists(tests.Out+"/c", false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

// Test the definition of bottom chain directories - Directories which do not include other directories that match the pattern
func TestArtifactoryDownloadFlatTrue(t *testing.T) {
	initArtifactoryTest(t, "")
	canonicalPath := tests.GetTestResourcesPath() + path.Join("an", "empty", "folder")
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)

	// 'c' folder is defined as bottom chain directory therefore should be uploaded when using flat=true even though 'c' is not empty
	runRt(t, "upload", tests.GetTestResourcesPath()+"(a*)/*", tests.RtRepo1+"/{1}/", "--include-dirs=true", "--flat=true")
	// Download without include-dirs
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--recursive=true", "--flat=true")
	assert.False(t, fileutils.IsPathExists(tests.Out+"/c", false), "'c' folder shouldn't exist.")

	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true", "--flat=true")
	// Inner folder with files in it
	assert.True(t, fileutils.IsPathExists(tests.Out+"/c", false), "'c' folder should exist.")
	// Empty inner folder
	assert.True(t, fileutils.IsPathExists(tests.Out+"/folder", false), "'folder' folder should exist.")
	// Folder on root with files
	assert.True(t, fileutils.IsPathExists(tests.Out+"/a$+~&^a#", false), "'a$+~&^a#' folder should exist.")
	// None bottom directory - shouldn't exist.
	assert.False(t, fileutils.IsPathExists(tests.Out+"/a", false), "'a' folder shouldn't exist.")
	// None bottom directory - shouldn't exist.
	assert.False(t, fileutils.IsPathExists(tests.Out+"/b", false), "'b' folder shouldn't exist.")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryIncludeDirFlatNonEmptyFolderUploadMatchingPattern(t *testing.T) {
	initArtifactoryTest(t, "")
	// 'c' folder is defined as bottom chain directory therefore should be uploaded when using flat=true even though 'c' is not empty
	runRt(t, "upload", tests.GetTestResourcesPath()+"*/c", tests.RtRepo1, "--include-dirs=true", "--flat=true")
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.True(t, fileutils.IsPathExists(tests.Out+"/c", false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryUploadWithIncludeDirsAndDryRun(t *testing.T) {
	initArtifactoryTest(t, "")

	// Use a unique subdirectory in the repo to avoid conflicts
	uploadPath := "dry-run-test"

	// Create test directory structure with files and empty directories
	dirInnerPath := filepath.Join("inner", "folder")
	canonicalPath := tests.Out + fileutils.GetFileSeparator() + dirInnerPath
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)

	// Create a test file in the nested directory
	testFile := filepath.Join(canonicalPath, "test.txt")
	err = os.WriteFile(testFile, []byte("test content"), 0644)
	assert.NoError(t, err)

	// Create an empty directory
	emptyDirPath := tests.Out + fileutils.GetFileSeparator() + "empty"
	err = os.MkdirAll(emptyDirPath, 0777)
	assert.NoError(t, err)

	// Upload with include-dirs and dry-run - files should not be uploaded
	runRt(t, "upload", tests.Out+"/", tests.RtRepo1+"/"+uploadPath+"/", "--recursive=true", "--include-dirs=true", "--flat=false", "--dry-run")

	// Search for files specifically (not directories) - dry-run should prevent file uploads
	searchSpecBuilder := spec.NewBuilder().
		Pattern(tests.RtRepo1 + "/" + uploadPath + "/*").
		Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)

	var fileItems []utils.SearchResult
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		// Only count files, not directories (directories have type "folder" and size 0)
		if resultItem.Type != "folder" {
			fileItems = append(fileItems, *resultItem)
		}
	}
	readerGetErrorAndAssert(t, reader)
	readerCloseAndAssert(t, reader)

	// Verify no files were uploaded with dry-run (directories might still be created)
	assert.Empty(t, fileItems, "Files should not be uploaded with dry-run flag")

	// Now upload without dry-run - should upload files and directories
	runRt(t, "upload", tests.Out+"/", tests.RtRepo1+"/"+uploadPath+"/", "--recursive=true", "--include-dirs=true", "--flat=false")

	// Verify files were uploaded
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	fileItems = []utils.SearchResult{}
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		if resultItem.Type != "folder" {
			fileItems = append(fileItems, *resultItem)
		}
	}
	readerGetErrorAndAssert(t, reader)
	readerCloseAndAssert(t, reader)

	assert.NotEmpty(t, fileItems, "Files should be uploaded without dry-run")
	assert.GreaterOrEqual(t, len(fileItems), 1, "At least one file should be uploaded")

	// Verify we can download the uploaded structure
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "download", tests.RtRepo1+"/"+uploadPath+"/", tests.Out+"/", "--include-dirs=true", "--recursive=true")

	// Verify the directory structure was downloaded
	// The upload path preserves the "out/" directory, so files are at dry-run-test/out/...
	expectedFilePath := filepath.Join(tests.Out, uploadPath, "out", "inner", "folder", "test.txt")
	assert.True(t, fileutils.IsPathExists(expectedFilePath, false),
		"File should exist after download at: %s", expectedFilePath)
	expectedEmptyDirPath := filepath.Join(tests.Out, uploadPath, "out", "empty")
	assert.True(t, fileutils.IsPathExists(expectedEmptyDirPath, false),
		"Empty directory should exist after download at: %s", expectedEmptyDirPath)

	cleanArtifactoryTest()
}

func TestArtifactoryDirectDownload(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1)
	runRt(t, "ddl", tests.RtRepo1+"/testdata/a/a1.in", tests.Out+"/")

	assert.True(t, fileutils.IsPathExists(filepath.Join(tests.Out, "testdata", "a", "a1.in"), false))

	cleanArtifactoryTest()
}

func TestArtifactoryDirectDownloadFlat(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/a/a2.in", tests.RtRepo1+"/path/to/", "--flat=true")

	runRt(t, "ddl", tests.RtRepo1+"/path/to/a2.in", tests.Out+"/", "--flat=true")

	assert.True(t, fileutils.IsPathExists(filepath.Join(tests.Out, "a2.in"), false))
	assert.False(t, fileutils.IsPathExists(filepath.Join(tests.Out, "path", "to", "a2.in"), false))

	cleanArtifactoryTest()
}

func TestArtifactoryDirectDownloadChecksumValidation(t *testing.T) {
	initArtifactoryTest(t, "")

	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1, "--flat=true")
	runRt(t, "ddl", tests.RtRepo1+"/a1.in", tests.Out+"/")

	assert.True(t, fileutils.IsPathExists(filepath.Join(tests.Out, "a1.in"), false))

	runRt(t, "ddl", tests.RtRepo1+"/a1.in", tests.Out+"/skip/", "--skip-checksum")
	assert.True(t, fileutils.IsPathExists(filepath.Join(tests.Out, "skip", "a1.in"), false))

	cleanArtifactoryTest()
}

// Test the definition of bottom chain directories - Directories which do not include other directories that match the pattern
func TestArtifactoryUploadFlatFolderWithFileAndInnerEmptyMatchingPattern(t *testing.T) {
	initArtifactoryTest(t, "")
	newFolderPath := tests.GetTestResourcesPath() + "a/b/c/d"
	err := os.MkdirAll(newFolderPath, 0777)
	assert.NoError(t, err)
	// We created an empty child folder to 'c' therefore 'c' is not longer a bottom chain and new 'd' inner directory is indeed bottom chain directory.
	// 'd' should be uploaded and 'c' shouldn't
	runRt(t, "upload", tests.GetTestResourcesPath()+"a/b/*", tests.RtRepo1, "--include-dirs=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, newFolderPath)
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.False(t, fileutils.IsPathExists(tests.Out+"/c", false), "'c' folder shouldn't exist")
	assert.True(t, fileutils.IsPathExists(tests.Out+"/d", false), "bottom chain directory, 'd', is missing")
	// Cleanup
	cleanArtifactoryTest()
}

// Test the definition of bottom chain directories - Directories which do not include other directories that match the pattern
func TestArtifactoryUploadFlatFolderWithFileAndInnerEmptyMatchingPatternWithPlaceHolders(t *testing.T) {
	initArtifactoryTest(t, "")
	relativePath := "/b/c/d"
	fullPath := tests.GetTestResourcesPath() + "a/" + relativePath
	err := os.MkdirAll(fullPath, 0777)
	assert.NoError(t, err)
	// We created an empty child folder to 'c' therefore 'c' is not longer a bottom chain and new 'd' inner directory is indeed bottom chain directory.
	// 'd' should be uploaded and 'c' shouldn't
	runRt(t, "upload", tests.GetTestResourcesPath()+"a/(*)/*", tests.RtRepo1+"/{1}/", "--include-dirs=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, fullPath)
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--recursive=true")
	assert.True(t, fileutils.IsPathExists(tests.Out+relativePath, false), "bottom chain directory, 'd', is missing")

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryFlatFolderDownload1(t *testing.T) {
	initArtifactoryTest(t, "")
	dirInnerPath := fileutils.GetFileSeparator() + filepath.Join("inner", "folder")
	canonicalPath := tests.Out + dirInnerPath
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)
	// Flat true by default for upload, by using placeholder we indeed create folders hierarchy in Artifactory inner/folder/folder
	runRt(t, "upload", tests.Out+"/(*)", tests.RtRepo1+"/{1}/", "--include-dirs=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	// Only the inner folder should be downland e.g 'folder'
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true", "--flat=true")
	assert.False(t, !fileutils.IsPathExists(filepath.Join(tests.Out, "folder"), false) &&
		fileutils.IsPathExists(filepath.Join(tests.Out, "inner"), false),
		"Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryFolderUploadRecursiveUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	assert.NoError(t, createEmptyTestDir())
	specFile, err := tests.CreateSpec(tests.UploadEmptyDirs)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile)

	specFile, err = tests.CreateSpec(tests.DownloadEmptyDirs)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+specFile)
	assert.True(t, fileutils.IsPathExists(tests.Out+"/folder", false), "Failed to download folders from Artifactory")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryFolderUploadNonRecursive(t *testing.T) {
	initArtifactoryTest(t, "")
	canonicalPath := filepath.Join(tests.Out, "inner", "folder")
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/", tests.RtRepo1, "--recursive=true", "--include-dirs=true", "--flat=true")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "download", tests.RtRepo1, tests.Out+"/", "--include-dirs=true")
	assert.True(t, fileutils.IsPathExists(tests.Out+"/folder", false), "Failed to download folder from Artifactory")
	assert.False(t, fileutils.IsPathExists(canonicalPath, false), "Path should be flat ")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryFolderDownloadNonRecursive(t *testing.T) {
	initArtifactoryTest(t, "")
	canonicalPath := filepath.Join(tests.Out, "inner", "folder")
	err := os.MkdirAll(canonicalPath, 0777)
	assert.NoError(t, err)
	runRt(t, "upload", tests.Out+"/", tests.RtRepo1, "--recursive=true", "--include-dirs=true", "--flat=false")
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	runRt(t, "download", tests.RtRepo1+"/*", "--recursive=false", "--include-dirs=true")
	assert.True(t, fileutils.IsPathExists(tests.Out, false), "Failed to download folder from Artifactory")
	assert.False(t, fileutils.IsPathExists(canonicalPath, false), "Path should be flat. ")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryChecksumDownload(t *testing.T) {
	initArtifactoryTest(t, "")

	var filePath = "testdata/a/a1.in"
	runRt(t, "upload", filePath, tests.RtRepo1, "--flat=true")
	testChecksumDownload(t, "/a1.in")
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryChecksumDownloadRenameFileName(t *testing.T) {
	initArtifactoryTest(t, "")

	var filePath = "testdata/a/a1.in"
	runRt(t, "upload", filePath, tests.RtRepo1, "--flat=true")
	testChecksumDownload(t, "/a1.out")
	// Cleanup
	cleanArtifactoryTest()
}

func testChecksumDownload(t *testing.T, outFileName string) {
	runRt(t, "download", tests.RtRepo1+"/a1.in", tests.Out+outFileName)

	exists, err := fileutils.IsFileExists(tests.Out+outFileName, false)
	assert.NoError(t, err)
	assert.True(t, exists, "Failed to download file from Artifactory")

	firstFileInfo, _ := os.Stat(tests.Out + outFileName)
	firstDownloadTime := firstFileInfo.ModTime()

	runRt(t, "download", tests.RtRepo1+"/a1.in", tests.Out+outFileName)
	secondFileInfo, _ := os.Stat(tests.Out + outFileName)
	secondDownloadTime := secondFileInfo.ModTime()

	assert.Equal(t, firstDownloadTime, secondDownloadTime, "Checksum download failed, the file was downloaded twice")
}

func TestArtifactoryDownloadByPatternAndBuildUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpec)
	assert.NoError(t, err)
	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Download by build number
	runRt(t, "download", "--spec="+specFile)

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryGenericBuildNameAndNumberFromEnv(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpec)
	assert.NoError(t, err)
	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildName, tests.RtBuildName1)
	defer setEnvCallBack()
	setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildNumber, buildNumberA)
	defer setEnvCallBack()
	runRt(t, "upload", "--spec="+specFileA)
	clientTestUtils.SetEnvAndAssert(t, coreutils.BuildNumber, "11")
	runRt(t, "upload", "--spec="+specFileB)

	// Publish buildInfo
	clientTestUtils.SetEnvAndAssert(t, coreutils.BuildNumber, buildNumberA)
	runRt(t, "build-publish")
	clientTestUtils.SetEnvAndAssert(t, coreutils.BuildNumber, buildNumberB)
	runRt(t, "build-publish")

	// Download by build number
	runRt(t, "download", "--spec="+specFile)

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadByBuildNoPatternUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecNoPattern)
	assert.NoError(t, err)
	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Download by build number
	runRt(t, "download", "--spec="+specFile)

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func prepareDownloadByBuildWithDependenciesTests(t *testing.T) {
	// Init
	initArtifactoryTest(t, "")
	buildNumber := "1337"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)

	// Add build artifacts.
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	runRt(t, "upload", "--spec="+specFileB)

	// Add build dependencies.
	artifactoryCliNoCreds := coretests.NewJfrogCli(execMain, "jfrog rt", "")
	assert.NoError(t, artifactoryCliNoCreds.Exec("bad", "--spec="+specFileB, tests.RtBuildName1, buildNumber))

	// Publish build.
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)
}

func TestArtifactoryDownloadByBuildWithDependenciesSpecNoPattern(t *testing.T) {
	prepareDownloadByBuildWithDependenciesTests(t)

	// Download with exclude-artifacts.
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecExcludeArtifacts)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+specFile)
	// Validate.
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownloadDoesntExist(), paths)
	assert.NoError(t, err)

	// Download deps-only.
	specFile, err = tests.CreateSpec(tests.BuildDownloadSpecDepsOnly)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+specFile)
	// Validate.
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetDownloadByBuildOnlyDeps(), paths)
	assert.NoError(t, err)

	// Download artifacts and deps.
	specFile, err = tests.CreateSpec(tests.BuildDownloadSpecIncludeDeps)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+specFile)
	// Validate.
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+string(os.PathSeparator)+"download"+string(os.PathSeparator)+"download_build_with_dependencies", false)
	err = tests.ValidateListsIdentical(tests.GetDownloadByBuildIncludeDeps(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadByBuildWithDependencies(t *testing.T) {
	prepareDownloadByBuildWithDependenciesTests(t)

	// Download with exclude-artifacts.
	runRt(t, "download", tests.RtRepo1, "out/download/download_build_with_dependencies/", "--build="+tests.RtBuildName1, "--exclude-artifacts=true", "--flat=true")
	// Validate.
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err := tests.ValidateListsIdentical(tests.GetBuildDownloadDoesntExist(), paths)
	assert.NoError(t, err)

	// Download deps-only.
	runRt(t, "download", tests.RtRepo1, "out/download/download_build_only_dependencies/", "--build="+tests.RtBuildName1, "--exclude-artifacts=true", "--include-deps=true", "--flat=true")
	// Validate.
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetDownloadByBuildOnlyDeps(), paths)
	assert.NoError(t, err)

	// Download artifacts and deps.
	runRt(t, "download", tests.RtRepo1, "out/download/download_build_with_dependencies/", "--build="+tests.RtBuildName1, "--include-deps=true", "--flat=true")
	// Validate.
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+string(os.PathSeparator)+"download"+string(os.PathSeparator)+"download_build_with_dependencies", false)
	err = tests.ValidateListsIdentical(tests.GetDownloadByBuildIncludeDeps(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

// Upload a file to build A.
// Verify that it doesn't exist in B.
func TestArtifactoryDownloadArtifactDoesntExistInBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumber := "10"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecNoBuildNumber)
	assert.NoError(t, err)
	// Upload a file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a10.in", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)

	// Download from different build number
	runRt(t, "download", "--spec="+specFile)

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownloadDoesntExist(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

// Upload a file to 2 different builds.
// Verify that we don't download files with same sha and different build name and build number.
func TestArtifactoryDownloadByShaAndBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB, buildNumberC := "10", "11", "12"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecNoBuildNumber)
	assert.NoError(t, err)

	// Upload 3 similar files to 3 different builds
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a10.in", "--build-name="+tests.RtBuildName2, "--build-number="+buildNumberA)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a11.in", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a12.in", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberC)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName2, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberC)

	// Download by build number
	runRt(t, "download", "--spec="+specFile)

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownloadByShaAndBuild(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	cleanArtifactoryTest()
}

// Upload a file to 2 different builds.
// Verify that we don't download files with same sha and build name and different build number.
func TestArtifactoryDownloadByShaAndBuildName(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB, buildNumberC := "10", "11", "12"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecNoBuildNumber)
	assert.NoError(t, err)

	// Upload 3 similar files to 2 different builds
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a10.in", "--build-name="+tests.RtBuildName2, "--build-number="+buildNumberA)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a11.in", "--build-name="+tests.RtBuildName2, "--build-number="+buildNumberB)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a12.in", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberC)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberC)
	runRt(t, "build-publish", tests.RtBuildName2, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName2, buildNumberB)

	// Download by build number
	runRt(t, "download", "--spec="+specFile)

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownloadByShaAndBuildName(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadByBuildUsingSimpleDownload(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "b", "a"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Download by build number, a1 should not be downloaded, b1 should
	runRt(t, "download", tests.RtRepo1+"/data/a1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(), "--build="+tests.RtBuildName1)
	runRt(t, "download", tests.RtRepo1+"/data/b1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(), "--build="+tests.RtBuildName1)

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildSimpleDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadByBuildUsingSimpleDownloadWithProject(t *testing.T) {
	initArtifactoryTest(t, "")
	accessManager, err := utils.CreateAccessServiceManager(serverDetails, false)
	assert.NoError(t, err)
	// Delete the project if already exists
	deleteProjectIfExists(t, accessManager, tests.ProjectKey)

	// Create new project
	projectParams := accessServices.ProjectParams{
		ProjectDetails: accessServices.Project{
			DisplayName: "testProject " + tests.ProjectKey,
			ProjectKey:  tests.ProjectKey,
		},
	}
	err = accessManager.CreateProject(projectParams)
	assert.NoError(t, err)
	// Assign the repository to the project
	err = accessManager.AssignRepoToProject(tests.RtRepo1, tests.ProjectKey, true)
	assert.NoError(t, err)

	// Delete the build if exists
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	buildNumberA := "123"

	// Upload files with buildName, buildNumber and project flags
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA, "--project="+tests.ProjectKey)

	// Publish buildInfo with project flag
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA, "--project="+tests.ProjectKey)

	// Download by project, b1 should be downloaded
	runRt(t, "download", tests.RtRepo1+"/data/b1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(),
		"--build="+tests.RtBuildName1, "--project="+tests.ProjectKey)

	// Validate files are downloaded by build number
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	err = tests.ValidateListsIdentical(tests.GetBuildSimpleDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	err = accessManager.UnassignRepoFromProject(tests.RtRepo1)
	assert.NoError(t, err)
	err = accessManager.DeleteProject(tests.ProjectKey)
	assert.NoError(t, err)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadWithEnvProject(t *testing.T) {
	initArtifactoryTest(t, "")
	accessManager, err := utils.CreateAccessServiceManager(serverDetails, false)
	assert.NoError(t, err)
	// Delete the project if already exists
	deleteProjectIfExists(t, accessManager, tests.ProjectKey)

	// Create new project
	projectParams := accessServices.ProjectParams{
		ProjectDetails: accessServices.Project{
			DisplayName: "testProject " + tests.ProjectKey,
			ProjectKey:  tests.ProjectKey,
		},
	}
	err = accessManager.CreateProject(projectParams)
	assert.NoError(t, err)
	// Assign the repository to the project
	err = accessManager.AssignRepoToProject(tests.RtRepo1, tests.ProjectKey, true)
	assert.NoError(t, err)

	// Delete the build if exists
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	buildNumberA := "123"
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildName, tests.RtBuildName1)
	defer setEnvCallBack()
	setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildNumber, buildNumberA)
	defer setEnvCallBack()
	setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.Project, tests.ProjectKey)
	defer setEnvCallBack()
	// Upload files with buildName, buildNumber and project flags
	runRt(t, "upload", "--spec="+specFileB)

	// Publish buildInfo with project flag
	runRt(t, "build-publish")

	// Download by project, b1 should be downloaded
	runRt(t, "download", tests.RtRepo1+"/data/b1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(),
		"--build="+tests.RtBuildName1, "--project="+tests.ProjectKey)

	// Validate files are downloaded by build number
	paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NoError(t, err)
	err = tests.ValidateListsIdentical(tests.GetBuildSimpleDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	err = accessManager.UnassignRepoFromProject(tests.RtRepo1)
	assert.NoError(t, err)
	err = accessManager.DeleteProject(tests.ProjectKey)
	assert.NoError(t, err)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadByBuildNoPatternUsingSimpleDownload(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "b", "a"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)

	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Download by build number, a1 should not be downloaded, b1 should
	runRt(t, "download", "*", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(), "--build="+tests.RtBuildName1+"/"+buildNumberA)

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildSimpleDownloadNoPattern(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadExcludeByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--recursive=true")
	runRt(t, "upload", "--spec="+specFileB, "--recursive=true")

	// Download by pattern
	runRt(t, "download", tests.RtRepo1, "out/download/aql_by_artifacts/", "--exclusions=*/*/a1.in;*/*a2.*;*/data/c2.in")

	// Validate files are excluded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildExcludeDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadExclusionsByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--recursive=true")
	runRt(t, "upload", "--spec="+specFileB, "--recursive=true")

	// Download by pattern
	runRt(t, "download", tests.RtRepo1, "out/download/aql_by_artifacts/", "--exclusions=*/*/a1.in;*/*a2.*;*/data/c2.in")

	// Validate files are excluded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildExcludeDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadExclusionsBySpec(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.DownloadSpecExclusions)
	assert.NoError(t, err)

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--recursive=true", "--flat=false")
	runRt(t, "upload", "--spec="+specFileB, "--recursive=true", "--flat=false")

	// Download by spec
	runRt(t, "download", "--spec="+specFile)

	// Validate files are excluded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildExcludeDownloadBySpec(), paths)
	assert.NoError(t, err)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDownloadExclusionsBySpecOverride(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--recursive=true", "--flat=false")
	runRt(t, "upload", "--spec="+specFileB, "--recursive=true", "--flat=false")

	// Download by spec
	specFile, err := tests.CreateSpec(tests.DownloadSpecExclusions)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+specFile, "--exclusions=*a1.in;*a2.in;*c2.in")

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetBuildExcludeDownload(), paths)
	assert.NoError(t, err)

	// Cleanup
	cleanArtifactoryTest()
}

func TestDirectDownloadBasic(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-basic/")

	// Download using ddl command
	runRt(t, "ddl", tests.RtRepo1+"/ddl-basic/*.in", tests.Out+"/")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded")

	cleanArtifactoryTest()
}

func TestDirectDownloadFromVirtual(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files to physical repo
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-virtual/")

	// Download from virtual repo using ddl
	runRt(t, "ddl", tests.RtVirtualRepo+"/ddl-virtual/*.in", tests.Out+"/", "--flat=true")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded from virtual repository")

	// Check that at least some .in files were downloaded
	hasInFiles := false
	for _, path := range paths {
		if strings.HasSuffix(path, ".in") {
			hasInFiles = true
			break
		}
	}
	assert.True(t, hasInFiles, "Expected .in files to be downloaded")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithFlat(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-flat/")

	// Download with flat=true
	runRt(t, "ddl", tests.RtRepo1+"/ddl-flat/*.in", tests.Out+"/", "--flat=true")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with flat structure")

	cleanArtifactoryTest()
}

func TestDirectDownloadRecursive(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files in nested directories
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-recursive/level1/level2/")

	// Download with recursive=true (use directory pattern)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-recursive/*", tests.Out+"/", "--recursive=true")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded recursively")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithExclusions(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/ddl-exclusions/")
	runRt(t, "upload", "testdata/a/b*.in", tests.RtRepo1+"/ddl-exclusions/")

	// Download with exclusions
	runRt(t, "ddl", tests.RtRepo1+"/ddl-exclusions/*.in", tests.Out+"/", "--exclusions=*a1.in")

	// Verify a1.in was excluded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	for _, path := range paths {
		assert.NotContains(t, filepath.Base(path), "a1.in", "a1.in should be excluded")
	}

	cleanArtifactoryTest()
}

func TestDirectDownloadWithMinSplit(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create and upload a file larger than min-split size
	tempDir := filepath.Join(os.TempDir(), "temp-ddl-test-"+strconv.FormatInt(time.Now().Unix(), 10))
	assert.NoError(t, fileutils.CreateDirIfNotExist(tempDir))
	defer func() {
		if err := os.RemoveAll(tempDir); err != nil {
			t.Logf("Failed to remove temp dir: %v", err)
		}
	}()

	testFile := filepath.Join(tempDir, "largefile.bin")
	_, err := gofrogio.CreateRandFile(testFile, 100000) // 100KB file
	assert.NoError(t, err)

	// Upload with flat to ensure file is at expected path
	runRt(t, "upload", testFile, tests.RtRepo1+"/ddl-split/", "--flat=true")

	// Clean local file
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))

	// Download with min-split (should trigger concurrent download)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-split/largefile.bin", tests.Out+"/", "--min-split=50", "--split-count=3")

	// Verify file was downloaded (DDL preserves directory structure)
	downloadedFile := filepath.Join(tests.Out, "ddl-split", "largefile.bin")
	assert.True(t, fileutils.IsPathExists(downloadedFile, false), "Expected largefile.bin to be downloaded")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithThreads(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload multiple files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-threads/")

	// Download with multiple threads
	runRt(t, "ddl", tests.RtRepo1+"/ddl-threads/*.in", tests.Out+"/", "--threads=5")

	// Verify all files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with threading")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithDryRun(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-dryrun/")

	// Use a separate output directory for dry-run test
	dryRunOut := tests.Out + "/dry-run-test"

	// Download with dry-run
	runRt(t, "ddl", tests.RtRepo1+"/ddl-dryrun/*.in", dryRunOut+"/", "--dry-run")

	exists, err := fileutils.IsDirExists(dryRunOut, false)
	assert.NoError(t, err)
	assert.False(t, exists, "DDL with dry-run should not create output directory")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithSkipChecksum(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-checksum/")

	// Download with skip-checksum
	runRt(t, "ddl", tests.RtRepo1+"/ddl-checksum/*.in", tests.Out+"/", "--skip-checksum")

	// Verify files were downloaded (even though checksum verification was skipped)
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with skip-checksum")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithExplode(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create a zip file
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	// Create files to zip
	testDir := filepath.Join(tests.Out, "tozip")
	assert.NoError(t, fileutils.CreateDirIfNotExist(testDir))
	testFile1 := filepath.Join(testDir, "file1.txt")
	testFile2 := filepath.Join(testDir, "file2.txt")
	assert.NoError(t, os.WriteFile(testFile1, []byte("content1"), 0644))
	assert.NoError(t, os.WriteFile(testFile2, []byte("content2"), 0644))

	// Create zip
	zipPath := filepath.Join(tests.Out, "test.zip")
	err = archiver.Archive([]string{testDir}, zipPath)
	assert.NoError(t, err)

	// Upload zip
	runRt(t, "upload", zipPath, tests.RtRepo1+"/ddl-explode/", "--flat=true")

	// Clean local files
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))

	// Download with explode
	runRt(t, "ddl", tests.RtRepo1+"/ddl-explode/test.zip", tests.Out+"/", "--explode")

	// Verify files were extracted, not the zip itself
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	hasTextFiles := false
	for _, path := range paths {
		if strings.HasSuffix(path, ".txt") {
			hasTextFiles = true
			break
		}
	}
	assert.True(t, hasTextFiles, "Expected extracted .txt files from exploded archive")

	cleanArtifactoryTest()
}

func TestDirectDownloadByBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumber := "ddl-build-1"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)

	// Upload files and collect build info
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-build/", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumber)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumber)

	// Download by build using ddl
	runRt(t, "ddl", tests.RtRepo1+"/ddl-build/*.in", tests.Out+"/", "--build="+tests.RtBuildName1+"/"+buildNumber)

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded by build")

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestDirectDownloadComparison(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-compare/")

	// Download with regular dl
	runRt(t, "dl", tests.RtRepo1+"/ddl-compare/*.in", tests.Out+"/dl/")
	dlPaths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/dl", false)

	// Download with ddl
	runRt(t, "ddl", tests.RtRepo1+"/ddl-compare/*.in", tests.Out+"/ddl/")
	ddlPaths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/ddl", false)

	// Both should download the same number of files
	assert.Equal(t, len(dlPaths), len(ddlPaths), "dl and ddl should download the same number of files")

	// Both should have downloaded files
	assert.NotEmpty(t, dlPaths, "dl should download files")
	assert.NotEmpty(t, ddlPaths, "ddl should download files")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithCustomThreads(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload multiple files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-threads-custom/")

	// Download with custom thread count
	runRt(t, "ddl", tests.RtRepo1+"/ddl-threads-custom/*.in", tests.Out+"/", "--threads=5")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with custom thread count")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithRetries(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-retries/")

	// Download with custom retry settings
	runRt(t, "ddl", tests.RtRepo1+"/ddl-retries/*.in", tests.Out+"/", "--retries=5", "--retry-wait-time=2s")

	// Verify file was downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected file to be downloaded with custom retry settings")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithFailNoOp(t *testing.T) {
	initArtifactoryTest(t, "")

	// Try to download non-existent files with fail-no-op
	err := artifactoryCli.Exec([]string{"ddl", tests.RtRepo1 + "/non-existent-pattern-*.txt", tests.Out + "/", "--fail-no-op=true", "--server-id=" + tests.ServerId}...)
	assert.Error(t, err, "Expected error when no files match with fail-no-op")

	// Try without fail-no-op (should succeed with 0 downloads)
	runRt(t, "ddl", tests.RtRepo1+"/non-existent-pattern-*.txt", tests.Out+"/")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithDetailedSummary(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-summary/")

	// Download with detailed summary
	runRt(t, "ddl", tests.RtRepo1+"/ddl-summary/*.in", tests.Out+"/", "--detailed-summary=true")

	// Verify files were downloaded (detailed summary is shown in console output)
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with detailed summary")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithValidateSymlinks(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-symlinks/")

	// Download with validate-symlinks
	runRt(t, "ddl", tests.RtRepo1+"/ddl-symlinks/*.in", tests.Out+"/", "--validate-symlinks=true")

	// Verify file was downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected file to be downloaded with symlink validation")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithInsecureTls(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-tls/")

	// Download with insecure-tls
	runRt(t, "ddl", tests.RtRepo1+"/ddl-tls/*.in", tests.Out+"/", "--insecure-tls=true")

	// Verify file was downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected file to be downloaded with insecure TLS")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithProject(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-project/")

	// Download with project flag (may not affect download if project doesn't exist)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-project/*.in", tests.Out+"/", "--project=test-project")

	// Verify file was downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected file to be downloaded with project flag")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithBundle(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file first
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-bundle/")

	// Try to download with bundle flag (will likely fail if bundle doesn't exist)
	// Using correct format: bundle-name/bundle-version
	// This test verifies the bundle flag is parsed correctly (no panic)
	_ = artifactoryCli.Exec([]string{"ddl", "non-existent-bundle/*", tests.Out + "/", "--bundle=test-bundle/1.0.0", "--server-id=" + tests.ServerId}...)
	// We expect this to fail or return 0 files since the bundle doesn't exist

	// For comparison, regular download should work
	runRt(t, "ddl", tests.RtRepo1+"/ddl-bundle/*.in", tests.Out+"/regular/")
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/regular", false)
	assert.NotEmpty(t, paths, "Expected regular download to work")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithAuthentication(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test file
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/ddl-auth/")

	// Test with URL and credentials (using server-id overrides these)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-auth/*.in", tests.Out+"/", "--server-id="+tests.ServerId)

	// Verify file was downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected file to be downloaded with authentication")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithBuildNameNumber(t *testing.T) {
	initArtifactoryTest(t, "")
	buildName := "ddl-build-test"
	buildNumber := "42"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)

	// Upload with build info
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-buildinfo/",
		"--build-name="+buildName, "--build-number="+buildNumber)
	runRt(t, "build-publish", buildName, buildNumber)

	// Download using separate build-name and build-number flags
	runRt(t, "ddl", tests.RtRepo1+"/ddl-buildinfo/*.in", tests.Out+"/",
		"--build-name="+buildName, "--build-number="+buildNumber)

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded by build name and number")

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	cleanArtifactoryTest()
}

func TestDirectDownloadWithSyncDeletes(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create a local file that should be deleted during sync
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
	localFile := filepath.Join(tests.Out, "delete-me.txt")
	err := os.WriteFile(localFile, []byte("delete me"), 0644)
	assert.NoError(t, err)

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-sync/")

	// Download with sync-deletes (add server-id for ddl)
	outDirPath := filepath.Clean(tests.Out) + string(os.PathSeparator)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-sync/*.in", outDirPath, "--sync-deletes="+outDirPath, "--server-id="+tests.ServerId)

	// Verify the local file was deleted
	assert.False(t, fileutils.IsPathExists(localFile, false), "Local file should be deleted with sync-deletes")

	// Verify downloaded files exist
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithBypassArchiveInspection(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create a zip file
	err := fileutils.CreateDirIfNotExist(tests.Out)
	assert.NoError(t, err)

	// Create files to zip in temp directory to avoid path issues
	testDir := filepath.Join(os.TempDir(), "tozip-"+strconv.FormatInt(time.Now().Unix(), 10))
	assert.NoError(t, fileutils.CreateDirIfNotExist(testDir))
	defer func() {
		if err := os.RemoveAll(testDir); err != nil {
			t.Logf("Failed to remove test dir: %v", err)
		}
	}()
	testFile := filepath.Join(testDir, "test.txt")
	assert.NoError(t, os.WriteFile(testFile, []byte("test content"), 0644))

	// Create zip
	zipPath := filepath.Join(tests.Out, "test.zip")
	err = archiver.Archive([]string{testFile}, zipPath)
	assert.NoError(t, err)

	// Upload the zip file
	runRt(t, "upload", zipPath, tests.RtRepo1+"/ddl-bypass/", "--flat=true")

	// Download with bypass-archive-inspection
	runRt(t, "ddl", tests.RtRepo1+"/ddl-bypass/*.zip", tests.Out+"/bypass/", "--bypass-archive-inspection")

	// Verify file was downloaded
	// DDL doesn't use --flat so file will be in subdirectory
	// On Windows, check both possible paths due to path separator differences
	downloadedZip1 := filepath.Join(tests.Out, "bypass", "ddl-bypass", "test.zip")
	downloadedZip2 := filepath.Join(tests.Out, "bypass", "test.zip")
	assert.True(t, fileutils.IsPathExists(downloadedZip1, false) || fileutils.IsPathExists(downloadedZip2, false), "Zip file should be downloaded")

	cleanArtifactoryTest()
}

func TestDirectDownloadWithBuildDependencies(t *testing.T) {
	initArtifactoryTest(t, "")
	buildName := "ddl-build-deps"
	buildNumber := "1"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)

	// Upload artifacts with build info
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-deps/artifacts/", "--build-name="+buildName, "--build-number="+buildNumber)

	// Upload dependencies - use files from testdata/a/b/c/
	runRt(t, "upload", "testdata/a/b/c/*.in", tests.RtRepo1+"/ddl-deps/dependencies/", "--build-name="+buildName, "--build-number="+buildNumber)

	// Publish build
	runRt(t, "build-publish", buildName, buildNumber)

	// Test exclude-artifacts (DDL requires --build flag format)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-deps/artifacts/*.in", tests.Out+"/exclude-artifacts/",
		"--build="+buildName+"/"+buildNumber, "--exclude-artifacts=true")

	// Check if directory exists first
	if fileutils.IsPathExists(tests.Out+"/exclude-artifacts", false) {
		paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/exclude-artifacts", false)
		// Filter out directories
		var files []string
		for _, path := range paths {
			if isDir, _ := fileutils.IsDirExists(path, false); !isDir {
				files = append(files, path)
			}
		}
		assert.Empty(t, files, "Expected 0 files when exclude-artifacts is true")
	} else {
		// Directory doesn't exist, which is also fine when no files are downloaded
		assert.True(t, true, "No files downloaded as expected")
	}

	// Test include-deps (DDL requires --build flag format)
	runRt(t, "ddl", tests.RtRepo1+"/ddl-deps/dependencies/*.in", tests.Out+"/include-deps/",
		"--build="+buildName+"/"+buildNumber, "--include-deps=true")

	paths2, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/include-deps", false)
	files2 := []string{}
	for _, path := range paths2 {
		if isDir, _ := fileutils.IsDirExists(path, false); !isDir {
			files2 = append(files2, path)
		}
	}
	assert.NotEmpty(t, files2, "Expected files when include-deps is true")

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	cleanArtifactoryTest()
}

func TestDirectDownloadWithSpecVars(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-spec-vars/")

	// Create spec file with variables
	assert.NoError(t, fileutils.CreateDirIfNotExist(tests.Out))
	// Use forward slashes for JSON spec (Artifactory expects forward slashes)
	targetPath := strings.ReplaceAll(tests.Out, "\\", "/")
	specContent := fmt.Sprintf(`{
		"files": [{
			"pattern": "%s/ddl-spec-vars/${var1}",
			"target": "%s/"
		}]
	}`, tests.RtRepo1, targetPath)

	specFile := filepath.Join(tests.Out, "ddl-spec.json")
	err := os.WriteFile(specFile, []byte(specContent), 0644)
	assert.NoError(t, err)

	// Download with spec vars
	runRt(t, "ddl", "--spec="+specFile, "--spec-vars=var1=a*.in")

	// Verify files were downloaded
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded with spec vars")

	cleanArtifactoryTest()
}

func TestDirectDownloadPatternMatching(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files with different patterns
	runRt(t, "upload", "testdata/a/a*.in", tests.RtRepo1+"/ddl-pattern/")
	runRt(t, "upload", "testdata/a/b/*.in", tests.RtRepo1+"/ddl-pattern/b/")

	// Test various pattern matching
	// Test 1: Star pattern
	runRt(t, "ddl", tests.RtRepo1+"/ddl-pattern/a*.in", tests.Out+"/star/")
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/star", false)
	// Filter out directories
	var files []string
	for _, path := range paths {
		if isDir, _ := fileutils.IsDirExists(path, false); !isDir {
			files = append(files, path)
		}
	}
	assert.Equal(t, 3, len(files), "Expected 3 files matching a*.in")

	// Test 2: Question mark pattern
	runRt(t, "ddl", tests.RtRepo1+"/ddl-pattern/a?.in", tests.Out+"/question/")
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out+"/question", false)
	files = []string{}
	for _, path := range paths {
		if isDir, _ := fileutils.IsDirExists(path, false); !isDir {
			files = append(files, path)
		}
	}
	assert.Equal(t, 3, len(files), "Expected 3 files matching a?.in")

	cleanArtifactoryTest()
}

func TestDirectDownloadCombinedFlags(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload test files
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-combined/")

	// Download with multiple flags combined
	runRt(t, "ddl", tests.RtRepo1+"/ddl-combined/*.in", tests.Out+"/",
		"--flat=true", "--threads=5", "--skip-checksum", "--detailed-summary")

	// Verify files were downloaded with flat structure
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	assert.NotEmpty(t, paths, "Expected files to be downloaded")

	// Check flat structure (no subdirectories)
	for _, path := range paths {
		relPath, _ := filepath.Rel(tests.Out, path)
		assert.NotContains(t, relPath, string(os.PathSeparator), "Files should be flat (no subdirectories)")
	}

	cleanArtifactoryTest()
}

func TestDirectDownloadVirtualRepoPatterns(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload to physical repo that's part of the virtual repo
	runRt(t, "upload", "testdata/a/*.in", tests.RtRepo1+"/ddl-virt-pattern/")

	// Test pattern matching through virtual repo (use wildcard for DDL)
	runRt(t, "ddl", tests.RtVirtualRepo+"/ddl-virt-pattern/a?.in", tests.Out+"/")

	// Verify specific files were downloaded (a1.in and a2.in and a3.in)
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	// Filter out directories and count only a1.in and a2.in
	var matchingFiles []string
	for _, path := range paths {
		if isDir, _ := fileutils.IsDirExists(path, false); !isDir {
			baseName := filepath.Base(path)
			if baseName == "a1.in" || baseName == "a2.in" {
				matchingFiles = append(matchingFiles, path)
			}
		}
	}
	assert.Equal(t, 2, len(matchingFiles), "Expected 2 files matching a1.in or a2.in")

	// Removed - logic moved above

	cleanArtifactoryTest()
}

func TestDirectDownloadVirtualRepoPriority(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create 4 local repositories for testing priority resolution
	// repo-local1 will have highest priority, then repo-local2, repo-local3, repo-local4
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	assert.NoError(t, err)

	// Create 4 local repositories
	localRepos := []string{"repo-local1", "repo-local2", "repo-local3", "repo-local4"}
	for _, repoName := range localRepos {
		localRepoConfig := services.NewGenericLocalRepositoryParams()
		localRepoConfig.Key = repoName
		err = servicesManager.CreateLocalRepository().Generic(localRepoConfig)
		assert.NoError(t, err, "Failed to create local repository: "+repoName)
		defer func(repo string) {
			// Clean up the local repo
			err := servicesManager.DeleteRepository(repo)
			if err != nil {
				log.Error("Failed to delete repository:", repo, err)
			}
		}(repoName)
	}

	// Create virtual repository with repo-local1 having highest priority
	virtualRepoName := "test-vr-priority"
	virtualRepoConfig := services.NewGenericVirtualRepositoryParams()
	virtualRepoConfig.Key = virtualRepoName
	virtualRepoConfig.PackageType = "generic"
	// repo-local1 is first (highest priority), then 2, 3, 4
	virtualRepoConfig.Repositories = []string{"repo-local1", "repo-local2", "repo-local3", "repo-local4"}

	err = servicesManager.CreateVirtualRepository().Generic(virtualRepoConfig)
	assert.NoError(t, err, "Failed to create virtual repository")
	defer func() {
		// Clean up the virtual repo
		err := servicesManager.DeleteRepository(virtualRepoName)
		if err != nil {
			log.Error("Failed to delete virtual repository:", err)
		}
	}()

	// Create a test file with unique content for each repository
	// This will help us identify which repo the file was downloaded from
	testFileName := "priority-test.txt"
	repoContents := map[string]string{
		"repo-local1": "CONTENT_FROM_REPO_LOCAL1_HIGHEST_PRIORITY",
		"repo-local2": "content_from_repo_local2",
		"repo-local3": "content_from_repo_local3",
		"repo-local4": "content_from_repo_local4",
	}

	// Upload the same file with different content to all 4 repos
	for repoName, content := range repoContents {
		tempFile := filepath.Join(tests.GetTestResourcesPath(), "temp-"+repoName+".txt")
		assert.NoError(t, os.WriteFile(tempFile, []byte(content), 0644))
		defer func(file string) {
			if err := os.Remove(file); err != nil {
				t.Logf("Failed to remove temp file: %v", err)
			}
		}(tempFile)

		// Upload to each repo
		runRt(t, "upload", tempFile, repoName+"/priority-test/"+testFileName, "--flat=true")
	}

	// Get the virtual repository configuration to verify the order
	var virtualRepoDetails services.VirtualRepositoryBaseParams
	err = servicesManager.GetRepository(virtualRepoName, &virtualRepoDetails)
	assert.NoError(t, err)

	// Log the repository priority order for debugging
	log.Info("Virtual repository", virtualRepoName, "has repositories in priority order:", virtualRepoDetails.Repositories)

	// Download from virtual repo using ONLY DDL command
	runRt(t, "ddl", virtualRepoName+"/priority-test/"+testFileName, tests.Out+"/", "--flat=true")

	// Read the downloaded file
	downloadedFile := filepath.Join(tests.Out, testFileName)
	content, err := os.ReadFile(downloadedFile)
	assert.NoError(t, err)

	// The content should be from repo-local1 since it has the highest priority
	expectedContent := repoContents["repo-local1"]
	assert.Equal(t, expectedContent, string(content),
		"DDL should download from the highest priority repository (repo-local1). "+
			"Expected: %s, Got: %s", expectedContent, string(content))

	// Verify it's really from repo-local1 and not from other repos
	assert.Contains(t, string(content), "REPO_LOCAL1_HIGHEST_PRIORITY",
		"Downloaded content should contain identifier from highest priority repo (repo-local1)")

	// Test 2: Create another virtual repo with different priority order (repo-local3 first)
	clientTestUtils.RemoveAllAndAssert(t, tests.Out)
	virtualRepoName2 := "test-vr-priority2"
	virtualRepoConfig2 := services.NewGenericVirtualRepositoryParams()
	virtualRepoConfig2.Key = virtualRepoName2
	virtualRepoConfig2.PackageType = "generic"
	// Different order: repo-local3 has highest priority now
	virtualRepoConfig2.Repositories = []string{"repo-local3", "repo-local1", "repo-local2", "repo-local4"}

	err = servicesManager.CreateVirtualRepository().Generic(virtualRepoConfig2)
	assert.NoError(t, err, "Failed to create second virtual repository")
	defer func() {
		// Clean up the second virtual repo
		err := servicesManager.DeleteRepository(virtualRepoName2)
		if err != nil {
			log.Error("Failed to delete second virtual repository:", err)
		}
	}()

	// Download from the second virtual repo using DDL - should get content from repo-local3 now
	runRt(t, "ddl", virtualRepoName2+"/priority-test/"+testFileName, tests.Out+"/", "--flat=true")

	content2, err := os.ReadFile(downloadedFile)
	assert.NoError(t, err)

	// This time it should be from repo-local3 since it has highest priority in virtualRepoName2
	expectedContent2 := repoContents["repo-local3"]
	assert.Equal(t, expectedContent2, string(content2),
		"DDL should download from the highest priority repository (repo-local3) in the second virtual repo. "+
			"Expected: %s, Got: %s", expectedContent2, string(content2))

	cleanArtifactoryTest()
}

func TestDirectDownloadErrorScenarios(t *testing.T) {
	initArtifactoryTest(t, "")

	// Test 1: Non-existent repository
	err := artifactoryCli.Exec([]string{"ddl", "non-existent-repo/file.txt", tests.Out + "/", "--server-id=" + tests.ServerId}...)
	assert.Error(t, err, "Expected error for non-existent repository")

	// Test 2: Invalid pattern - DDL will try to download literally named file
	// This is different from DL which would fail on invalid regex
	// Skip this test on Windows as [ character has special meaning in Windows paths
	if runtime.GOOS != "windows" {
		err = artifactoryCli.Exec([]string{"ddl", tests.RtRepo1 + "/[invalid-pattern", tests.Out + "/", "--server-id=" + tests.ServerId}...)
		// DDL tries to download a file named "[invalid-pattern" which doesn't exist, so it fails
		assert.Error(t, err, "Expected error for non-existent file pattern")
	}

	// Test 3: Missing target directory in command - DDL downloads to current directory
	err = artifactoryCli.Exec([]string{"ddl", tests.RtRepo1 + "/file.txt", "--server-id=" + tests.ServerId}...)
	// DDL tries to download file.txt which doesn't exist, so it fails
	assert.Error(t, err, "Expected error for non-existent file")

	cleanArtifactoryTest()
}

// Sort and limit changes the way properties are used so this should be tested with symlinks and search by build

// Upload symlink by full path to Artifactory and the link content checksum
// Download the symlink which was uploaded with limit param.
// validate the symlink content checksum.
func TestArtifactoryLimitWithSymlink(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localFile := filepath.Join(tests.GetTestResourcesPath()+"a", "a1.in")
	link := filepath.Join(tests.GetTestResourcesPath()+"a", "link")
	err := os.Symlink(localFile, link)
	assert.NoError(t, err)
	runRt(t, "u", link, tests.RtRepo1, "--symlinks=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link)
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/", "--validate-symlinks=true", "--limit=1")
	validateSortLimitWithSymLink(link, localFile, t)
	clientTestUtils.RemoveAndAssert(t, link)
	cleanArtifactoryTest()
}

// Upload symlink by full path to Artifactory and the link content checksum
// Download the symlink which was uploaded with limit param.
// validate the symlink content checksum.
func TestArtifactorySortWithSymlink(t *testing.T) {
	if coreutils.IsWindows() {
		t.Skip("Running on windows, skipping...")
	}
	initArtifactoryTest(t, "")
	localFile := filepath.Join(tests.GetTestResourcesPath()+"a", "a1.in")
	link := filepath.Join(tests.GetTestResourcesPath()+"a", "link")
	err := os.Symlink(localFile, link)
	assert.NoError(t, err)
	runRt(t, "u", link, tests.RtRepo1, "--symlinks=true", "--flat=true")
	clientTestUtils.RemoveAndAssert(t, link)
	runRt(t, "dl", tests.RtRepo1+"/link", tests.GetTestResourcesPath()+"a/", "--validate-symlinks=true", "--sort-by=created")
	validateSortLimitWithSymLink(link, localFile, t)
	clientTestUtils.RemoveAndAssert(t, link)
	cleanArtifactoryTest()
}

func validateSortLimitWithSymLink(localLinkPath, localFilePath string, t *testing.T) {
	exists := fileutils.IsPathSymlink(localLinkPath)
	assert.True(t, exists, "failed to download symlinks from artifactory with Sort/Limit flag")
	symlinks, err := filepath.EvalSymlinks(localLinkPath)
	assert.NoError(t, err, "can't eval symlinks with Sort/Limit flag")
	assert.Equal(t, localFilePath, symlinks, "Symlinks wasn't created as expected with Sort/Limit flag")
}

// Upload a file to 2 different builds.
// Verify that we don't download files with same sha and build name and different build number when sort is configured.
func TestArtifactoryDownloadByShaAndBuildNameWithSort(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB, buildNumberC := "10", "11", "12"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.BuildDownloadSpecNoBuildNumberWithSort)
	assert.NoError(t, err)
	// Upload 3 similar files to 2 different builds
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a10.in", "--build-name="+tests.RtBuildName2, "--build-number="+buildNumberA)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a11.in", "--build-name="+tests.RtBuildName2, "--build-number="+buildNumberB)
	runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/a12.in", "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberC)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberC)
	runRt(t, "build-publish", tests.RtBuildName2, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName2, buildNumberB)

	// Download by build number
	runRt(t, "download", "--sort-by=created", "--spec="+specFile)

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(filepath.Join(tests.Out, "download", "sort_limit_by_build"), false)
	err = tests.ValidateListsIdentical(tests.GetBuildDownloadByShaAndBuildNameWithSort(), paths)
	assert.NoError(t, err)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName2, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyByBuildUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.CopyByBuildSpec)
	assert.NoError(t, err)
	// Upload files with buildName and buildNumber: a* uploaded with build number "10", b* uploaded with build number "11"
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Copy by build name "cli-test-build" and build number "10" from spec, a* should be copied
	runRt(t, "copy", "--spec="+specFile)

	// Validate files are Copied by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetBuildCopyExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryCopyByBuildPatternAllUsingSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.CopyByBuildPatternAllSpec)
	assert.NoError(t, err)
	// Upload files with buildName and buildNumber: a* uploaded with build number "10", b* uploaded with build number "11"
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Copy by build name "cli-test-build" and build number "10" from spec, a* should be copied
	runRt(t, "copy", "--spec="+specFile)

	// Validate files are Copied by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetBuildCopyExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactorySortAndLimit(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload all testdata/a/ files
	runRt(t, "upload", "testdata/a/(*)", tests.RtRepo1+"/data/{1}")

	// Download 1 sorted by name asc
	runRt(t, "download", tests.RtRepo1+"/data/", "out/download/sort_limit/", "--sort-by=name", "--limit=1")

	// Download 3 sorted by depth desc
	runRt(t, "download", tests.RtRepo1+"/data/", "out/download/sort_limit/", "--sort-by=depth", "--limit=3", "--sort-order=desc")

	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err := tests.ValidateListsIdentical(tests.GetSortAndLimit(), paths)
	assert.NoError(t, err)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactorySortByCreated(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files separately so we can sort by created.
	runRt(t, "upload", "testdata/created/or", tests.RtRepo1, `--target-props=k1=v1`, "--flat=true")
	runRt(t, "upload", "testdata/created/o", tests.RtRepo1, "--flat=true")
	runRt(t, "upload", "testdata/created/org", tests.RtRepo1, "--flat=true")

	// Prepare search command
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).SortBy([]string{"created"}).SortOrder("asc").Limit(3)
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	reader, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)

	var resultItems []utils.SearchResult
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)

	}
	assert.Len(t, resultItems, 3)
	// Verify the sort by checking if the item results are ordered by asc.
	assert.True(t, reflect.DeepEqual(resultItems[0], tests.GetFirstSearchResultSortedByAsc()))
	assert.True(t, reflect.DeepEqual(resultItems[1], tests.GetSecondSearchResultSortedByAsc()))
	assert.True(t, reflect.DeepEqual(resultItems[2], tests.GetThirdSearchResultSortedByAsc()))

	readerCloseAndAssert(t, reader)
	searchCmd.SetSpec(searchSpecBuilder.SortOrder("desc").BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)
	reader, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	resultItems = nil
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	assert.Len(t, resultItems, 3)
	// Verify the sort by checking if the item results are ordered by desc.
	assert.True(t, reflect.DeepEqual(resultItems[2], tests.GetFirstSearchResultSortedByAsc()))
	assert.True(t, reflect.DeepEqual(resultItems[1], tests.GetSecondSearchResultSortedByAsc()))
	assert.True(t, reflect.DeepEqual(resultItems[0], tests.GetThirdSearchResultSortedByAsc()))
	readerCloseAndAssert(t, reader)

	// Cleanup
	cleanArtifactoryTest()
}
func TestArtifactoryOffset(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload all testdata/a/ files
	runRt(t, "upload", "testdata/a/*", path.Join(tests.RtRepo1, "offset_test")+"/", "--flat=true")

	// Downloading files one by one, to check that the offset is working as expected.
	// Download only the first file, expecting to download a1.in
	runRt(t, "download", tests.RtRepo1+"/offset_test/", tests.Out+"/", "--flat=true", "--sort-by=name", "--limit=1", "--offset=0")
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a1.in")}, paths, t)

	// Download the second file, expecting to download a2.in
	runRt(t, "download", tests.RtRepo1+"/offset_test/", tests.Out+"/", "--flat=true", "--sort-by=name", "--limit=1", "--offset=1")
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a2.in")}, paths, t)

	// Download the third file, expecting to download a3.in
	runRt(t, "download", tests.RtRepo1+"/offset_test/", tests.Out+"/", "--flat=true", "--sort-by=name", "--limit=1", "--offset=2")
	paths, _ = fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	tests.VerifyExistLocally([]string{filepath.Join(tests.Out, "a3.in")}, paths, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryCopyByBuildOverridingByInlineFlag(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.CopyByBuildSpec)
	assert.NoError(t, err)

	// Upload files with buildName and buildNumber: b* uploaded with build number "10", a* uploaded with build number "11"
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Copy by build number: using override of build by flag from inline (no number set so the LATEST build should be copied), a* should be copied
	runRt(t, "copy", "--build="+tests.RtBuildName1, "--spec="+specFile)

	// Validate files are Copied by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildCopyExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryMoveByBuildUsingFlags(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.CopyByBuildSpec)
	assert.NoError(t, err)

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Move by build name and number
	runRt(t, "move", "--build="+tests.RtBuildName1+"/11", "--spec="+specFile)

	// Validate files are moved by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildMoveExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestArtifactoryMoveNoSpec(t *testing.T) {
	testCopyMoveNoSpec("mv", tests.GetBuildBeforeMoveExpected(), tests.GetBuildMoveExpected(), t)
}

func TestArtifactoryMoveExcludeByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Move by pattern
	runRt(t, "move", tests.RtRepo1+"/data/", tests.RtRepo2+"/", "--exclusions=*/*b*;*/*c*")

	// Validate excluded files didn't move
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildMoveExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryMoveExclusionsByCli(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Move by pattern
	runRt(t, "move", tests.RtRepo1+"/data/", tests.RtRepo2+"/", "--exclusions=*/*b*;*/*c*")

	// Validate excluded files didn't move
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildMoveExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryMoveExclusionsBySpec(t *testing.T) {
	initArtifactoryTest(t, "")
	specFile, err := tests.CreateSpec(tests.MoveCopySpecExclusions)
	assert.NoError(t, err)

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Move by spec
	runRt(t, "move", "--spec="+specFile)

	// Validate excluded files didn't move
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildMoveExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryDeleteByLatestBuild(t *testing.T) {
	initArtifactoryTest(t, "")
	buildNumberA, buildNumberB := "10", "11"
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	specFile, err := tests.CreateSpec(tests.CopyByBuildSpec)
	assert.NoError(t, err)

	// Upload files with buildName and buildNumber
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA)
	runRt(t, "upload", "--spec="+specFileA, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberB)

	// Publish buildInfo
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberA)
	runRt(t, "build-publish", tests.RtBuildName1, buildNumberB)

	// Delete by build name and LATEST
	runRt(t, "delete", "--build="+tests.RtBuildName1+"/LATEST", "--spec="+specFile)

	// Validate files are deleted by build number
	cpMvDlByBuildAssertSpec, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)

	inttestutils.VerifyExistInArtifactory(tests.GetBuildDeleteExpected(), cpMvDlByBuildAssertSpec, serverDetails, t)

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

func TestGitLfsCleanup(t *testing.T) {
	initArtifactoryTest(t, "")
	var fileRootPath = "testdata/gitlfs/"
	runRt(t, "upload", fileRootPath+"(4b)(*)", tests.RtLfsRepo+"/objects/4b/f4/{2}{1}", "--flat=true")
	runRt(t, "upload", fileRootPath+"*", tests.RtLfsRepo+"/objects/4b/f4/", "--flat=true")
	refs := path.Join("refs", "remotes", "*")
	dotGitPath := getCliDotGitPath(t)
	runRt(t, "glc", dotGitPath, "--repo="+tests.RtLfsRepo, "--refs=HEAD,"+refs)
	gitlfsSpecFile, err := tests.CreateSpec(tests.GitLfsAssertSpec)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetGitLfsExpected(), gitlfsSpecFile, serverDetails, t)
	cleanArtifactoryTest()
}

func TestPing(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "ping")
	cleanArtifactoryTest()
}

type summaryExpected struct {
	errors  bool
	status  string
	success int64
	failure int64
}

func TestSummaryReport(t *testing.T) {
	initArtifactoryTest(t, "")

	uploadSpecFile, err := tests.CreateSpec(tests.UploadFlatNonRecursive)
	assert.NoError(t, err)
	downloadSpecFile, err := tests.CreateSpec(tests.DownloadAllRepo1TestResources)
	assert.NoError(t, err)

	argsMap := map[string][]string{
		"upload":       {"--spec=" + uploadSpecFile},
		"move":         {path.Join(tests.RtRepo1, "*.in"), tests.RtRepo2 + "/"},
		"copy":         {path.Join(tests.RtRepo2, "*.in"), tests.RtRepo1 + "/"},
		"delete":       {path.Join(tests.RtRepo2, "*.in")},
		"set-props":    {path.Join(tests.RtRepo1, "*.in"), "prop=val"},
		"delete-props": {path.Join(tests.RtRepo1, "*.in"), "prop"},
		"download":     {"--spec=" + downloadSpecFile},
	}
	expected := summaryExpected{
		false,
		"success",
		3,
		0,
	}
	testSummaryReport(t, argsMap, expected)
}

func TestSummaryReportFailNoOpTrue(t *testing.T) {
	initArtifactoryTest(t, "")
	testFailNoOpSummaryReport(t, true)
}

func TestSummaryReportFailNoOpFalse(t *testing.T) {
	initArtifactoryTest(t, "")
	testFailNoOpSummaryReport(t, false)
}

// Test summary after commands that do no actions, with/without failNoOp flag.
func testFailNoOpSummaryReport(t *testing.T, failNoOp bool) {
	initArtifactoryTest(t, "")

	nonExistingSource := "./*non/existing/source/*"
	nonExistingDest := "non/existing/dest/"
	failNoOpFlag := "--fail-no-op=" + strconv.FormatBool(failNoOp)

	argsMap := map[string][]string{
		"upload":       {nonExistingSource, nonExistingDest, failNoOpFlag},
		"move":         {nonExistingSource, nonExistingDest, failNoOpFlag},
		"copy":         {nonExistingSource, nonExistingDest, failNoOpFlag},
		"delete":       {nonExistingSource, failNoOpFlag},
		"set-props":    {nonExistingSource, "prop=val", failNoOpFlag},
		"delete-props": {nonExistingSource, "prop", failNoOpFlag},
		"download":     {nonExistingSource, nonExistingDest, failNoOpFlag},
	}
	expected := summaryExpected{
		failNoOp,
		"success",
		0,
		0,
	}
	if failNoOp {
		expected.status = "failure"
	}
	testSummaryReport(t, argsMap, expected)
}

func testSummaryReport(t *testing.T, argsMap map[string][]string, expected summaryExpected) {
	buffer, _, previousLog := coretests.RedirectLogOutputToBuffer()
	// Restore previous logger when the function returns
	defer log.SetLogger(previousLog)

	for _, cmd := range []string{"upload", "move", "copy", "delete", "set-props", "delete-props", "download"} {
		// Execute the cmd with it's args.
		err := artifactoryCli.Exec(append([]string{cmd}, argsMap[cmd]...)...)
		verifySummary(t, buffer, previousLog, err, expected)
	}
	cleanArtifactoryTest()
}

func TestUploadDeploymentView(t *testing.T) {
	initArtifactoryTest(t, "")
	assertPrintedDeploymentViewFunc, cleanupFunc := initDeploymentViewTest(t)
	defer cleanupFunc()
	uploadCmd := generic.NewUploadCommand()
	fileSpec := spec.NewBuilder().Pattern(filepath.Join("testdata", "a", "a*.in")).Target(tests.RtRepo1).BuildSpec()
	uploadCmd.SetUploadConfiguration(createUploadConfiguration()).SetSpec(fileSpec).SetServerDetails(serverDetails)
	assert.NoError(t, artifactoryCli.Exec("upload", filepath.Join("testdata", "a", "a*.in"), tests.RtRepo1))
	assertPrintedDeploymentViewFunc()
	cleanArtifactoryTest()
}

func TestUploadDeploymentViewWithArchive(t *testing.T) {
	initArtifactoryTest(t, "")
	assertPrintedDeploymentViewFunc, cleanupFunc := initDeploymentViewTest(t)
	defer cleanupFunc()
	assert.NoError(t, artifactoryCli.Exec("upload", filepath.Join("testdata", "a", "a*.in"), path.Join(tests.RtRepo1, "z.zip"), "--archive", "zip"))
	assertPrintedDeploymentViewFunc()
	cleanArtifactoryTest()
}

func TestUploadZipAndCheckDeploymentViewWithArchive(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create tmp dir
	assert.NoError(t, os.Mkdir(tests.Out, 0755))
	wd, err := os.Getwd()
	assert.NoError(t, err)
	defer cleanArtifactoryTest()
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, tests.Out)
	defer chdirCallback()

	// Create file and a zip
	fileName := "dummy_file.txt"
	zipName := "test.zip"
	assert.NoError(t, os.WriteFile(fileName, nil, 0644))

	// Upload & download zip file
	assert.NoError(t, artifactoryCli.Exec("upload", fileName, path.Join(tests.RtRepo1, zipName), "--archive", "zip"))
	assert.NoError(t, artifactoryCli.Exec("download", path.Join(tests.RtRepo1, zipName)))

	// Check for time-zone offset for each file in the zip
	r, err := zip.OpenReader(zipName)
	assert.NoError(t, err)
	defer func() { assert.NoError(t, r.Close()) }()
	_, sysTimezoneOffset := time.Now().Zone()
	for _, file := range r.File {
		_, fileTimezoneOffset := file.Modified.Zone()
		assert.Equal(t, sysTimezoneOffset, fileTimezoneOffset)
	}

}

func TestUploadEmptyArchiveWithEmptyArchiveEnv(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create tmp dir
	assert.NoError(t, os.Mkdir(tests.Out, 0755))
	wd, err := os.Getwd()
	assert.NoError(t, err)
	defer cleanArtifactoryTest()
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, tests.Out)
	defer chdirCallback()

	// Create file and a zip
	zipName := "test.zip"

	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, services.JfrogCliUploadEmptyArchiveEnv, "true")
	defer setEnvCallBack()

	// Upload & download zip file
	assert.NoError(t, artifactoryCli.Exec("upload", "*", path.Join(tests.RtRepo1, zipName), "--exclusions", "**", "--archive", "zip"))
	assert.NoError(t, artifactoryCli.Exec("download", path.Join(tests.RtRepo1, zipName)))

	// Check that the zip file uploaded and it's empty
	assert.FileExists(t, zipName)
	r, err := zip.OpenReader(zipName)
	assert.NoError(t, err)
	defer func() { assert.NoError(t, r.Close()) }()
	assert.Empty(t, r.File)
}

func TestUploadDetailedSummary(t *testing.T) {
	initArtifactoryTest(t, "")
	uploadCmd := generic.NewUploadCommand()
	fileSpec := spec.NewBuilder().Pattern(filepath.Join("testdata", "a", "a*.in")).Target(tests.RtRepo1).BuildSpec()
	uploadCmd.SetUploadConfiguration(createUploadConfiguration()).SetSpec(fileSpec).SetServerDetails(serverDetails).SetDetailedSummary(true)
	assert.NoError(t, commands.Exec(uploadCmd))
	result := uploadCmd.Result()
	reader := result.Reader()
	readerGetErrorAndAssert(t, reader)
	defer readerCloseAndAssert(t, reader)
	var files []clientutils.FileTransferDetails
	for transferDetails := new(clientutils.FileTransferDetails); reader.NextRecord(transferDetails) == nil; transferDetails = new(clientutils.FileTransferDetails) {
		files = append(files, *transferDetails)
	}
	assert.ElementsMatch(t, files, tests.GetExpectedUploadSummaryDetails(*tests.JfrogUrl+tests.ArtifactoryEndpoint))
	cleanArtifactoryTest()
}

func createUploadConfiguration() *utils.UploadConfiguration {
	uploadConfiguration := new(utils.UploadConfiguration)
	uploadConfiguration.Threads = commonCliUtils.Threads
	return uploadConfiguration
}

func TestArtifactoryBuildDiscard(t *testing.T) {
	// Initialize
	initArtifactoryTest(t, "")
	client, err := httpclient.ClientBuilder().Build()
	assert.NoError(t, err)

	// Upload files with buildName and buildNumber
	for i := 1; i <= 5; i++ {
		runRt(t, "upload", "testdata/a/a1.in", tests.RtRepo1+"/data/", "--build-name="+tests.RtBuildName1, "--build-number="+strconv.Itoa(i))
		runRt(t, "build-publish", tests.RtBuildName1, strconv.Itoa(i))
	}

	// Test discard by max-builds
	runRt(t, "build-discard", tests.RtBuildName1, "--max-builds=3")
	jsonResponse := getAllBuildsByBuildName(client, tests.RtBuildName1, t, http.StatusOK)
	assert.Len(t, jsonResponse.Builds, 3, "Incorrect operation of build-discard by max-builds.")

	// Test discard with exclusion
	runRt(t, "build-discard", tests.RtBuildName1, "--max-days=-1", "--exclude-builds=3,5")
	jsonResponse = getAllBuildsByBuildName(client, tests.RtBuildName1, t, http.StatusOK)
	assert.Len(t, jsonResponse.Builds, 2, "Incorrect operation of build-discard with exclusion.")

	// Test discard by max-days
	runRt(t, "build-discard", tests.RtBuildName1, "--max-days=-1")
	jsonResponse = getAllBuildsByBuildName(client, tests.RtBuildName1, t, http.StatusNotFound)
	assert.Zero(t, jsonResponse, "Incorrect operation of build-discard by max-days.")

	// Cleanup
	inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	cleanArtifactoryTest()
}

// Tests compatibility to file paths with windows separators.
// Verifies the upload and download commands work as expected for inputs of both arguments and spec files.
func TestArtifactoryWinBackwardsCompatibility(t *testing.T) {
	initArtifactoryTest(t, "")
	if !coreutils.IsWindows() {
		t.Skip("Not running on Windows, skipping...")
	}
	uploadSpecFile, err := tests.CreateSpec(tests.WinSimpleUploadSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+uploadSpecFile)
	runRt(t, "upload", "testdata\\\\a\\\\b\\\\*", tests.RtRepo1+"/compatibility_arguments/", "--exclusions=*b2.in;*c*")

	downloadSpecFile, err := tests.CreateSpec(tests.WinSimpleDownloadSpec)
	assert.NoError(t, err)
	runRt(t, "download", "--spec="+downloadSpecFile)
	runRt(t, "download", tests.RtRepo1+"/*arguments*", "out\\\\win\\\\", "--flat=true")

	// Validate files are downloaded by build number
	paths, _ := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
	err = tests.ValidateListsIdentical(tests.GetWinCompatibility(), paths)
	assert.NoError(t, err)
	cleanArtifactoryTest()
}

func TestArtifactorySearchIncludeDir(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFileA, "--recursive", "--flat=false")

	// Prepare search command
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)
	searchCmd.SetSpec(searchSpecBuilder.IncludeDirs(false).BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)

	// Search without IncludeDirs
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchNotIncludeDirsFiles())
	readerCloseAndAssert(t, readerNoDate)

	// Search with IncludeDirs
	searchCmd.SetSpec(searchSpecBuilder.IncludeDirs(true).BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchIncludeDirsFiles())
	readerCloseAndAssert(t, readerNoDate)

	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactorySearchProps(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadWithPropsSpec)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile, "--recursive")

	// Prepare search command
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)

	// Search artifacts with c=3
	searchCmd.SetSpec(searchSpecBuilder.Props("c=3").BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep1())
	readerCloseAndAssert(t, readerNoDate)

	// Search artifacts without c=3
	searchCmd.SetSpec(searchSpecBuilder.Props("").ExcludeProps("c=3").BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep2())
	readerCloseAndAssert(t, readerNoDate)

	// Search artifacts without a=1&b=2
	searchCmd.SetSpec(searchSpecBuilder.Props("").ExcludeProps("a=1;b=2").BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep3())
	readerCloseAndAssert(t, readerNoDate)

	// Search artifacts without a=1&b=2 and with c=3
	searchCmd.SetSpec(searchSpecBuilder.Props("c=3").ExcludeProps("a=1;b=2").BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep4())
	readerCloseAndAssert(t, readerNoDate)

	// Search artifacts without a=1 and with c=5
	searchCmd.SetSpec(searchSpecBuilder.Props("c=5").ExcludeProps("a=1").BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep5())
	readerCloseAndAssert(t, readerNoDate)

	// Search artifacts by pattern "*b*", exclude pattern "*3*", with "b=1" and without "c=3"
	pattern := tests.RtRepo1 + "/*b*"
	exclusions := []string{tests.RtRepo1 + "/*3*"}
	searchSpecBuilder = spec.NewBuilder().Pattern(pattern).Recursive(true).Exclusions(exclusions).Props("b=1").ExcludeProps("c=3")
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		assert.NoError(t, assertDateInSearchResult(*resultItem))
	}
	readerGetErrorAndAssert(t, reader)
	reader.Reset()

	resultItems = []utils.SearchResult{}
	readerNoDate, err = utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchPropsStep6())
	readerCloseAndAssert(t, readerNoDate)

	// Cleanup
	cleanArtifactoryTest()
}

// Test that the --include flag works correctly with spec files
func TestArtifactorySearchIncludeWithSpec(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile, "--recursive", "--flat=false")

	// Test 1: Search with spec WITHOUT --include flag (should return all fields)
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1 + "/*").Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpecBuilder.BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)

	foundWithAllFields := false
	for resultItem := new(utils.SearchResult); reader.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		// Check that we have all default fields (type, size, sha1, etc.)
		if resultItem.Type != "" && resultItem.Size > 0 && resultItem.Sha1 != "" {
			foundWithAllFields = true
			break
		}
	}
	assert.True(t, foundWithAllFields, "Search without --include should return all fields")
	readerCloseAndAssert(t, reader)

	// Test 2: Search with spec WITH --include flag using spec builder (simulating CLI flag)
	searchSpecBuilder = spec.NewBuilder().Pattern(tests.RtRepo1 + "/*").Recursive(true).Include([]string{"size", "created"})
	searchCmd = generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpecBuilder.BuildSpec())
	reader, err = searchCmd.Search()
	assert.NoError(t, err)

	// Verify limited fields are returned
	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
		// Verify that size and created are present (when include is used)
		// Note: path, name, repo are always included as base fields
		assert.NotEmpty(t, resultItem.Path, "Path should always be present")
		// Check that we have the requested field
		if resultItem.Size > 0 {
			// Size was requested, should be present
			assert.Greater(t, resultItem.Size, int64(0), "Size should be present when included")
		}
	}
	assert.Greater(t, len(resultItems), 0, "Should find at least one artifact")
	readerGetErrorAndAssert(t, readerNoDate)
	readerCloseAndAssert(t, readerNoDate)

	// Cleanup
	cleanArtifactoryTest()
}

// Remove not to be deleted dirs from delete command from path to delete.
func TestArtifactoryDeleteExcludeProps(t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFile, err := tests.CreateSpec(tests.UploadWithPropsSpecDeleteExcludeProps)
	assert.NoError(t, err)
	runRt(t, "upload", "--spec="+specFile, "--recursive")

	// Prepare search command
	searchSpecBuilder := spec.NewBuilder().Pattern(tests.RtRepo1).Recursive(true)
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails)

	// Delete all artifacts without c=1 but keep dirs that has at least one artifact with c=1 props
	runRt(t, "delete", tests.RtRepo1+"/*", "--exclude-props=c=1")

	// Search artifacts with c=1
	searchCmd.SetSpec(searchSpecBuilder.BuildSpec())
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	assert.ElementsMatch(t, resultItems, tests.GetSearchAfterDeleteWithExcludeProps())
	readerCloseAndAssert(t, readerNoDate)

	// Cleanup
	cleanArtifactoryTest()
}

func getAllBuildsByBuildName(client *httpclient.HttpClient, buildName string, t *testing.T, expectedHttpStatusCode int) buildsApiResponseStruct {
	resp, body, _, _ := client.SendGet(serverDetails.ArtifactoryUrl+"api/build/"+buildName, true, artHttpDetails, "")
	assert.Equal(t, expectedHttpStatusCode, resp.StatusCode, "Failed retrieving build information from artifactory.")

	buildsApiResponse := &buildsApiResponseStruct{}
	err := json.Unmarshal(body, buildsApiResponse)
	assert.NoError(t, err, "Unmarshalling failed with an error")
	return *buildsApiResponse
}

type buildsApiInnerBuildsStruct struct {
	Uri     string `json:"uri,omitempty"`
	Started string `json:"started,omitempty"`
}

type buildsApiResponseStruct struct {
	Uri    string                       `json:"uri,omitempty"`
	Builds []buildsApiInnerBuildsStruct `json:"buildsNumbers,omitempty"`
}

func verifySummary(t *testing.T, buffer *bytes.Buffer, logger log.Log, cmdError error, expected summaryExpected) {
	if expected.errors {
		assert.Error(t, cmdError)
	} else {
		assert.NoError(t, cmdError)
	}

	output := buffer.Bytes()
	buffer.Reset()
	logger.Output(string(output))

	status, err := jsonparser.GetString(output, "status")
	assert.NoError(t, err)
	assert.Equal(t, expected.status, status, "Summary validation failed")

	resultSuccess, err := jsonparser.GetInt(output, "totals", "success")
	assert.NoError(t, err)

	resultFailure, err := jsonparser.GetInt(output, "totals", "failure")
	assert.NoError(t, err)

	assert.Equal(t, expected.success, resultSuccess, "Summary validation failed")
	assert.Equal(t, expected.failure, resultFailure, "Summary validation failed")
}

func CleanArtifactoryTests() {
	cleanArtifactoryTest()
	deleteCreatedRepos()
}

func initArtifactoryTest(t *testing.T, minVersion string) {
	if !*tests.TestArtifactory {
		t.Skip("Skipping artifactory test. To run artifactory test add the '-test.artifactory=true' option.")
	}
	if minVersion != "" {
		validateArtifactoryVersion(t, minVersion)
	}
}

func validateArtifactoryVersion(t *testing.T, minVersion string) {
	rtVersion, err := getArtifactoryVersion()
	if err != nil {
		assert.NoError(t, err)
		return
	}
	if !rtVersion.AtLeast(minVersion) {
		t.Skip("Skipping test. Artifactory version not supported.")
	}
}

func getArtifactoryVersion() (version.Version, error) {
	rtVersion, err := artAuth.GetVersion()
	return *version.NewVersion(rtVersion), err
}

func cleanArtifactoryTest() {
	if !*tests.TestArtifactory {
		return
	}
	log.Info("Cleaning test data...")
	cleanArtifactory()
	tests.CleanFileSystem()
}

func preUploadBasicTestResources(t *testing.T) {
	uploadPath := tests.GetTestResourcesPath() + "a/(.*)"
	targetPath := tests.RtRepo1 + "/test_resources/{1}"
	runRt(t, "upload", uploadPath, targetPath,
		"--threads=10", "--regexp=true", "--target-props=searchMe=true", "--flat=false")
}

func execDeleteRepo(repoName string) {
	err := artifactoryCli.Exec("repo-delete", repoName, "--quiet")
	if err != nil {
		log.Error("Couldn't delete repository", repoName, ":", err.Error())
	}
}

func execDeleteUser(username string) {
	err := artifactoryCli.Exec("users-delete", username, "--quiet")
	if err != nil {
		log.Error("Couldn't delete user", username, ":", err.Error())
	}
}

func getAllRepos() (repositoryKeys []string, err error) {
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	if err != nil {
		return nil, err
	}
	repos, err := servicesManager.GetAllRepositories()
	if err != nil {
		return nil, err
	}
	for _, repo := range *repos {
		repositoryKeys = append(repositoryKeys, repo.Key)
	}
	return
}

func execListBuildNamesRest() ([]string, error) {
	var buildNames []string

	// Build http client
	client, err := httpclient.ClientBuilder().Build()
	if err != nil {
		return nil, err
	}

	// Send get request
	resp, body, _, err := client.SendGet(serverDetails.ArtifactoryUrl+"api/build", true, artHttpDetails, "")
	if err != nil {
		return nil, err
	}

	if err = errorutils.CheckResponseStatusWithBody(resp, body, http.StatusOK, http.StatusCreated); err != nil {
		return nil, err
	}

	builds, _, _, err := jsonparser.Get(body, "builds")
	if err != nil {
		return nil, err
	}

	// Extract repository keys from the json response
	var keyError error
	_, err = jsonparser.ArrayEach(builds, func(value []byte, dataType jsonparser.ValueType, offset int, err error) {
		if err != nil || keyError != nil {
			return
		}
		buildName, err := jsonparser.GetString(value, "uri")
		if err != nil {
			keyError = err
			return
		}
		buildNames = append(buildNames, strings.TrimPrefix(buildName, "/"))
	})
	if keyError != nil {
		return nil, err
	}

	return buildNames, err
}

func execCreateRepoRest(repoConfig, repoName string) {
	output, err := os.ReadFile(repoConfig)
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	rtutils.AddHeader("Content-Type", "application/json", &artHttpDetails.Headers)
	client, err := httpclient.ClientBuilder().Build()
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	resp, body, err := client.SendPut(serverDetails.ArtifactoryUrl+"api/repositories/"+repoName, output, artHttpDetails, "")
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	if err = errorutils.CheckResponseStatusWithBody(resp, body, http.StatusOK, http.StatusCreated); err != nil {
		log.Error(err)
		os.Exit(1)
	}
	log.Info("Repository", repoName, "created.")
}

func getAllUsernames() (usernames []string, err error) {
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	if err != nil {
		return nil, err
	}
	users, err := servicesManager.GetAllUsers()
	if err != nil {
		return nil, err
	}
	for _, user := range users {
		usernames = append(usernames, user.Name)
	}
	return
}

func createRequiredRepos() {
	tests.CreatedNonVirtualRepositories = tests.GetNonVirtualRepositories()
	createRepos(tests.CreatedNonVirtualRepositories)
	tests.CreatedVirtualRepositories = tests.GetVirtualRepositories()
	createRepos(tests.CreatedVirtualRepositories)
}

func cleanUpOldBuilds() {
	tests.CleanUpOldItems(tests.GetBuildNames(), execListBuildNamesRest, func(buildName string) {
		inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, buildName, artHttpDetails)
	})
}

func cleanUpOldRepositories() {
	tests.CleanUpOldItems(tests.GetAllRepositoriesNames(), getAllRepos, execDeleteRepo)
}

func cleanUpOldUsers() {
	tests.CleanUpOldItems(tests.GetTestUsersNames(), getAllUsernames, execDeleteUser)
}

func createRepos(repos map[*string]string) {
	for repoName, configFile := range repos {
		if !isRepoExist(*repoName) {
			repoConfig := tests.GetTestResourcesPath() + configFile
			repoConfig, err := tests.ReplaceTemplateVariables(repoConfig, "")
			if err != nil {
				log.Error(err)
				os.Exit(1)
			}
			execCreateRepoRest(repoConfig, *repoName)
		}
	}
}

func deleteCreatedRepos() {
	// Important - Virtual repositories must be deleted first
	deleteRepos(tests.CreatedVirtualRepositories)
	deleteRepos(tests.CreatedNonVirtualRepositories)
}

func deleteRepos(repos map[*string]string) {
	for repoName := range repos {
		if isRepoExist(*repoName) {
			execDeleteRepo(*repoName)
		}
	}
}

func cleanArtifactory() {
	deleteSpecFile := tests.GetFilePathForArtifactory(tests.DeleteSpec)
	log.Output(deleteSpecFile)
	deleteSpecFile, err := tests.ReplaceTemplateVariables(deleteSpecFile, "")
	log.Output(deleteSpecFile)
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	deleteSpec, _ := spec.CreateSpecFromFile(deleteSpecFile, nil)
	_, _, err = tests.DeleteFiles(deleteSpec, serverDetails)
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
}

func getSpecAndCommonFlags(specFile string) (*spec.SpecFiles, rtutils.CommonConf) {
	searchFlags, _ := rtutils.NewCommonConfImpl(artAuth)
	searchSpec, _ := spec.CreateSpecFromFile(specFile, nil)
	return searchSpec, searchFlags
}

func verifyDoesntExistInArtifactory(specFile string, t *testing.T) {
	inttestutils.VerifyExistInArtifactory([]string{}, specFile, serverDetails, t)
}

func verifyExistInArtifactoryByProps(expected []string, pattern, props string, t *testing.T) {
	searchSpec := spec.NewBuilder().Pattern(pattern).Props(props).Recursive(true).BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err)
	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	tests.CompareExpectedVsActual(expected, resultItems, t)
	readerCloseAndAssert(t, readerNoDate)
}

func isRepoExist(repoName string) bool {
	client, err := httpclient.ClientBuilder().Build()
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	resp, _, _, err := client.SendGet(serverDetails.ArtifactoryUrl+tests.RepoDetailsUrl+repoName, true, artHttpDetails, "")
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}

	if resp.StatusCode != http.StatusBadRequest {
		return true
	}
	return false
}

func getCliDotGitPath(t *testing.T) string {
	dotGitPath, err := os.Getwd()
	assert.NoError(t, err, "Failed to get current dir")
	dotGitExists, err := fileutils.IsDirExists(filepath.Join(dotGitPath, ".git"), false)
	assert.NoError(t, err)
	assert.True(t, dotGitExists, "Can't find .git")
	return dotGitPath
}

func deleteServerConfig(t *testing.T) {
	assert.NoError(t, configCli.WithoutCredentials().Exec("rm", tests.ServerId, "--quiet"))
}

// This function will create server config and return the entire passphrase flag if it needed.
// For example if passphrase is needed it will return "--ssh-passphrase=${theConfiguredPassphrase}" or empty string.
func createServerConfigAndReturnPassphrase(t *testing.T) (passphrase string, err error) {
	deleteServerConfig(t)
	if *tests.JfrogSshPassphrase != "" {
		passphrase = "--ssh-passphrase=" + *tests.JfrogSshPassphrase
	}
	return passphrase, configCli.Exec("add", tests.ServerId)
}

func testCopyMoveNoSpec(command string, beforeCommandExpected, afterCommandExpected []string, t *testing.T) {
	initArtifactoryTest(t, "")

	// Upload files
	specFileA, err := tests.CreateSpec(tests.SplitUploadSpecA)
	assert.NoError(t, err)
	specFileB, err := tests.CreateSpec(tests.SplitUploadSpecB)
	assert.NoError(t, err)

	runRt(t, "upload", "--spec="+specFileA)
	runRt(t, "upload", "--spec="+specFileB)

	// Run command with dry-run
	runRt(t, command, tests.RtRepo1+"/data/*a*", tests.RtRepo2+"/", "--dry-run")

	// Validate files weren't affected
	cpMvSpecFilePath, err := tests.CreateSpec(tests.CpMvDlByBuildAssertSpec)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(beforeCommandExpected, cpMvSpecFilePath, serverDetails, t)

	// Run command
	runRt(t, command, tests.RtRepo1+"/data/*a*", tests.RtRepo2+"/")

	// Validate files were affected
	inttestutils.VerifyExistInArtifactory(afterCommandExpected, cpMvSpecFilePath, serverDetails, t)

	// Cleanup
	cleanArtifactoryTest()
}

func searchItemsInArtifactory(t *testing.T, specSource string) []rtutils.ResultItem {
	fileSpec, err := tests.CreateSpec(specSource)
	assert.NoError(t, err)
	searchSpec, flags := getSpecAndCommonFlags(fileSpec)
	var resultItems []rtutils.ResultItem
	for i := 0; i < len(searchSpec.Files); i++ {
		searchParams, err := utils.GetSearchParams(searchSpec.Get(i))
		assert.NoError(t, err, "Failed Searching files")
		reader, err := services.SearchBySpecFiles(searchParams, flags, rtutils.ALL)
		assert.NoError(t, err, "Failed Searching files")
		for resultItem := new(rtutils.ResultItem); reader.NextRecord(resultItem) == nil; resultItem = new(rtutils.ResultItem) {
			resultItems = append(resultItems, *resultItem)
		}
		readerGetErrorAndAssert(t, reader)
		readerCloseAndAssert(t, reader)
	}
	return resultItems
}

func assertDateInSearchResult(searchResult utils.SearchResult) error {
	if searchResult.Created == "" || searchResult.Modified == "" {
		message, err := json.Marshal(&searchResult)
		if err != nil {
			return errors.New("failed to process search result to assert it includes date: " + err.Error())
		}
		return errors.New("search result does not include date: " + string(message))
	}
	return nil
}

func TestArtifactoryUploadInflatedPath(t *testing.T) {
	initArtifactoryTest(t, "")
	runRt(t, "upload", "testdata/a/../a/a1.*", tests.RtRepo1, "--flat=true")
	runRt(t, "upload", "testdata/./a/a1.*", tests.RtRepo1, "--flat=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpectedRepo1(), searchFilePath, serverDetails, t)

	runRt(t, "upload", "testdata/./a/../a/././././a2.*", tests.RtRepo1, "--flat=true")
	searchFilePath, err = tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpected2filesRepo1(), searchFilePath, serverDetails, t)
	if coreutils.IsWindows() {
		runRt(t, "upload", `testdata\\a\\..\\a\\a1.*`, tests.RtRepo2, "--flat=true")
		runRt(t, "upload", `testdata\\.\\\a\a1.*`, tests.RtRepo2, "--flat=true")
		searchFilePath, err = tests.CreateSpec(tests.SearchRepo2)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpectedRepo2(), searchFilePath, serverDetails, t)

		runRt(t, "upload", `testdata\\.\\a\\..\\a\\.\\.\\.\\.\\a2.*`, tests.RtRepo2, "--flat=true")
		searchFilePath, err = tests.CreateSpec(tests.SearchRepo2)
		assert.NoError(t, err)
		inttestutils.VerifyExistInArtifactory(tests.GetSimpleUploadSpecialCharNoRegexExpected2filesRepo2(), searchFilePath, serverDetails, t)
	}
	cleanArtifactoryTest()
}

func TestGetExtractorsRemoteDetails(t *testing.T) {
	initArtifactoryTest(t, "")
	_, err := createServerConfigAndReturnPassphrase(t)
	assert.NoError(t, err)
	defer deleteServerConfig(t)

	// Make sure extractor1.jar downloaded from releases.jfrog.io.
	downloadPath := "org/jfrog/buildinfo/build-info-extractor/extractor1.jar"
	expectedRemotePath := path.Join("oss-release-local", downloadPath)
	validateExtractorRemoteDetails(t, downloadPath, expectedRemotePath)

	// Make sure extractor2.jar also downloaded from releases.jfrog.io.
	downloadPath = "org/jfrog/buildinfo/build-info-extractor/extractor2.jar"
	expectedRemotePath = path.Join("oss-release-local", downloadPath)
	validateExtractorRemoteDetails(t, downloadPath, expectedRemotePath)

	// Set 'JFROG_CLI_EXTRACTORS_REMOTE' and make sure extractor3.jar downloaded from a remote repo 'test-remote-repo' in ServerId.
	testRemoteRepo := "test-remote-repo"
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.DeprecatedExtractorsRemoteEnv, tests.ServerId+"/"+testRemoteRepo)
	defer setEnvCallBack()
	downloadPath = "org/jfrog/buildinfo/build-info-extractor/extractor3.jar"
	expectedRemotePath = path.Join(testRemoteRepo, downloadPath)
	validateExtractorRemoteDetails(t, downloadPath, expectedRemotePath)

	cleanArtifactoryTest()
}

func validateExtractorRemoteDetails(t *testing.T, downloadPath, expectedRemotePath string) {
	serverDetails, remotePath, err := dependencies.GetExtractorsRemoteDetails(downloadPath)
	assert.NoError(t, err)
	assert.Equal(t, expectedRemotePath, remotePath)
	assert.False(t, os.Getenv(coreutils.DeprecatedExtractorsRemoteEnv) != "" && serverDetails == nil, "Expected a server to be returned")
}

func TestGetReleasesRemoteDetails(t *testing.T) {
	initArtifactoryTest(t, "")
	_, err := createServerConfigAndReturnPassphrase(t)
	assert.NoError(t, err)
	defer deleteServerConfig(t)

	// Set 'JFROG_CLI_RELEASES_REPO' and make sure extractor3.jar downloaded from a remote repo 'test-remote-repo' in ServerId.
	testRemoteRepo := "test-remote-repo"
	setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.ReleasesRemoteEnv, tests.ServerId+"/"+testRemoteRepo)
	defer setEnvCallBack()
	downloadPath := "org/jfrog/buildinfo/build-info-extractor/extractor3.jar"
	expectedRemotePath := path.Join(testRemoteRepo, "artifactory", "oss-release-local", downloadPath)
	validateReleasesRemoteDetails(t, downloadPath, expectedRemotePath)

	cleanArtifactoryTest()
}

func validateReleasesRemoteDetails(t *testing.T, downloadPath, expectedRemotePath string) {
	serverDetails, remotePath, err := dependencies.GetExtractorsRemoteDetails(downloadPath)
	assert.NoError(t, err)
	assert.Equal(t, expectedRemotePath, remotePath)
	assert.False(t, os.Getenv(coreutils.ReleasesRemoteEnv) != "" && serverDetails == nil, "Expected a server to be returned")
}

func TestVcsProps(t *testing.T) {
	initArtifactoryTest(t, "")
	defer inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
	testDir := initVcsTestDir(t)
	runRt(t, "upload", filepath.Join(testDir, "*"), tests.RtRepo1, "--flat=false", "--build-name="+tests.RtBuildName1, "--build-number=2020")
	resultItems := searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix)
	assert.NotZero(t, len(resultItems), "No artifacts were found.")
	for _, item := range resultItems {
		properties := item.Properties
		foundUrl, foundRevision := false, false
		for _, prop := range properties {
			if item.Name == "a1.in" || item.Name == "a2.in" {
				// Check that properties were not removed.
				if prop.Key == "vcs.url" && prop.Value == "https://github.com/jfrog/jfrog-cli.git" {
					assert.False(t, foundUrl, "Found duplicate VCS property(url) in artifact")
					foundUrl = true
				}
				if prop.Key == "vcs.revision" && prop.Value == "d63c5957ad6819f4c02a817abe757f210d35ff92" {
					assert.False(t, foundRevision, "Found duplicate VCS property(revision) in artifact")
					foundRevision = true
				}
			}
			if item.Name == "b1.in" || item.Name == "b2.in" {
				if prop.Key == "vcs.url" && prop.Value == "https://github.com/jfrog/jfrog-client-go.git" {
					assert.False(t, foundUrl, "Found duplicate VCS property(url) in artifact")
					foundUrl = true
				}
				if prop.Key == "vcs.revision" && prop.Value == "ad99b6c068283878fde4d49423728f0bdc00544a" {
					assert.False(t, foundRevision, "Found duplicate VCS property(revision) in artifact")
					foundRevision = true
				}
			}
		}
		assert.True(t, foundUrl && foundRevision, "VCS property was not found on artifact: "+item.Name)
	}
	cleanArtifactoryTest()
}

func initVcsTestDir(t *testing.T) string {
	testdataSrc := filepath.Join(filepath.FromSlash(tests.GetTestResourcesPath()), "vcs")
	testdataTarget := tests.Temp
	err := biutils.CopyDir(testdataSrc, testdataTarget, true, nil)
	assert.NoError(t, err)
	if found, err := fileutils.IsDirExists(filepath.Join(testdataTarget, "gitdata"), false); found {
		assert.NoError(t, err)
		coretests.RenamePath(filepath.Join(testdataTarget, "gitdata"), filepath.Join(testdataTarget, ".git"), t)
	}
	if found, err := fileutils.IsDirExists(filepath.Join(testdataTarget, "OtherGit", "gitdata"), false); found {
		assert.NoError(t, err)
		coretests.RenamePath(filepath.Join(testdataTarget, "OtherGit", "gitdata"), filepath.Join(testdataTarget, "OtherGit", ".git"), t)
	}
	dirPath, err := filepath.Abs(tests.Temp)
	assert.NoError(t, err)
	return dirPath
}

func TestConfigAddOverwrite(t *testing.T) {
	initArtifactoryTest(t, "")
	// Add a new instance.
	err := configCli.WithoutCredentials().Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin", "--password=password", "--enc-password=false")
	// Remove the instance at the end of the test.
	defer func() {
		assert.NoError(t, configCli.WithoutCredentials().Exec("rm", tests.ServerId, "--quiet"))
	}()
	// Expect no error, because the instance we created has a unique ID.
	assert.NoError(t, err)
	// Try creating an instance with the same ID, and expect to fail, because an instance with the
	// same ID already exists.
	err = configCli.WithoutCredentials().Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin", "--password=password", "--enc-password=false")
	assert.Error(t, err)
	// Now create it again, this time with the --overwrite option and expect no error.
	err = configCli.WithoutCredentials().Exec("add", tests.ServerId, "--overwrite", "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin2", "--password=password", "--enc-password=false")
	assert.NoError(t, err)
}

func TestConfigEncryption(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create temp jfrog home
	cleanUpJfrogHome, err := coretests.SetJfrogHome()
	assert.NoError(t, err)
	defer cleanUpJfrogHome()

	// Add a new instance
	assert.NoError(t, configCli.Exec("add", "server-1"))

	// Create encryption key
	assert.NoError(t, os.Setenv(coreutils.EncryptionKey, "ChewbaccaIsMyCoPilotLOLROFLBBQ20"))
	defer func() {
		assert.NoError(t, os.Unsetenv(coreutils.EncryptionKey))
	}()

	// Add another instance
	assert.NoError(t, configCli.Exec("add", "server-2"))

	// Expect no error after reading it
	assert.NoError(t, coretests.NewJfrogCli(execMain, "jfrog config", "").Exec("show"))
	assert.NoError(t, coretests.NewJfrogCli(execMain, "jfrog rt", "--server-id=server-1").Exec("ping"))
	assert.NoError(t, coretests.NewJfrogCli(execMain, "jfrog rt", "--server-id=server-2").Exec("ping"))
}

func TestConfigEncryptionMissingKey(t *testing.T) {
	initArtifactoryTest(t, "")

	// Create temp jfrog home
	cleanUpJfrogHome, err := coretests.SetJfrogHome()
	assert.NoError(t, err)
	defer cleanUpJfrogHome()

	// Create encryption key
	assert.NoError(t, os.Setenv(coreutils.EncryptionKey, "ChewbaccaIsMyCoPilotLOLROFLBBQ20"))
	defer func() {
		assert.NoError(t, os.Unsetenv(coreutils.EncryptionKey))
	}()

	// Add a new instance
	assert.NoError(t, configCli.Exec("add", "encryption-server-id"))

	// Expect ping success

	assert.NoError(t, artifactoryCli.WithoutCredentials().Exec("ping", "--server-id=encryption-server-id"))

	// Unset JFROG_CLI_ENCRYPTION_KEY environment variable
	assert.NoError(t, os.Unsetenv(coreutils.EncryptionKey))
	err = artifactoryCli.WithoutCredentials().Exec("ping", "--server-id=encryption-server-id")
	assert.ErrorContains(t, err, "cannot decrypt config")
}

func TestConfigAddWithStdinPassword(t *testing.T) {
	initArtifactoryTest(t, "")

	// Try running both password and password-stdin flag and expect error
	err := configCli.WithoutCredentials().Exec("add", tests.ServerId, "--password=password", "--password-stdin")
	assert.Error(t, err)

	// Add password to Stdin pipe
	revertStdin := pipeStdinSecret(t, "password")
	defer revertStdin()
	// Run config add with password via stdin
	err = configCli.WithoutCredentials().Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin", "--password-stdin", "--enc-password=false")
	// Expect no error, because the instance we created has a unique ID.
	assert.NoError(t, err)
	// Remove the instance at the end of the test.
	defer func() {
		assert.NoError(t, configCli.WithoutCredentials().Exec("rm", tests.ServerId, "--quiet"))
	}()

	details, err := config.GetSpecificConfig(tests.ServerId, false, false)
	assert.NoError(t, err)
	assert.Equal(t, "password", details.Password)
}

func TestConfigAddWithStdinAccessToken(t *testing.T) {
	initArtifactoryTest(t, "")

	// Try running both password and password-stdin flag and expect error
	err := configCli.WithoutCredentials().Exec("add", tests.ServerId, "--access-token=password", "--access-token-stdin")
	assert.Error(t, err)

	// Add password to Stdin pipe
	revertStdin := pipeStdinSecret(t, "accesstoken")
	defer revertStdin()
	// Run config add with password via stdin
	err = configCli.WithoutCredentials().Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin", "--access-token-stdin")
	// Expect no error, because the instance we created has a unique ID.
	assert.NoError(t, err)
	// Remove the instance at the end of the test.
	defer func() {
		assert.NoError(t, configCli.WithoutCredentials().Exec("rm", tests.ServerId, "--quiet"))
	}()

	details, err := config.GetSpecificConfig(tests.ServerId, false, false)
	assert.NoError(t, err)
	assert.Equal(t, "accesstoken", details.AccessToken)
	assert.Equal(t, false, details.DisableTokenRefresh)
}

func TestConfigAddWithDisableRefreshToken(t *testing.T) {
	initArtifactoryTest(t, "")

	err := configCli.WithoutCredentials().Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.
		ArtifactoryEndpoint, "--access-token=password", "--disable-token-refresh=true")
	assert.NoError(t, err)

	defer func() {
		assert.NoError(t, configCli.WithoutCredentials().Exec("rm", tests.ServerId, "--quiet"))
	}()

	details, err := config.GetSpecificConfig(tests.ServerId, false, false)
	assert.NoError(t, err)
	assert.Equal(t, "password", details.AccessToken)
	assert.Equal(t, true, details.DisableTokenRefresh)
}

func pipeStdinSecret(t *testing.T, secret string) func() {
	password := []byte(secret)
	pipe, w, err := os.Pipe()
	assert.NoError(t, err)
	_, err = w.Write(password)
	assert.NoError(t, err)
	assert.NoError(t, w.Close())
	// Restore stdin right after the test.
	prevStdin := os.Stdin
	os.Stdin = pipe
	return func() { os.Stdin = prevStdin }
}

func TestArtifactoryReplicationCreate(t *testing.T) {
	initArtifactoryTest(t, "")
	// Configure server with dummy credentials
	err := coretests.NewJfrogCli(execMain, "jfrog config", "").Exec("add", tests.ServerId, "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--user=admin", "--password=password", "--enc-password=false")
	defer deleteServerConfig(t)
	assert.NoError(t, err)

	// Init tmp dir
	templatePath := filepath.Join(tests.GetTestResourcesPath(), tests.ReplicationTempCreate)
	templatePath, err = tests.ReplaceTemplateVariables(templatePath, "")
	assert.NoError(t, err)

	// Create push replication
	runRt(t, "rplc", templatePath)

	// Validate create replication
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	assert.NoError(t, err)
	result, err := servicesManager.GetReplication(tests.RtRepo1)
	assert.NoError(t, err)
	// The Replicator may encrypt the password internally, therefore we should only check that the password is not empty
	assert.NotEmpty(t, result[0].Password)
	result[0].Password = ""
	assert.ElementsMatch(t, result, tests.GetReplicationConfig())

	// Delete replication
	runRt(t, "rpldel", tests.RtRepo1)

	// Validate delete replication
	_, err = servicesManager.GetReplication(tests.RtRepo1)
	assert.Error(t, err)
	// Cleanup
	cleanArtifactoryTest()
}

func TestArtifactoryAccessTokenCreate(t *testing.T) {
	initArtifactoryTest(t, "")

	buffer, _, previousLog := coretests.RedirectLogOutputToBuffer()
	// Restore previous logger when the function returns
	defer log.SetLogger(previousLog)

	// Create access token for current user, implicitly
	if *tests.JfrogAccessToken != "" {
		// Use Artifactory CLI with basic auth to allow running `jfrog rt atc` without arguments
		origAccessToken := *tests.JfrogAccessToken
		origUsername, origPassword := tests.SetBasicAuthFromAccessToken()
		defer func() {
			*tests.JfrogUser = origUsername
			*tests.JfrogPassword = origPassword
			*tests.JfrogAccessToken = origAccessToken
		}()
		*tests.JfrogAccessToken = ""
		err := coretests.NewJfrogCli(execMain, "jfrog rt", authenticate(false)).Exec("atc")
		assert.NoError(t, err)
	} else {
		runRt(t, "atc")
	}

	// Check access token
	checkAccessToken(t, buffer)

	// Create access token for current user, explicitly
	runRt(t, "atc", *tests.JfrogUser)

	// Check access token
	checkAccessToken(t, buffer)

	// Cleanup
	cleanArtifactoryTest()
}

func checkAccessToken(t *testing.T, buffer *bytes.Buffer) {
	// Write the command output to the origin
	output := buffer.Bytes()
	buffer.Reset()

	// Extract the token from the output
	token, err := jsonparser.GetString(output, "access_token")
	assert.NoError(t, err)

	// Try ping with the new token
	err = coretests.NewJfrogCli(execMain, "jfrog rt", "--url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint+" --access-token="+token).Exec("ping")
	assert.NoError(t, err)
}

func TestRefreshableArtifactoryTokens(t *testing.T) {
	initArtifactoryTest(t, "")

	if *tests.JfrogAccessToken != "" {
		t.Skip("Test only with username and password , skipping...")
	}

	// Create server with initialized refreshable tokens.
	_, err := createServerConfigAndReturnPassphrase(t)
	defer deleteServerConfig(t)
	assert.NoError(t, err)

	// Upload a file and assert the refreshable tokens were generated.
	artifactoryCommandExecutor := coretests.NewJfrogCli(execMain, "jfrog rt", "")
	uploadedFiles := 1
	err = uploadWithSpecificServerAndVerify(t, artifactoryCommandExecutor, "testdata/a/a1.in", uploadedFiles)
	if err != nil {
		return
	}
	curAccessToken, curRefreshToken, curArtifactoryRefreshToken, err := getTokensFromConfig(t)
	if err != nil {
		return
	}
	assert.NotEmpty(t, curAccessToken)
	assert.NotEmpty(t, curArtifactoryRefreshToken)
	assert.Empty(t, curRefreshToken)

	// Make the token always refresh.
	auth.RefreshArtifactoryTokenBeforeExpiryMinutes = 60

	// Upload a file and assert tokens were refreshed.
	uploadedFiles++
	err = uploadWithSpecificServerAndVerify(t, artifactoryCommandExecutor, "testdata/a/a2.in", uploadedFiles)
	if err != nil {
		return
	}
	curAccessToken, curArtifactoryRefreshToken, err = assertArtifactoryTokensChanged(t, curAccessToken, curArtifactoryRefreshToken)
	if err != nil {
		return
	}

	// Make refresh token invalid. Refreshing using tokens should fail, so new tokens should be generated using credentials.
	err = setArtifactoryRefreshTokenInConfig(t, tests.ServerId, "invalid-token")
	if err != nil {
		return
	}
	uploadedFiles++
	err = uploadWithSpecificServerAndVerify(t, artifactoryCommandExecutor, "testdata/a/a3.in", uploadedFiles)
	if err != nil {
		return
	}
	curAccessToken, curArtifactoryRefreshToken, err = assertArtifactoryTokensChanged(t, curAccessToken, curArtifactoryRefreshToken)
	if err != nil {
		return
	}

	// Make password invalid. Refreshing should succeed, and new token should be obtained.
	err = setPasswordInConfig(t, tests.ServerId, "invalid-pass")
	if err != nil {
		return
	}
	uploadedFiles++
	err = uploadWithSpecificServerAndVerify(t, artifactoryCommandExecutor, "testdata/a/b/b1.in", uploadedFiles)
	if err != nil {
		return
	}
	curAccessToken, curArtifactoryRefreshToken, err = assertArtifactoryTokensChanged(t, curAccessToken, curArtifactoryRefreshToken)
	if err != nil {
		return
	}

	// Make the token not refresh. Verify Tokens did not refresh.
	auth.RefreshArtifactoryTokenBeforeExpiryMinutes = 0
	uploadedFiles++
	err = uploadWithSpecificServerAndVerify(t, artifactoryCommandExecutor, "testdata/a/b/b2.in", uploadedFiles)
	if err != nil {
		return
	}
	newAccessToken, newRefreshToken, newArtifactoryRefreshToken, err := getTokensFromConfig(t)
	if err != nil {
		return
	}
	assert.Equal(t, curAccessToken, newAccessToken)
	assert.Equal(t, curArtifactoryRefreshToken, newArtifactoryRefreshToken)
	assert.Empty(t, newRefreshToken)

	// Cleanup
	cleanArtifactoryTest()
}

func setArtifactoryRefreshTokenInConfig(t *testing.T, serverId, token string) error {
	details, err := config.GetAllServersConfigs()
	if err != nil {
		assert.NoError(t, err)
		return err
	}
	for _, server := range details {
		if server.ServerId == serverId {
			server.SetArtifactoryRefreshToken(token)
		}
	}
	assert.NoError(t, config.SaveServersConf(details))
	return nil
}

func setPasswordInConfig(t *testing.T, serverId, password string) error {
	details, err := config.GetAllServersConfigs()
	if err != nil {
		assert.NoError(t, err)
		return err
	}
	for _, server := range details {
		if server.ServerId == serverId {
			server.SetPassword(password)
		}
	}
	assert.NoError(t, config.SaveServersConf(details))
	return nil
}

func getTokensFromConfig(t *testing.T) (accessToken, refreshToken, artifactoryRefreshToken string, err error) {
	details, err := config.GetSpecificConfig(tests.ServerId, false, false)
	if err != nil {
		assert.NoError(t, err)
		return "", "", "", err
	}
	return details.AccessToken, details.RefreshToken, details.ArtifactoryRefreshToken, nil
}

// After refreshing an Artifactory access token, assert that the access token and the artifactory refresh token were changed, and refresh token remained empty.
func assertArtifactoryTokensChanged(t *testing.T, curAccessToken, curArtifactoryRefreshToken string) (newAccessToken, newArtifactoryRefreshToken string, err error) {
	var newRefreshToken string
	newAccessToken, newRefreshToken, newArtifactoryRefreshToken, err = getTokensFromConfig(t)
	if err != nil {
		assert.NoError(t, err)
		return "", "", err
	}
	assert.NotEqual(t, curAccessToken, newAccessToken)
	assert.NotEqual(t, curArtifactoryRefreshToken, newArtifactoryRefreshToken)
	assert.Empty(t, newRefreshToken)
	return newAccessToken, newArtifactoryRefreshToken, nil
}

func uploadWithSpecificServerAndVerify(t *testing.T, cli *coretests.JfrogCli, source string, expectedResults int) error {
	err := cli.Exec("upload", source, tests.RtRepo1, "--server-id="+tests.ServerId)
	if err != nil {
		assert.NoError(t, err)
		return err
	}
	assert.Len(t, searchItemsInArtifactory(t, tests.SearchRepo1ByInSuffix), expectedResults)
	return nil
}

func TestArtifactorySimpleUploadAntPattern(t *testing.T) {
	initArtifactoryTest(t, "")

	// --ant and --regexp together: should get an error
	uploadUsingAntAndRegexpTogether(t)
	// Upload empty dir
	uploadUsingAntAIncludeDirsAndFlat(t)
	// Simple uploads
	simpleUploadAntIsTrueRegexpIsFalse(t)
	simpleUploadWithAntPatternSpec(t)

	cleanArtifactoryTest()
}

func uploadUsingAntAndRegexpTogether(t *testing.T) {
	filePath := getAntPatternFilePath()
	err := artifactoryCli.Exec("upload", filePath, tests.RtRepo1, "--regexp", "--ant", "--flat=true")
	assert.Error(t, err)
}

func simpleUploadAntIsTrueRegexpIsFalse(t *testing.T) {
	filePath := getAntPatternFilePath()
	runRt(t, "upload", filePath, tests.RtRepo1, "--ant", "--regexp=false", "--flat=true")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleAntPatternUploadExpectedRepo1(), searchFilePath, serverDetails, t)
}

func simpleUploadWithAntPatternSpec(t *testing.T) {
	// Init tmp dir
	specFile, err := tests.CreateSpec(tests.UploadAntPattern)
	assert.NoError(t, err)
	err = biutils.CopyDir(tests.GetTestResourcesPath()+"cache", filepath.Dir(specFile), true, nil)
	assert.NoError(t, err)
	// Upload
	runRt(t, "upload", "--spec="+specFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetSimpleAntPatternUploadExpectedRepo1(), searchFilePath, serverDetails, t)
	searchFilePath, err = tests.CreateSpec(tests.SearchRepo1NonExistFile)
	assert.NoError(t, err)
	verifyDoesntExistInArtifactory(searchFilePath, t)
}

func uploadUsingAntAIncludeDirsAndFlat(t *testing.T) {
	filePath := "testdata/*/empt?/**"
	runRt(t, "upload", filePath, tests.RtRepo1, "--ant", "--include-dirs=true", "--flat=true")
	runRt(t, "upload", filePath, tests.RtRepo1, "--ant", "--include-dirs=true", "--flat=false")
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1IncludeDirs)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAntPatternUploadWithIncludeDirsExpectedRepo1(), searchFilePath, serverDetails, t)
}

func TestUploadWithAntPatternAndExclusionsSpec(t *testing.T) {
	initArtifactoryTest(t, "")
	// Init tmp dir
	specFile, err := tests.CreateSpec(tests.UploadAntPatternExclusions)
	assert.NoError(t, err)
	err = biutils.CopyDir(tests.GetTestResourcesPath(), filepath.Dir(specFile), true, nil)
	assert.NoError(t, err)
	// Upload
	runRt(t, "upload", "--spec="+specFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAntPatternUploadWithExclusionsExpectedRepo1(), searchFilePath, serverDetails, t)
	searchFilePath, err = tests.CreateSpec(tests.SearchRepo1NonExistFileAntExclusions)
	assert.NoError(t, err)
	verifyDoesntExistInArtifactory(searchFilePath, t)
	cleanArtifactoryTest()
}

func TestUploadWithAntPatternAndPlaceholders(t *testing.T) {
	initArtifactoryTest(t, "")
	// Init tmp dir
	specFile, err := tests.CreateSpec(tests.UploadAntPatternExclusions)
	assert.NoError(t, err)
	err = biutils.CopyDir(tests.GetTestResourcesPath(), filepath.Dir(specFile), true, nil)
	assert.NoError(t, err)
	// Upload
	runRt(t, "upload", "--spec="+specFile)
	searchFilePath, err := tests.CreateSpec(tests.SearchRepo1ByInSuffix)
	assert.NoError(t, err)
	inttestutils.VerifyExistInArtifactory(tests.GetAntPatternUploadWithExclusionsExpectedRepo1(), searchFilePath, serverDetails, t)
	searchFilePath, err = tests.CreateSpec(tests.SearchRepo1NonExistFileAntExclusions)
	assert.NoError(t, err)
	verifyDoesntExistInArtifactory(searchFilePath, t)
	cleanArtifactoryTest()
}

func TestPermissionTargets(t *testing.T) {
	initArtifactoryTest(t, "")
	servicesManager, err := utils.CreateServiceManager(serverDetails, -1, 0, false)
	if err != nil {
		assert.NoError(t, err)
		return
	}
	templatePath := filepath.Join(tests.GetTestResourcesPath(), "permissiontarget", "template")

	// Create permission target on specific repo.
	runRt(t, "ptc", templatePath, createPermissionTargetsTemplateVars(tests.RtRepo1))
	assertPermissionTarget(t, servicesManager, tests.RtRepo1)

	// Update permission target to ANY repo.
	anyRepo := "ANY"
	runRt(t, "ptu", templatePath, createPermissionTargetsTemplateVars(anyRepo))
	assertPermissionTarget(t, servicesManager, anyRepo)

	// Delete permission target.
	runRt(t, "ptdel", tests.RtPermissionTargetName)
	assertPermissionTargetDeleted(t, servicesManager)

	cleanArtifactoryTest()
}

func createPermissionTargetsTemplateVars(reposValue string) string {
	ptNameVarKey := "pt_name"
	reposVarKey := "repos_var"
	return fmt.Sprintf("--vars=%s=%s;%s=%s", ptNameVarKey, tests.RtPermissionTargetName, reposVarKey, reposValue)
}

func assertPermissionTarget(t *testing.T, manager artifactory.ArtifactoryServicesManager, repoValue string) {
	actual, err := manager.GetPermissionTarget(tests.RtPermissionTargetName)
	if err != nil {
		assert.NoError(t, err)
		return
	}
	if actual == nil {
		assert.NotNil(t, actual)
		return
	}
	expected := tests.GetExpectedPermissionTarget(repoValue)
	assert.EqualValues(t, expected, *actual)
}

func assertPermissionTargetDeleted(t *testing.T, manager artifactory.ArtifactoryServicesManager) {
	permission, err := manager.GetPermissionTarget(tests.RtPermissionTargetName)
	assert.NoError(t, err)
	assert.Nil(t, permission)
}

func TestArtifactoryCurl(t *testing.T) {
	initArtifactoryTest(t, "")
	_, err := createServerConfigAndReturnPassphrase(t)
	defer deleteServerConfig(t)
	assert.NoError(t, err)

	baseArgs := []string{"curl", "-XGET", "/api/system/version"}

	testRuns := []struct {
		testName         string
		serverIDEnvValue string
		expectedErr      bool
		serverID         string
	}{
		{"defaultConfig", "", false, ""},
		{"serverIdFlag", "", false, tests.ServerId},
		{"invalidServerId", "", true, "not_configured_name_" + tests.ServerId},
		{"envVarSet", tests.ServerId, false, ""},
		{"envVarWithFlag", tests.ServerId, false, tests.ServerId},
		{"priorityFlagOverEnv", "wrong_server_id", false, tests.ServerId},
		{"priorityEnvOverDefault", tests.ServerId, false, ""},
	}

	for _, test := range testRuns {
		t.Run(test.testName, func(t *testing.T) {
			setEnvCallBack := clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.ServerID, test.serverIDEnvValue)

			args := append([]string{}, baseArgs...)
			if test.serverID != "" {
				args = append(args, "--server-id="+test.serverID)
			}
			err = artifactoryCli.WithoutCredentials().Exec(args...)
			if test.expectedErr {
				assert.Error(t, err)
			} else {
				assert.NoError(t, err)
			}
			setEnvCallBack()
		})
	}

	cleanArtifactoryTest()
}

func deleteProjectIfExists(t *testing.T, accessManager *access.AccessServicesManager, projectKey string) {
	err := accessManager.DeleteProject(projectKey)
	if err != nil {
		if !strings.Contains(err.Error(), "Could not find project") {
			t.Error(err)
		}
	}
}

func readerCloseAndAssert(t *testing.T, reader *content.ContentReader) {
	assert.NoError(t, reader.Close(), "Couldn't close reader")
}

func readerGetErrorAndAssert(t *testing.T, reader *content.ContentReader) {
	assert.NoError(t, reader.GetError(), "Couldn't get reader error")
}

func TestTerraformPublish(t *testing.T) {
	testTerraformPublish(t, false)
}

func TestTerraformPublishWithBuildInfo(t *testing.T) {
	testTerraformPublish(t, true)
}

func testTerraformPublish(t *testing.T, buildInfo bool) {
	initArtifactoryTest(t, terraformMinArtifactoryVersion)
	defer cleanArtifactoryTest()
	createJfrogHomeConfig(t, true)
	projectPath := prepareTerraformProject("terraformproject", t, true)
	// Change working directory to be the project's local root.
	wd, err := os.Getwd()
	assert.NoError(t, err)
	chdirCallback := clientTestUtils.ChangeDirWithCallback(t, wd, filepath.Join(projectPath, "aws"))
	defer chdirCallback()

	trPublishArgs := []string{"terraform", "publish", "--namespace=namespace", "--provider=provider", "--tag=tag", "--exclusions=*test*"}
	if !buildInfo {
		assert.NoError(t, platformCli.WithoutCredentials().Exec(trPublishArgs...))
	} else {
		terraformPublishModulesAndBuildInfo(t, trPublishArgs)
	}

	// Download modules to 'result' directory.
	chdirCallback()
	assert.NoError(t, os.MkdirAll(tests.Out+"/results/", 0777))
	// Verify terraform modules have been uploaded to artifactory correctly.
	verifyModuleInArtifactoryWithRetry(t)
}

func terraformPublishModulesAndBuildInfo(t *testing.T, trPublishArgs []string) {
	buildNumber := "42"
	moduleName := "my-tr-module"
	trPublishArgs = append(trPublishArgs, []string{"--build-name=" + tests.RtBuildName1, "--build-number=" + buildNumber, "--module=" + moduleName}...)
	assert.NoError(t, platformCli.WithoutCredentials().Exec(trPublishArgs...))

	assert.NoError(t, artifactoryCli.Exec("bp", tests.RtBuildName1, buildNumber))

	publishedBuildInfo, found, err := tests.GetBuildInfo(serverDetails, tests.RtBuildName1, buildNumber)
	if !assert.NoError(t, err) {
		return
	}
	if !assert.True(t, found, "build info was expected to be found") {
		return
	}
	buildInfo := publishedBuildInfo.BuildInfo
	if !assert.Len(t, buildInfo.Modules, 1) {
		return
	}
	assert.Equal(t, moduleName, buildInfo.Modules[0].Id)
	assert.Len(t, buildInfo.Modules[0].Artifacts, 3)
}

func prepareTerraformProject(projectName string, t *testing.T, copyDirs bool) string {
	projectPath := filepath.Join(tests.GetTestResourcesPath(), "terraform", projectName)
	testdataTarget := filepath.Join(tests.Out, "terraformProject")
	assert.NoError(t, os.MkdirAll(testdataTarget+string(os.PathSeparator), 0777))
	// Copy terraform tests to test environment, so we can change project's config file.
	assert.NoError(t, biutils.CopyDir(projectPath, testdataTarget, copyDirs, nil))
	configFileDir := filepath.Join(filepath.FromSlash(testdataTarget), ".jfrog", "projects")
	_, err := tests.ReplaceTemplateVariables(filepath.Join(configFileDir, "terraform.yaml"), configFileDir)
	assert.NoError(t, err)
	return testdataTarget
}

func verifyModuleInArtifactoryWithRetry(t *testing.T) {
	retryExecutor := &clientutils.RetryExecutor{
		MaxRetries: 5,
		// RetriesIntervalMilliSecs in milliseconds
		RetriesIntervalMilliSecs: 1000,
		ErrorMessage:             "Waiting for Artifactory to create \"module.json\" files for terraform modules....",
		ExecutionHandler:         downloadModuleAndVerify(),
	}
	err := retryExecutor.Execute()
	assert.NoError(t, err)
}

func downloadModuleAndVerify() clientutils.ExecutionHandlerFunc {
	return func() (shouldRetry bool, err error) {
		err = artifactoryCli.Exec("download", tests.TerraformRepo+"/namespace/*", tests.Out+"/results/", "--explode=true")
		if err != nil {
			return false, err
		}
		// Validate
		paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(filepath.Join(tests.Out, "results"), false)
		if err != nil {
			return false, err
		}
		// After uploading terraform module to Artifactory the indexing is async.
		// It could take some time for "module.json" files to be created by artifactory - that's why we should try downloading again in case comparison has failed.
		err = tests.ValidateListsIdentical(tests.GetTerraformModulesFilesDownload(), paths)
		if err != nil {
			return true, err
		}
		return false, nil
	}
}

func sendArtifactoryTrustedPublicKey(t *testing.T, artHttpDetails httputils.HttpClientDetails) {
	// Send trusted public key to Artifactory
	publicKeyPath := filepath.Join(tests.GetTestResourcesPath(), "lifecycle", "keys", "public.txt")
	publicKey, err := os.ReadFile(publicKeyPath)
	assert.NoError(t, err)
	client, err := httpclient.ClientBuilder().Build()
	assert.NoError(t, err)
	requestBody := fmt.Sprintf(inttestutils.ArtifactoryGpgKeyCreatePattern, publicKey)
	_, _, err = client.SendPost(*tests.JfrogUrl+"artifactory/api/security/keys/trusted", []byte(requestBody), artHttpDetails, "")
	assert.NoError(t, err)
}

func deleteReceivedReleaseBundle(t *testing.T, url, bundleName, bundleVersion string) {
	client, err := httpclient.ClientBuilder().Build()
	assert.NoError(t, err)
	deleteApi := path.Join(url, bundleName, bundleVersion)
	_, _, err = client.SendDelete(*tests.JfrogUrl+deleteApi, []byte{}, artHttpDetails, "Deleting release bundle")
	assert.NoError(t, err)
}

var buildAqlSearchQueryDataProvider = []struct {
	pattern     string
	recursive   bool
	expectedAql string
}{
	{"**/a-.*.tar.gz", false, `{"$or":[{"$and":[{"path":{"$match":"**"},"name":{"$match":"a-.*.tar.gz"}}]},{"$and":[{"path":".","name":{"$match":"*a-.*.tar.gz"}}]}]}`},
}

// TestArtifactorySearchByPattern is an integration test that validates search pattern functionality
// by creating test repositories, uploading files, and verifying that searches return correct results.
// This test validates the unit test functionality of CreateAqlBodyForSpecWithPattern.
func TestArtifactorySearchByPattern(t *testing.T) {
	initArtifactoryCli()
	initArtifactoryTest(t, "")
	defer cleanArtifactoryTest()
	testRepos := []string{"repo-local", "repo-wildcard", "repo-local2", "repo-local3"}
	for _, repoName := range testRepos {
		if !isRepoExist(repoName) {
			repoConfig := fmt.Sprintf(`{"key":"%s","rclass":"local","packageType":"generic"}`, repoName)
			execCreateRepoRestFromString(repoConfig, repoName)
		} else {
			runRt(t, "delete", repoName+"/*", "--quiet")
		}
	}
	setupTestFilesForSearchPatterns(t)
	defer cleanupTestFilesForSearchPatterns(t)
	for _, searchSample := range buildAqlSearchQueryDataProvider {
		testName := fmt.Sprintf("Pattern_%s_Recursive_%s",
			strings.ReplaceAll(strings.ReplaceAll(searchSample.pattern, "/", "_"), "*", "star"),
			strconv.FormatBool(searchSample.recursive))
		t.Run(testName, func(t *testing.T) {
			args := []string{"search", searchSample.pattern}
			if searchSample.recursive {
				args = append(args, "--recursive")
			}
			err := artifactoryCli.Exec(args...)
			assert.NoError(t, err, "Search command should execute successfully for pattern: %s", searchSample.pattern)
			validateSearchPatternWithAPI(t, searchSample.pattern, searchSample.recursive)
		})
	}
}

// setupTestFilesForSearchPatterns uploads test files to match the search patterns
func setupTestFilesForSearchPatterns(t *testing.T) {
	tmpFile, err := os.CreateTemp("", "test-file-*.txt")
	assert.NoError(t, err)
	defer func(name string) {
		_ = os.Remove(name) //#nosec G703 -- test code, path from temp file
	}(tmpFile.Name())
	_, err = tmpFile.WriteString("test content")
	if err != nil {
		return
	}
	err = tmpFile.Close()
	if err != nil {
		return
	}
	runRt(t, "upload", tmpFile.Name(), "repo-local/test-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local/subdir/nested-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-wildcard/test-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local2/a1b2c3/dd/test-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local2/a1b2c3/dd/subdir/nested-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local2/other-path/test-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local3/a1b2c3/dd/test-file.txt")
	runRt(t, "upload", tmpFile.Name(), "repo-local/path/to/a-1.2.3.tar.gz")
	runRt(t, "upload", tmpFile.Name(), "repo-local/a-2.3.4.tar.gz")
}

// cleanupTestFilesForSearchPatterns removes test files uploaded during the test
func cleanupTestFilesForSearchPatterns(t *testing.T) {
	testRepos := []string{"repo-local", "repo-wildcard", "repo-local2", "repo-local3"}
	for _, repoName := range testRepos {
		if isRepoExist(repoName) {
			runRt(t, "delete", repoName+"/*", "--quiet")
		}
	}
}

// execCreateRepoRestFromString creates a repository from a JSON string
func execCreateRepoRestFromString(repoConfig, repoName string) {
	rtutils.AddHeader("Content-Type", "application/json", &artHttpDetails.Headers)
	client, err := httpclient.ClientBuilder().Build()
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	resp, body, err := client.SendPut(serverDetails.ArtifactoryUrl+"api/repositories/"+repoName, []byte(repoConfig), artHttpDetails, "")
	if err != nil {
		log.Error(err)
		os.Exit(1)
	}
	if err = errorutils.CheckResponseStatusWithBody(resp, body, http.StatusOK, http.StatusCreated); err != nil {
		log.Error(err)
		os.Exit(1)
	}
	log.Info("Repository", repoName, "created.")
}

// validateSearchPatternWithAPI validates the search pattern using the search API directly
func validateSearchPatternWithAPI(t *testing.T, pattern string, recursive bool) {
	searchSpec := spec.NewBuilder().Pattern(pattern).Recursive(recursive).BuildSpec()
	searchCmd := generic.NewSearchCommand()
	searchCmd.SetServerDetails(serverDetails).SetSpec(searchSpec)
	reader, err := searchCmd.Search()
	assert.NoError(t, err, "Search API should work for pattern: %s", pattern)
	var resultItems []utils.SearchResult
	readerNoDate, err := utils.SearchResultNoDate(reader)
	assert.NoError(t, err)
	for resultItem := new(utils.SearchResult); readerNoDate.NextRecord(resultItem) == nil; resultItem = new(utils.SearchResult) {
		resultItems = append(resultItems, *resultItem)
	}
	if strings.HasPrefix(pattern, "repo-local") && !strings.Contains(pattern, "*repo-local") {
		assert.True(t, len(resultItems) > 0, "Pattern %s should return results", pattern)
	}
	readerGetErrorAndAssert(t, readerNoDate)
	readerCloseAndAssert(t, readerNoDate)
}

// TestUploadMultipleFilesWithCIVcsProps tests that CI VCS properties are set on multiple uploaded files.
// This test:
// - Creates 15 files dynamically during the test
// - Uploads all files using jf rt u
// - Verifies vcs.provider, vcs.org, vcs.repo properties are set on ALL 15 files
// - Fails if any property is missing on any file
func TestUploadMultipleFilesWithCIVcsProps(t *testing.T) {
	initArtifactoryTest(t, "")
	const numFiles = 15

	// Setup GitHub Actions environment (uses real env vars on CI, mock values locally)
	cleanupEnv, actualOrg, actualRepo := tests.SetupGitHubActionsEnv(t)
	defer cleanupEnv()

	// Create temp directory for test files
	tmpDir, createTempDirCallback := coretests.CreateTempDirWithCallbackAndAssert(t)
	defer createTempDirCallback()

	// Create 15 files dynamically
	var createdFiles []string
	for i := 1; i <= numFiles; i++ {
		fileName := fmt.Sprintf("civcs-test-file-%d.txt", i)
		filePath := filepath.Join(tmpDir, fileName)
		content := fmt.Sprintf("Test file %d for CI VCS properties verification. Timestamp: %d", i, time.Now().UnixNano())
		err := os.WriteFile(filePath, []byte(content), 0644)
		require.NoError(t, err, "Failed to create test file: %s", fileName)
		createdFiles = append(createdFiles, fileName)
	}

	// Upload all files to Artifactory
	uploadPattern := filepath.Join(tmpDir, "civcs-test-file-*.txt")
	targetPath := tests.RtRepo1 + "/civcs-multi-upload/"
	runRt(t, "upload", uploadPattern, targetPath, "--flat")

	// Create service manager for getting artifact properties
	serviceManager, err := utils.CreateServiceManager(serverDetails, 3, 1000, false)
	require.NoError(t, err, "Failed to create service manager")

	// Verify CI VCS properties on each uploaded file
	validatedCount := 0
	for _, fileName := range createdFiles {
		fullPath := tests.RtRepo1 + "/civcs-multi-upload/" + fileName

		props, err := serviceManager.GetItemProps(fullPath)
		require.NoError(t, err, "Failed to get properties for file: %s", fullPath)
		require.NotNil(t, props, "Properties are nil for file: %s", fullPath)

		// Validate vcs.provider property
		require.Contains(t, props.Properties, "vcs.provider",
			"Missing vcs.provider property on file: %s", fileName)
		require.Contains(t, props.Properties["vcs.provider"], "github",
			"Wrong vcs.provider value on file: %s. Expected 'github', got: %v", fileName, props.Properties["vcs.provider"])

		// Validate vcs.org property
		require.Contains(t, props.Properties, "vcs.org",
			"Missing vcs.org property on file: %s", fileName)
		require.Contains(t, props.Properties["vcs.org"], actualOrg,
			"Wrong vcs.org value on file: %s. Expected '%s', got: %v", fileName, actualOrg, props.Properties["vcs.org"])

		// Validate vcs.repo property
		require.Contains(t, props.Properties, "vcs.repo",
			"Missing vcs.repo property on file: %s", fileName)
		require.Contains(t, props.Properties["vcs.repo"], actualRepo,
			"Wrong vcs.repo value on file: %s. Expected '%s', got: %v", fileName, actualRepo, props.Properties["vcs.repo"])

		validatedCount++
	}

	// Ensure we validated exactly the expected number of files
	require.Equal(t, numFiles, validatedCount,
		"Expected to validate %d files, but validated %d", numFiles, validatedCount)

	t.Logf("Successfully validated CI VCS properties on all %d files", validatedCount)

	cleanArtifactoryTest()
}