Skip to content

Commit 3fc7b4b

Browse files
Roland Dreiertorvalds
authored andcommitted
lib: export generic atomic64_t functions
The generic atomic64_t implementation in lib/ did not export the functions it defined, which means that modules that use atomic64_t would not link on platforms (such as 32-bit powerpc). For example, trying to build a kernel with CONFIG_NET_RDS on such a platform would fail with: ERROR: "atomic64_read" [net/rds/rds.ko] undefined! ERROR: "atomic64_set" [net/rds/rds.ko] undefined! Fix this by exporting the atomic64_t functions to modules. (I export the entire API even if it's not all currently used by in-tree modules to avoid having to continue fixing this in dribs and drabs) Signed-off-by: Roland Dreier <rolandd@cisco.com> Acked-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent e4c6f8b commit 3fc7b4b

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

lib/atomic64.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <linux/cache.h>
1414
#include <linux/spinlock.h>
1515
#include <linux/init.h>
16+
#include <linux/module.h>
1617
#include <asm/atomic.h>
1718

1819
/*
@@ -52,6 +53,7 @@ long long atomic64_read(const atomic64_t *v)
5253
spin_unlock_irqrestore(lock, flags);
5354
return val;
5455
}
56+
EXPORT_SYMBOL(atomic64_read);
5557

5658
void atomic64_set(atomic64_t *v, long long i)
5759
{
@@ -62,6 +64,7 @@ void atomic64_set(atomic64_t *v, long long i)
6264
v->counter = i;
6365
spin_unlock_irqrestore(lock, flags);
6466
}
67+
EXPORT_SYMBOL(atomic64_set);
6568

6669
void atomic64_add(long long a, atomic64_t *v)
6770
{
@@ -72,6 +75,7 @@ void atomic64_add(long long a, atomic64_t *v)
7275
v->counter += a;
7376
spin_unlock_irqrestore(lock, flags);
7477
}
78+
EXPORT_SYMBOL(atomic64_add);
7579

7680
long long atomic64_add_return(long long a, atomic64_t *v)
7781
{
@@ -84,6 +88,7 @@ long long atomic64_add_return(long long a, atomic64_t *v)
8488
spin_unlock_irqrestore(lock, flags);
8589
return val;
8690
}
91+
EXPORT_SYMBOL(atomic64_add_return);
8792

8893
void atomic64_sub(long long a, atomic64_t *v)
8994
{
@@ -94,6 +99,7 @@ void atomic64_sub(long long a, atomic64_t *v)
9499
v->counter -= a;
95100
spin_unlock_irqrestore(lock, flags);
96101
}
102+
EXPORT_SYMBOL(atomic64_sub);
97103

98104
long long atomic64_sub_return(long long a, atomic64_t *v)
99105
{
@@ -106,6 +112,7 @@ long long atomic64_sub_return(long long a, atomic64_t *v)
106112
spin_unlock_irqrestore(lock, flags);
107113
return val;
108114
}
115+
EXPORT_SYMBOL(atomic64_sub_return);
109116

110117
long long atomic64_dec_if_positive(atomic64_t *v)
111118
{
@@ -120,6 +127,7 @@ long long atomic64_dec_if_positive(atomic64_t *v)
120127
spin_unlock_irqrestore(lock, flags);
121128
return val;
122129
}
130+
EXPORT_SYMBOL(atomic64_dec_if_positive);
123131

124132
long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
125133
{
@@ -134,6 +142,7 @@ long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
134142
spin_unlock_irqrestore(lock, flags);
135143
return val;
136144
}
145+
EXPORT_SYMBOL(atomic64_cmpxchg);
137146

138147
long long atomic64_xchg(atomic64_t *v, long long new)
139148
{
@@ -147,6 +156,7 @@ long long atomic64_xchg(atomic64_t *v, long long new)
147156
spin_unlock_irqrestore(lock, flags);
148157
return val;
149158
}
159+
EXPORT_SYMBOL(atomic64_xchg);
150160

151161
int atomic64_add_unless(atomic64_t *v, long long a, long long u)
152162
{
@@ -162,6 +172,7 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u)
162172
spin_unlock_irqrestore(lock, flags);
163173
return ret;
164174
}
175+
EXPORT_SYMBOL(atomic64_add_unless);
165176

166177
static int init_atomic64_lock(void)
167178
{

0 commit comments

Comments
 (0)