Skip to content

Commit 9255813

Browse files
mrutland-armingomolnar
authored andcommitted
locking/atomic: Use s64 for atomic64
As a step towards making the atomic64 API use consistent types treewide, let's have the generic atomic64 implementation use s64 as the underlying type for atomic64_t, rather than long long, matching the generated headers. Otherwise, there should be no functional change as a result of this patch. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Deacon <will.deacon@arm.com> Cc: aou@eecs.berkeley.edu Cc: bp@alien8.de Cc: catalin.marinas@arm.com Cc: davem@davemloft.net Cc: fenghua.yu@intel.com Cc: heiko.carstens@de.ibm.com Cc: herbert@gondor.apana.org.au Cc: ink@jurassic.park.msu.ru Cc: jhogan@kernel.org Cc: linux@armlinux.org.uk Cc: mattst88@gmail.com Cc: mpe@ellerman.id.au Cc: palmer@sifive.com Cc: paul.burton@mips.com Cc: paulus@samba.org Cc: ralf@linux-mips.org Cc: rth@twiddle.net Cc: tony.luck@intel.com Cc: vgupta@synopsys.com Link: https://lkml.kernel.org/r/20190522132250.26499-4-mark.rutland@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 982164d commit 9255813

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

include/asm-generic/atomic64.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,24 @@
1010
#include <linux/types.h>
1111

1212
typedef struct {
13-
long long counter;
13+
s64 counter;
1414
} atomic64_t;
1515

1616
#define ATOMIC64_INIT(i) { (i) }
1717

18-
extern long long atomic64_read(const atomic64_t *v);
19-
extern void atomic64_set(atomic64_t *v, long long i);
18+
extern s64 atomic64_read(const atomic64_t *v);
19+
extern void atomic64_set(atomic64_t *v, s64 i);
2020

2121
#define atomic64_set_release(v, i) atomic64_set((v), (i))
2222

2323
#define ATOMIC64_OP(op) \
24-
extern void atomic64_##op(long long a, atomic64_t *v);
24+
extern void atomic64_##op(s64 a, atomic64_t *v);
2525

2626
#define ATOMIC64_OP_RETURN(op) \
27-
extern long long atomic64_##op##_return(long long a, atomic64_t *v);
27+
extern s64 atomic64_##op##_return(s64 a, atomic64_t *v);
2828

2929
#define ATOMIC64_FETCH_OP(op) \
30-
extern long long atomic64_fetch_##op(long long a, atomic64_t *v);
30+
extern s64 atomic64_fetch_##op(s64 a, atomic64_t *v);
3131

3232
#define ATOMIC64_OPS(op) ATOMIC64_OP(op) ATOMIC64_OP_RETURN(op) ATOMIC64_FETCH_OP(op)
3333

@@ -46,11 +46,11 @@ ATOMIC64_OPS(xor)
4646
#undef ATOMIC64_OP_RETURN
4747
#undef ATOMIC64_OP
4848

49-
extern long long atomic64_dec_if_positive(atomic64_t *v);
49+
extern s64 atomic64_dec_if_positive(atomic64_t *v);
5050
#define atomic64_dec_if_positive atomic64_dec_if_positive
51-
extern long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n);
52-
extern long long atomic64_xchg(atomic64_t *v, long long new);
53-
extern long long atomic64_fetch_add_unless(atomic64_t *v, long long a, long long u);
51+
extern s64 atomic64_cmpxchg(atomic64_t *v, s64 o, s64 n);
52+
extern s64 atomic64_xchg(atomic64_t *v, s64 new);
53+
extern s64 atomic64_fetch_add_unless(atomic64_t *v, s64 a, s64 u);
5454
#define atomic64_fetch_add_unless atomic64_fetch_add_unless
5555

5656
#endif /* _ASM_GENERIC_ATOMIC64_H */

lib/atomic64.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ static inline raw_spinlock_t *lock_addr(const atomic64_t *v)
4242
return &atomic64_lock[addr & (NR_LOCKS - 1)].lock;
4343
}
4444

45-
long long atomic64_read(const atomic64_t *v)
45+
s64 atomic64_read(const atomic64_t *v)
4646
{
4747
unsigned long flags;
4848
raw_spinlock_t *lock = lock_addr(v);
49-
long long val;
49+
s64 val;
5050

5151
raw_spin_lock_irqsave(lock, flags);
5252
val = v->counter;
@@ -55,7 +55,7 @@ long long atomic64_read(const atomic64_t *v)
5555
}
5656
EXPORT_SYMBOL(atomic64_read);
5757

58-
void atomic64_set(atomic64_t *v, long long i)
58+
void atomic64_set(atomic64_t *v, s64 i)
5959
{
6060
unsigned long flags;
6161
raw_spinlock_t *lock = lock_addr(v);
@@ -67,7 +67,7 @@ void atomic64_set(atomic64_t *v, long long i)
6767
EXPORT_SYMBOL(atomic64_set);
6868

6969
#define ATOMIC64_OP(op, c_op) \
70-
void atomic64_##op(long long a, atomic64_t *v) \
70+
void atomic64_##op(s64 a, atomic64_t *v) \
7171
{ \
7272
unsigned long flags; \
7373
raw_spinlock_t *lock = lock_addr(v); \
@@ -79,11 +79,11 @@ void atomic64_##op(long long a, atomic64_t *v) \
7979
EXPORT_SYMBOL(atomic64_##op);
8080

8181
#define ATOMIC64_OP_RETURN(op, c_op) \
82-
long long atomic64_##op##_return(long long a, atomic64_t *v) \
82+
s64 atomic64_##op##_return(s64 a, atomic64_t *v) \
8383
{ \
8484
unsigned long flags; \
8585
raw_spinlock_t *lock = lock_addr(v); \
86-
long long val; \
86+
s64 val; \
8787
\
8888
raw_spin_lock_irqsave(lock, flags); \
8989
val = (v->counter c_op a); \
@@ -93,11 +93,11 @@ long long atomic64_##op##_return(long long a, atomic64_t *v) \
9393
EXPORT_SYMBOL(atomic64_##op##_return);
9494

9595
#define ATOMIC64_FETCH_OP(op, c_op) \
96-
long long atomic64_fetch_##op(long long a, atomic64_t *v) \
96+
s64 atomic64_fetch_##op(s64 a, atomic64_t *v) \
9797
{ \
9898
unsigned long flags; \
9999
raw_spinlock_t *lock = lock_addr(v); \
100-
long long val; \
100+
s64 val; \
101101
\
102102
raw_spin_lock_irqsave(lock, flags); \
103103
val = v->counter; \
@@ -130,11 +130,11 @@ ATOMIC64_OPS(xor, ^=)
130130
#undef ATOMIC64_OP_RETURN
131131
#undef ATOMIC64_OP
132132

133-
long long atomic64_dec_if_positive(atomic64_t *v)
133+
s64 atomic64_dec_if_positive(atomic64_t *v)
134134
{
135135
unsigned long flags;
136136
raw_spinlock_t *lock = lock_addr(v);
137-
long long val;
137+
s64 val;
138138

139139
raw_spin_lock_irqsave(lock, flags);
140140
val = v->counter - 1;
@@ -145,11 +145,11 @@ long long atomic64_dec_if_positive(atomic64_t *v)
145145
}
146146
EXPORT_SYMBOL(atomic64_dec_if_positive);
147147

148-
long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
148+
s64 atomic64_cmpxchg(atomic64_t *v, s64 o, s64 n)
149149
{
150150
unsigned long flags;
151151
raw_spinlock_t *lock = lock_addr(v);
152-
long long val;
152+
s64 val;
153153

154154
raw_spin_lock_irqsave(lock, flags);
155155
val = v->counter;
@@ -160,11 +160,11 @@ long long atomic64_cmpxchg(atomic64_t *v, long long o, long long n)
160160
}
161161
EXPORT_SYMBOL(atomic64_cmpxchg);
162162

163-
long long atomic64_xchg(atomic64_t *v, long long new)
163+
s64 atomic64_xchg(atomic64_t *v, s64 new)
164164
{
165165
unsigned long flags;
166166
raw_spinlock_t *lock = lock_addr(v);
167-
long long val;
167+
s64 val;
168168

169169
raw_spin_lock_irqsave(lock, flags);
170170
val = v->counter;
@@ -174,11 +174,11 @@ long long atomic64_xchg(atomic64_t *v, long long new)
174174
}
175175
EXPORT_SYMBOL(atomic64_xchg);
176176

177-
long long atomic64_fetch_add_unless(atomic64_t *v, long long a, long long u)
177+
s64 atomic64_fetch_add_unless(atomic64_t *v, s64 a, s64 u)
178178
{
179179
unsigned long flags;
180180
raw_spinlock_t *lock = lock_addr(v);
181-
long long val;
181+
s64 val;
182182

183183
raw_spin_lock_irqsave(lock, flags);
184184
val = v->counter;

0 commit comments

Comments
 (0)