Skip to content

Get spring training statcast data#405

Open
ss77995ss wants to merge 1 commit into
jldbc:masterfrom
ss77995ss:feature/extend-statcast-date-range
Open

Get spring training statcast data#405
ss77995ss wants to merge 1 commit into
jldbc:masterfrom
ss77995ss:feature/extend-statcast-date-range

Conversation

@ss77995ss

Copy link
Copy Markdown

Description

  • Spring training usually start from near 2/20 but the default range of start date is 3/15
  • Change the default from 3/15 to 2/15

* Spring training usually start from near 2/20 but the default range of start date is 3/15

* Change the default from 3/15 to 2/15
@ss77995ss

Copy link
Copy Markdown
Author

Hi @tjburch , @schorrm . Could you maybe have a look on this PR?
It will help us get complete spring training statcast data.

@tjburch

tjburch commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

Ran the CI. Seems like a fine change. I don't do a much here anymore, but if @schorrm doesn't pull the trigger in the next few days I'll merge it.

@schorrm

schorrm commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

Does the function filter out spring training? Can we?

@ss77995ss

ss77995ss commented Apr 2, 2024

Copy link
Copy Markdown
Author

Does the function filter out spring training? Can we?

They used argument hfGT to filter
Currently in pybaseball uses value &hfGT=R%7CPO%7CS%7C= (URL decode would be R|PO|S|=) which contains Regular Season, Spring Training and Playoff data

ref: pybaseball code, Baseball Savant's Search page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants