Skip to content

Commit cf65f6a

Browse files
committed
Demote opentest4j between assumption exception classes (fixes #1985)
New order of priority: * org.testng.SkipException * org.junit.AssumptionViolatedException * org.opentest4j.TestAbortedException
1 parent 91db723 commit cf65f6a

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/main/java/org/assertj/core/api/Assumptions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1295,16 +1295,16 @@ protected static <ASSERTION> Class<? extends ASSERTION> generateAssumptionClass(
12951295
}
12961296

12971297
private static RuntimeException assumptionNotMet(AssertionError assertionError) throws ReflectiveOperationException {
1298-
Class<?> assumptionClass = getAssumptionClass("org.opentest4j.TestAbortedException");
1298+
Class<?> assumptionClass = getAssumptionClass("org.testng.SkipException");
12991299
if (assumptionClass != null) return assumptionNotMet(assumptionClass, assertionError);
13001300

1301-
assumptionClass = getAssumptionClass("org.testng.SkipException");
1301+
assumptionClass = getAssumptionClass("org.junit.AssumptionViolatedException");
13021302
if (assumptionClass != null) return assumptionNotMet(assumptionClass, assertionError);
13031303

1304-
assumptionClass = getAssumptionClass("org.junit.AssumptionViolatedException");
1304+
assumptionClass = getAssumptionClass("org.opentest4j.TestAbortedException");
13051305
if (assumptionClass != null) return assumptionNotMet(assumptionClass, assertionError);
13061306

1307-
throw new IllegalStateException("Assumptions require opentest4j, TestNG or JUnit on the classpath");
1307+
throw new IllegalStateException("Assumptions require TestNG, JUnit or opentest4j on the classpath");
13081308
}
13091309

13101310
private static Class<?> getAssumptionClass(String className) {

src/test/java/org/assertj/core/util/AssertionsUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
2626
import org.assertj.core.api.ThrowableAssertAlternative;
27-
import org.opentest4j.TestAbortedException;
27+
import org.junit.AssumptionViolatedException;
2828

2929
public class AssertionsUtil {
3030

@@ -41,7 +41,7 @@ public static ThrowableAssertAlternative<AssertionError> assertThatAssertionErro
4141
}
4242

4343
public static void expectAssumptionNotMetException(ThrowingCallable shouldRaiseError) {
44-
assertThatThrownBy(shouldRaiseError).isInstanceOf(TestAbortedException.class);
44+
assertThatThrownBy(shouldRaiseError).isInstanceOf(AssumptionViolatedException.class);
4545
}
4646

4747
public static Charset getDifferentCharsetFrom(Charset charset) {

0 commit comments

Comments
 (0)