fix: address provider release readiness feedback

Author: joeynyc

apps/server/src/provider/Layers/HermesProvider.ts

@@ -76,7 +76,7 @@ export function parseHermesConfigModelDefaults(raw: string): HermesConfigModelDe
   let sawModelBlock = false;
 
   for (const line of lines) {
-    const withoutComment = line.replace(/\s+#.*$/, "");
+    const withoutComment = line.replace(/\s*#.*$/, "");
     if (withoutComment.trim().length === 0) continue;
 
     const indent = withoutComment.length - withoutComment.trimStart().length;

apps/server/src/provider/Layers/PiProvider.ts

@@ -36,7 +36,7 @@ const PROVIDER = ProviderDriverKind.make("pi");
 const PI_PRESENTATION = {
   displayName: "Pi",
   badgeLabel: "Early Access",
-  showInteractionModeToggle: true,
+  showInteractionModeToggle: false,
 } as const;
 const EMPTY_CAPABILITIES = createModelCapabilities({ optionDescriptors: [] });
 const PI_FALLBACK_MODEL: ServerProviderModel = {
@@ -176,8 +176,9 @@ function readPiConfigModelDefaults(
   return Effect.gen(function* () {
     const fs = yield* FileSystem.FileSystem;
     const path = yield* Path.Path;
-    const home = environment.PI_CODING_AGENT_DIR?.trim()
-      ? environment.PI_CODING_AGENT_DIR
+    const configuredHome = environment.PI_CODING_AGENT_DIR?.trim();
+    const home = configuredHome
+      ? configuredHome
       : path.join(environment.HOME || NodeOS.homedir(), ".pi", "agent");
     const raw = yield* fs
       .readFileString(path.join(home, "settings.json"))
@@ -231,8 +232,9 @@ function readPiAuthState(
 ): Effect.Effect<PiAuthState, never, FileSystem.FileSystem | Path.Path> {
   return Effect.gen(function* () {
     const path = yield* Path.Path;
-    const home = environment.PI_CODING_AGENT_DIR?.trim()
-      ? environment.PI_CODING_AGENT_DIR
+    const configuredHome = environment.PI_CODING_AGENT_DIR?.trim();
+    const home = configuredHome
+      ? configuredHome
       : path.join(environment.HOME || NodeOS.homedir(), ".pi", "agent");
     const settings = yield* readOptionalFile(path.join(home, "settings.json"));
     const defaultProvider = settings

apps/server/src/provider/acp/PiAcpSupport.test.ts

@@ -74,4 +74,32 @@ describe("buildPiAcpSpawnInput", () => {
       },
     });
   });
+
+  it("preserves Windows root executable directories", () => {
+    expect(
+      buildPiAcpSpawnInput(
+        {
+          binaryPath: "C:\\pi-acp.cmd",
+          piBinaryPath: "C:\\pi.cmd",
+        },
+        "C:\\work\\project",
+        {},
+      ).env?.PATH,
+    ).toBe("C:\\");
+  });
+
+  it("does not add an empty PATH for relative commands without an existing path", () => {
+    expect(
+      buildPiAcpSpawnInput(
+        {
+          binaryPath: "pi-acp",
+          piBinaryPath: "pi",
+        },
+        "/tmp/project",
+        {},
+      ).env,
+    ).toEqual({
+      PI_ACP_PI_COMMAND: "pi",
+    });
+  });
 });

apps/server/src/provider/acp/PiAcpSupport.ts

@@ -34,10 +34,14 @@ function dirnameForExecutablePath(value: string | undefined): string | null {
     return null;
   }
   const normalized = value.replaceAll("\\", "/");
-  if (!normalized.startsWith("/") && !WINDOWS_ABSOLUTE_PATH_PATTERN.test(normalized)) {
+  const isWindowsAbsolute = WINDOWS_ABSOLUTE_PATH_PATTERN.test(normalized);
+  if (!normalized.startsWith("/") && !isWindowsAbsolute) {
     return null;
   }
   const separatorIndex = normalized.lastIndexOf("/");
+  if (isWindowsAbsolute && separatorIndex === 2) {
+    return value.slice(0, 3);
+  }
   return separatorIndex > 0 ? value.slice(0, separatorIndex) : "/";
 }
 
@@ -72,14 +76,17 @@ function buildPiAcpEnvironment(
   if (piSettings?.piBinaryPath) {
     env.PI_ACP_PI_COMMAND = piSettings.piBinaryPath;
   }
-  env[pathKey] = prependUniquePathEntries(
+  const nextPath = prependUniquePathEntries(
     env[pathKey],
     [
       dirnameForExecutablePath(piSettings?.binaryPath),
       dirnameForExecutablePath(piSettings?.piBinaryPath),
     ],
     pathDelimiter,
   );
+  if (nextPath) {
+    env[pathKey] = nextPath;
+  }
   return env;
 }
 

apps/web/src/components/settings/SettingsPanels.browser.tsx

@@ -1261,9 +1261,15 @@ describe("GeneralSettingsPanel observability", () => {
   });
 
   it("offers provider updates in expanded settings even without an outdated advisory", async () => {
-    const updateProvider = vi.fn<LocalApi["server"]["updateProvider"]>().mockResolvedValue({
-      providers: [createCurrentUpdatableProvider("pi", "pi update")],
-    });
+    let resolveUpdateProvider:
+      | ((value: Awaited<ReturnType<LocalApi["server"]["updateProvider"]>>) => void)
+      | undefined;
+    const updateProvider = vi.fn<LocalApi["server"]["updateProvider"]>().mockImplementation(
+      () =>
+        new Promise((resolve) => {
+          resolveUpdateProvider = resolve;
+        }),
+    );
     window.nativeApi = {
       persistence: {
         getClientSettings: vi.fn().mockResolvedValue(null),
@@ -1289,11 +1295,15 @@ describe("GeneralSettingsPanel observability", () => {
     await expect.element(page.getByText("Provider update")).toBeInTheDocument();
     await expect.element(page.getByText("pi update")).toBeInTheDocument();
     await page.getByRole("button", { name: "Update provider" }).click();
+    await expect.element(page.getByRole("button", { name: "Updating" })).toBeDisabled();
 
     expect(updateProvider).toHaveBeenCalledWith({
       provider: ProviderDriverKind.make("pi"),
       instanceId: ProviderInstanceId.make("pi"),
     });
+    resolveUpdateProvider?.({
+      providers: [createCurrentUpdatableProvider("pi", "pi update")],
+    });
   });
 
   it("keeps long provider update commands inside the fixed-width popover", async () => {

apps/web/src/components/settings/SettingsPanels.tsx

@@ -1233,11 +1233,13 @@ export function ProviderSettingsPanel() {
             ? providerUpdateCandidateByInstanceId.get(liveProvider.instanceId)
             : undefined;
           const isDriverUpdateRunning =
-            updateCandidate !== undefined &&
-            (updatingProviderDrivers.has(updateCandidate.driver) ||
+            liveProvider !== undefined &&
+            (updatingProviderDrivers.has(liveProvider.driver) ||
+              (updateCandidate !== undefined &&
+                updatingProviderDrivers.has(updateCandidate.driver)) ||
               serverProviders.some(
                 (provider) =>
-                  provider.driver === updateCandidate.driver && isProviderUpdateActive(provider),
+                  provider.driver === liveProvider.driver && isProviderUpdateActive(provider),
               ));
           const showInlineUpdateButton =
             liveProvider !== undefined &&