Fix the crash caused by triggering HTTP callback after WASM recovery

Author: johnlanni

source/extensions/common/wasm/context.cc

@@ -209,7 +209,11 @@ void Context::onCloseTCP() {
 void Context::onResolveDns(uint32_t token, Envoy::Network::DnsResolver::ResolutionStatus status,
                            std::list<Envoy::Network::DnsResponse>&& response) {
   proxy_wasm::DeferAfterCallActions actions(this);
+#if defined(HIGRESS)
+  if (isFailed() || !wasm()->on_resolve_dns_) {
+#else
   if (wasm()->isFailed() || !wasm()->on_resolve_dns_) {
+#endif
     return;
   }
   if (status != Network::DnsResolver::ResolutionStatus::Success) {
@@ -257,7 +261,11 @@ template <typename I> inline char* align(char* p) {
 
 void Context::onStatsUpdate(Envoy::Stats::MetricSnapshot& snapshot) {
   proxy_wasm::DeferAfterCallActions actions(this);
+#if defined(HIGRESS)
+  if (isFailed() || !wasm()->on_stats_update_) {
+#else
   if (wasm()->isFailed() || !wasm()->on_stats_update_) {
+#endif
     return;
   }
   // buffer format:
@@ -1120,7 +1128,7 @@ WasmResult Context::redisCall(std::string_view cluster, std::string_view query,
 }
 
 void Context::onRedisCallSuccess(uint32_t token, std::string&& response) {
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     redis_request_.erase(token);
     return;
   }
@@ -1150,7 +1158,7 @@ void Context::onRedisCallSuccess(uint32_t token, std::string&& response) {
 }
 
 void Context::onRedisCallFailure(uint32_t token) {
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     redis_request_.erase(token);
     return;
   }
@@ -2110,7 +2118,7 @@ void Context::setEncoderFilterCallbacks(Envoy::Http::StreamEncoderFilterCallback
 void Context::onHttpCallSuccess(uint32_t token, Envoy::Http::ResponseMessagePtr&& response) {
   // TODO: convert this into a function in proxy-wasm-cpp-host and use here.
 #if defined(HIGRESS)
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     http_request_.erase(token);
     return;
   }
@@ -2140,7 +2148,7 @@ void Context::onHttpCallSuccess(uint32_t token, Envoy::Http::ResponseMessagePtr&
 
 void Context::onHttpCallFailure(uint32_t token, Http::AsyncClient::FailureReason reason) {
 #if defined(HIGRESS)
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     http_request_.erase(token);
     return;
   }
@@ -2176,7 +2184,7 @@ void Context::onGrpcReceiveWrapper(uint32_t token, ::Envoy::Buffer::InstancePtr
     }
   };
 #if defined(HIGRESS)
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     cleanup();
     return;
   }
@@ -2218,7 +2226,7 @@ void Context::onGrpcCloseWrapper(uint32_t token, const Grpc::Status::GrpcStatus&
     }
   };
 #if defined(HIGRESS)
-  if (wasm()->isFailed()) {
+  if (isFailed()) {
     cleanup();
     return;
   }