Skip to content

Commit 4b587ac

Browse files
committed
Merge pull request moby#5436 from hobofan/master
reapply Cmd value even if CmdAdd returns early
2 parents 62c3183 + 6893689 commit 4b587ac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

server/buildfile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,6 +521,7 @@ func (b *buildFile) CmdAdd(args string) error {
521521

522522
cmd := b.config.Cmd
523523
b.config.Cmd = []string{"/bin/sh", "-c", fmt.Sprintf("#(nop) ADD %s in %s", orig, dest)}
524+
defer func(cmd []string) { b.config.Cmd = cmd }(cmd)
524525
b.config.Image = b.image
525526

526527
var (
@@ -656,7 +657,6 @@ func (b *buildFile) CmdAdd(args string) error {
656657
if err := b.commit(container.ID, cmd, fmt.Sprintf("ADD %s in %s", orig, dest)); err != nil {
657658
return err
658659
}
659-
b.config.Cmd = cmd
660660
return nil
661661
}
662662

0 commit comments

Comments
 (0)