Skip to content

Commit dad0e2b

Browse files
committed
iio: adc: mykonos: fix some warnings
This fixes '-Wtautological-overlap-compare' which resulted from 'v > 23 && v <= 23' which is obviously not possible. While at it fixed '-Wparentheses-equality' which complains about extra parenthesis like 'if ((v == x))'. Signed-off-by: Nuno Sa <nuno.sa@analog.com>
1 parent e2950fb commit dad0e2b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/iio/adc/mykonos/mykonos.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ mykonosErr_t MYKONOS_verifyDeviceDataStructure(mykonosDevice_t *device)
533533
}
534534
else
535535
{
536-
if ((device->obsRx->framer == NULL))
536+
if (device->obsRx->framer == NULL)
537537
{
538538
CMB_writeToLog(ADIHAL_LOG_ERROR, device->spiSettings->chipSelectIndex, MYKONOS_ERR_CHECKDEVSTRUCT_OBSRXFRAMER,
539539
getMykonosErrorMessage(MYKONOS_ERR_CHECKDEVSTRUCT_OBSRXFRAMER));
@@ -2029,7 +2029,7 @@ mykonosErr_t MYKONOS_initDigitalClocks(mykonosDevice_t *device)
20292029
{ /* Settings designed for 46.08 MHz PLL REFCLK */
20302030
vcoCalOffset = (vcoIndex == 11 || (vcoIndex > 35 && vcoIndex <= 37) || (vcoIndex > 29 && vcoIndex <= 34)|| vcoIndex == 40 || vcoIndex == 44) ?
20312031
14 :(vcoIndex <= 10 || vcoIndex > 44) ?
2032-
15 : ((vcoIndex > 12 && vcoIndex <= 22) || (vcoIndex > 23 && vcoIndex <= 23) || (vcoIndex > 26 && vcoIndex <= 29) || (vcoIndex > 23 && vcoIndex <= 25) || vcoIndex == 35) ?
2032+
15 : ((vcoIndex > 12 && vcoIndex <= 25) || (vcoIndex > 26 && vcoIndex <= 29) || vcoIndex == 35) ?
20332033
12 : 13;
20342034

20352035
loopFilterIcp = icp_46p08[vcoIndex - 1];
@@ -2056,7 +2056,7 @@ mykonosErr_t MYKONOS_initDigitalClocks(mykonosDevice_t *device)
20562056
{ /* Settings designed for 76.8 MHz PLL REFCLK */
20572057
vcoCalOffset = (vcoIndex == 11 || (vcoIndex > 35 && vcoIndex <= 37) || (vcoIndex > 29 && vcoIndex <= 34)|| vcoIndex == 40 || vcoIndex == 44) ?
20582058
14 :(vcoIndex <= 10 || vcoIndex > 44) ?
2059-
15 : ((vcoIndex > 12 && vcoIndex <= 22) || (vcoIndex > 23 && vcoIndex <= 23) || (vcoIndex > 26 && vcoIndex <= 29) || (vcoIndex > 23 && vcoIndex <= 25) || vcoIndex == 35) ?
2059+
15 : ((vcoIndex > 12 && vcoIndex <= 25) || (vcoIndex > 26 && vcoIndex <= 29) || vcoIndex == 35) ?
20602060
12 : 13;
20612061

20622062
loopFilterIcp = icp_76p8[vcoIndex-1];
@@ -16910,7 +16910,7 @@ static mykonosErr_t MYKONOS_calculateDigitalClocks(mykonosDevice_t *device, uint
1691016910
return MYKONOS_ERR_CALCDIGCLK_NULLDEV_PARAM;
1691116911
}
1691216912

16913-
if ((device->clocks == NULL))
16913+
if (device->clocks == NULL)
1691416914
{
1691516915
CMB_writeToLog(ADIHAL_LOG_ERROR, device->spiSettings->chipSelectIndex, MYKONOS_ERR_CALCDIGCLK_NULL_CLKSTRUCT,
1691616916
getMykonosErrorMessage(MYKONOS_ERR_CALCDIGCLK_NULL_CLKSTRUCT));

0 commit comments

Comments
 (0)