add frozen for rubocop

jpmagido · jpmagido · commit ba249966ce58 · 2021-10-22T11:44:26.000+02:00
diff --git a/.idea/la-mission-parfaite.iml b/.idea/la-mission-parfaite.iml
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -0,0 +1,12 @@
+require:
+  - rubocop-rails
+  - rubocop-rspec
+
+RSpec/DescribeClass:
+  IgnoredMetadata:
+    type:
+      - request
+      - controller
+
+Metrics/BlockLength:
+  IgnoredMethods: [ 'describe', 'context' ]
diff --git a/Gemfile b/Gemfile
@@ -37,6 +37,7 @@ group :development, :test do
   gem 'ffaker', '~> 2.18', '>= 2.20'
   gem 'rspec-rails', '~> 5.0', '>= 5.0.1'
   gem 'shoulda-matchers', '~> 4.5', '>= 4.5.1'
+  gem 'rubocop-rails', require: false
 end
 
 group :development do
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -62,6 +62,7 @@ GEM
       zeitwerk (~> 2.3)
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
     bcrypt (3.1.16)
     better_errors (2.9.1)
       coderay (>= 1.0.0)
@@ -141,6 +142,9 @@ GEM
     nokogiri (1.12.5-x86_64-linux)
       racc (~> 1.4)
     orm_adapter (0.5.0)
+    parallel (1.21.0)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
     pg (1.2.3)
     public_suffix (4.0.6)
     puma (5.5.2)
@@ -183,6 +187,7 @@ GEM
       method_source
       rake (>= 0.13)
       thor (~> 1.0)
+    rainbow (3.0.0)
     rake (13.0.6)
     rb-fsevent (0.11.0)
     rb-inotify (0.10.1)
@@ -209,6 +214,22 @@ GEM
       rspec-mocks (~> 3.10)
       rspec-support (~> 3.10)
     rspec-support (3.10.2)
+    rubocop (1.22.1)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.12.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.12.0)
+      parser (>= 3.0.1.1)
+    rubocop-rails (2.12.4)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.7.0, < 2.0)
+    ruby-progressbar (1.11.0)
     ruby-vips (2.1.3)
       ffi (~> 1.12)
     rubyzip (2.3.2)
@@ -244,6 +265,7 @@ GEM
     turbolinks-source (5.2.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
+    unicode-display_width (2.1.0)
     warden (1.2.9)
       rack (>= 2.0.9)
     web-console (4.1.0)
@@ -297,6 +319,7 @@ DEPENDENCIES
   rails (~> 6.1.3)
   rexml (~> 3.2, >= 3.2.4)
   rspec-rails (~> 5.0, >= 5.0.1)
+  rubocop-rails
   sass-rails (>= 6)
   selenium-webdriver
   shoulda-matchers (~> 4.5, >= 4.5.1)
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   rescue_from Pundit::NotAuthorizedError, with: :render_401
 
diff --git a/app/controllers/cities_controller.rb b/app/controllers/cities_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CitiesController < ApplicationController
   helper_method :city, :cities
 
diff --git a/app/controllers/errors_controller.rb b/app/controllers/errors_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ErrorsController < ApplicationController
   helper_method :errors
 
diff --git a/app/controllers/gateways_controller.rb b/app/controllers/gateways_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GatewaysController < ApplicationController
   def user
     redirect_to static_pages_home_path if session_password_match?
diff --git a/app/controllers/restaurants_controller.rb b/app/controllers/restaurants_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class RestaurantsController < ApplicationController
   helper_method :restaurant, :restaurants
   include RestaurantsHelper
@@ -31,5 +33,3 @@ def params_restaurant
     params.require(:restaurant).permit(:vegan, :city_id, :name)
   end
 end
-
-
diff --git a/app/controllers/static_pages_controller.rb b/app/controllers/static_pages_controller.rb
@@ -1,13 +1,10 @@
+# frozen_string_literal: true
+
 class StaticPagesController < ApplicationController
   before_action :home_redirection
 
-  def home
-
-  end
-
-  def refund
-
-  end
+  def home; end
+  def refund; end
 
   private
 
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
   def flash_class(level)
     case level
diff --git a/app/helpers/restaurants_helper.rb b/app/helpers/restaurants_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RestaurantsHelper
    def is_vegan(restaurant)
     restaurant.vegan == true ? 'vegan' : 'pas vegan friendly'
diff --git a/app/helpers/static_pages_helper.rb b/app/helpers/static_pages_helper.rb
diff --git a/app/jobs/application_job.rb b/app/jobs/application_job.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
   # Automatically retry jobs that encountered a deadlock
   # retry_on ActiveRecord::Deadlocked
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
   default from: 'from@example.com'
   layout 'mailer'
diff --git a/app/models/admin.rb b/app/models/admin.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Admin < ApplicationRecord
   # Include default devise modules. Others available are:
   # :timeoutable and :omniauthable
diff --git a/app/models/application_record.rb b/app/models/application_record.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end
diff --git a/app/models/city.rb b/app/models/city.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class City < ApplicationRecord
   has_many :locations
   has_many :restaurants
diff --git a/app/models/housing.rb b/app/models/housing.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Housing < ApplicationRecord
   belongs_to :city
   belongs_to :location
diff --git a/app/models/location.rb b/app/models/location.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Location < ApplicationRecord
   validates_length_of :address, in: 3..40
   validates_length_of :street_number, in: 1..10
diff --git a/app/models/password.rb b/app/models/password.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bcrypt'
 
 class Password < ApplicationRecord
diff --git a/app/models/restaurant.rb b/app/models/restaurant.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Restaurant < ApplicationRecord
   serialize :delivery, Array
 
diff --git a/app/policies/application_policy.rb b/app/policies/application_policy.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationPolicy
   attr_reader :user, :record
 
diff --git a/app/policies/city_policy.rb b/app/policies/city_policy.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CityPolicy < ApplicationPolicy
 
   def update?
diff --git a/spec/factories.rb b/spec/factories.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :housing do
     breakfast { [true, false].sample }
diff --git a/spec/features/devise/sign_in_spec.rb b/spec/features/devise/sign_in_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe "/devise/session/new.html.erb", type: :feature do
diff --git a/spec/features/devise/sign_up_spec.rb b/spec/features/devise/sign_up_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe "/devise/registration/new.html.erb", type: :feature do
diff --git a/spec/features/gateways/admin_spec.rb b/spec/features/gateways/admin_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe "/gateways/admin.html.erb", type: :feature do
diff --git a/spec/features/gateways/user_spec.rb b/spec/features/gateways/user_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe "/gateways/user.html.erb", type: :feature do
diff --git a/spec/helpers/restaurants_helper_spec.rb b/spec/helpers/restaurants_helper_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe RestaurantsHelper, type: :helper do
diff --git a/spec/models/admin_spec.rb b/spec/models/admin_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Admin, type: :model do
diff --git a/spec/models/city_spec.rb b/spec/models/city_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe City, type: :model do
diff --git a/spec/models/housing_spec.rb b/spec/models/housing_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Housing, type: :model do
diff --git a/spec/models/location_spec.rb b/spec/models/location_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Location, type: :model do
diff --git a/spec/models/password_spec.rb b/spec/models/password_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Password, type: :model do
diff --git a/spec/models/restaurant_spec.rb b/spec/models/restaurant_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Restaurant, type: :model do
diff --git a/spec/policies/city_policy_spec.rb b/spec/policies/city_policy_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe CityPolicy do
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
diff --git a/spec/requests/admin/passwords_spec.rb b/spec/requests/admin/passwords_spec.rb
diff --git a/spec/requests/cities_spec.rb b/spec/requests/cities_spec.rb
diff --git a/spec/requests/restaurants_spec.rb b/spec/requests/restaurants_spec.rb
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
diff --git a/spec/support/context/passwords_creation.rb b/spec/support/context/passwords_creation.rb
diff --git a/spec/support/factory_bot.rb b/spec/support/factory_bot.rb

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class ApplicationController < ActionController::Base`
`2`	`4`	`rescue_from Pundit::NotAuthorizedError, with: :render_401`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class CitiesController < ApplicationController`
`2`	`4`	`helper_method :city, :cities`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class ErrorsController < ApplicationController`
`2`	`4`	`helper_method :errors`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class GatewaysController < ApplicationController`
`2`	`4`	`def user`
`3`	`5`	`redirect_to static_pages_home_path if session_password_match?`