Skip to content

Commit 8be5312

Browse files
committed
Update default plugin versions to latest compatible versions
The previous versions don't work properly on modern Maven 3. Since Maven 3.9 is the only non EOL version, and Maven 3.9 is also EOL 9 months ago, this should not be a problem. Right now users need to override these from Mavenfile to get things to work and avoid warnings, which is a pain.
1 parent 9b7cec6 commit 8be5312

File tree

10 files changed

+22
-22
lines changed

10 files changed

+22
-22
lines changed

lib/maven/tools/versions.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ module Maven
2222
module Tools
2323
unless defined? VERSIONS
2424
VERSIONS = {
25-
:jar_plugin => "2.4",
26-
:clean_plugin => "2.4",
25+
:clean_plugin => "3.5.0",
26+
:jar_plugin => "3.5.0",
2727
:jruby_plugins => "3.0.6",
2828
:jruby9_plugins => "0.3.0",
2929
:bundler_version => "1.10.6",
30-
:jruby_version => "9.1.2.0",
31-
:polyglot_version => "0.1.18",
30+
:jruby_version => "9.4.14.0",
31+
:polyglot_version => "0.8.1",
3232
:mavengem_wagon => "2.0.2"
3333
}.freeze
3434
end

spec/gemfile_with_custom_source/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<plugins>
7373
<plugin>
7474
<artifactId>maven-jar-plugin</artifactId>
75-
<version>2.4</version>
75+
<version>3.5.0</version>
7676
<executions>
7777
<execution>
7878
<phase>prepare-package</phase>
@@ -88,7 +88,7 @@
8888
</plugin>
8989
<plugin>
9090
<artifactId>maven-clean-plugin</artifactId>
91-
<version>2.4</version>
91+
<version>3.5.0</version>
9292
<configuration>
9393
<filesets>
9494
<fileset>

spec/gemfile_with_custom_source_and_custom_jarname/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<plugins>
7373
<plugin>
7474
<artifactId>maven-jar-plugin</artifactId>
75-
<version>2.4</version>
75+
<version>3.5.0</version>
7676
<executions>
7777
<execution>
7878
<phase>prepare-package</phase>
@@ -88,7 +88,7 @@
8888
</plugin>
8989
<plugin>
9090
<artifactId>maven-clean-plugin</artifactId>
91-
<version>2.4</version>
91+
<version>3.5.0</version>
9292
<configuration>
9393
<filesets>
9494
<fileset>

spec/gemfile_with_source/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
<plugins>
7979
<plugin>
8080
<artifactId>maven-jar-plugin</artifactId>
81-
<version>2.4</version>
81+
<version>3.5.0</version>
8282
<executions>
8383
<execution>
8484
<phase>prepare-package</phase>
@@ -94,7 +94,7 @@
9494
</plugin>
9595
<plugin>
9696
<artifactId>maven-clean-plugin</artifactId>
97-
<version>2.4</version>
97+
<version>3.5.0</version>
9898
<configuration>
9999
<filesets>
100100
<fileset>

spec/gemfile_with_source_and_custom_jarname/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
<plugins>
7272
<plugin>
7373
<artifactId>maven-jar-plugin</artifactId>
74-
<version>2.4</version>
74+
<version>3.5.0</version>
7575
<executions>
7676
<execution>
7777
<phase>prepare-package</phase>
@@ -87,7 +87,7 @@
8787
</plugin>
8888
<plugin>
8989
<artifactId>maven-clean-plugin</artifactId>
90-
<version>2.4</version>
90+
<version>3.5.0</version>
9191
<configuration>
9292
<filesets>
9393
<fileset>

spec/gemspec_with_custom_source/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<plugins>
7373
<plugin>
7474
<artifactId>maven-jar-plugin</artifactId>
75-
<version>2.4</version>
75+
<version>3.5.0</version>
7676
<executions>
7777
<execution>
7878
<phase>prepare-package</phase>
@@ -88,7 +88,7 @@
8888
</plugin>
8989
<plugin>
9090
<artifactId>maven-clean-plugin</artifactId>
91-
<version>2.4</version>
91+
<version>3.5.0</version>
9292
<configuration>
9393
<filesets>
9494
<fileset>

spec/gemspec_with_custom_source_and_custom_jarname/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<plugins>
7373
<plugin>
7474
<artifactId>maven-jar-plugin</artifactId>
75-
<version>2.4</version>
75+
<version>3.5.0</version>
7676
<executions>
7777
<execution>
7878
<phase>prepare-package</phase>
@@ -88,7 +88,7 @@
8888
</plugin>
8989
<plugin>
9090
<artifactId>maven-clean-plugin</artifactId>
91-
<version>2.4</version>
91+
<version>3.5.0</version>
9292
<configuration>
9393
<filesets>
9494
<fileset>

spec/gemspec_with_source/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<plugins>
6969
<plugin>
7070
<artifactId>maven-jar-plugin</artifactId>
71-
<version>2.4</version>
71+
<version>3.5.0</version>
7272
<executions>
7373
<execution>
7474
<phase>prepare-package</phase>
@@ -84,7 +84,7 @@
8484
</plugin>
8585
<plugin>
8686
<artifactId>maven-clean-plugin</artifactId>
87-
<version>2.4</version>
87+
<version>3.5.0</version>
8888
<configuration>
8989
<filesets>
9090
<fileset>

spec/gemspec_with_source_and_custom_jarname/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
<plugins>
7272
<plugin>
7373
<artifactId>maven-jar-plugin</artifactId>
74-
<version>2.4</version>
74+
<version>3.5.0</version>
7575
<executions>
7676
<execution>
7777
<phase>prepare-package</phase>
@@ -87,7 +87,7 @@
8787
</plugin>
8888
<plugin>
8989
<artifactId>maven-clean-plugin</artifactId>
90-
<version>2.4</version>
90+
<version>3.5.0</version>
9191
<configuration>
9292
<filesets>
9393
<fileset>

spec/pom_with_execute/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<plugin>
2121
<groupId>io.takari.polyglot</groupId>
2222
<artifactId>polyglot-maven-plugin</artifactId>
23-
<version>0.1.18</version>
23+
<version>0.8.1</version>
2424
<executions>
2525
<execution>
2626
<phase>validate</phase>
@@ -80,7 +80,7 @@
8080
<dependency>
8181
<groupId>io.takari.polyglot</groupId>
8282
<artifactId>polyglot-ruby</artifactId>
83-
<version>0.1.18</version>
83+
<version>0.8.1</version>
8484
</dependency>
8585
</dependencies>
8686
</plugin>

0 commit comments

Comments
 (0)