Skip to content

Replace deep-equal with dequal#24

Closed
wojtekmaj wants to merge 1 commit into
jshttp:masterfrom
wojtekmaj:dequal
Closed

Replace deep-equal with dequal#24
wojtekmaj wants to merge 1 commit into
jshttp:masterfrom
wojtekmaj:dequal

Conversation

@wojtekmaj
Copy link
Copy Markdown

This PR replaces deep-equal with dequal, an alternative package with 0 dependencies (as opposed to 49: https://npmgraph.js.org/?q=deep-equal).

This PR replaces deep-equal with dequal, an alternative package with 0 dependencies (as opposed to 49: https://npmgraph.js.org/?q=deep-equal).
@wesleytodd
Copy link
Copy Markdown
Member

We do not typically like to take package swaps for this reason. Is there any functional reason to pursue this change? In this specific case we would decline this PR anyway because the package currently supports node's older than 6. Even when we move past that hurdle, I don't see a reason to change this dependency based solely on how many transitives it brings in.

@wojtekmaj
Copy link
Copy Markdown
Author

wojtekmaj commented Jul 16, 2024

Since it's a devDependency, it's only going to affect the development environment. No user-facing code has been altered. I don't think any sane person would develop this package using Node.js 6.

The motivation for this change is to make this repo lighter and faster to install.

@wesleytodd
Copy link
Copy Markdown
Member

All our dev deps need to run in CI, and CI runs in older versions. As for faster to install, can you run some benchamrks and show how much difference this makes? Please do so with both cold and warm cache.

@blakeembrey
Copy link
Copy Markdown
Member

At this point in time I'm going to close this out as unnecessary as it's only a dev dependency change and doesn't appear to meaningfully change or improve anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants