fix: clean up dut-network state dir on close#688
Merged
Conversation
When the DutNetwork driver's cleanup() method runs (on close or reset),
the runtime state directory at /var/lib/jumpstarter/dut-network-{interface}/
was left behind after dnsmasq was stopped. This caused stale leases, pid
files, and other runtime state to persist across sessions.
Call dnsmasq.cleanup_state_dir() after stopping dnsmasq to remove the
entire state directory, ensuring each session starts with a clean state.
Also extract NTP cleanup into a _stop_ntp() helper to keep the cleanup()
method under the C901 complexity threshold.
Closes #687
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mangelajo
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var/lib/jumpstarter/dut-network-{interface}/) containing leases, pid files, config, and hosts files was not being cleaned up after dnsmasq was stoppeddnsmasq.cleanup_state_dir()in the driver'scleanup()method so the entire state directory is removed, ensuring each new session starts with a clean state_stop_ntp()helper to keepcleanup()under the C901 complexity thresholdTest plan
test_cleanup_removes_state_directoryverifyingcleanup_state_diris called with the correct state path during cleanupmake lint-fixCloses #687
Generated with Claude Code