Skip to content

feat: supporting new schema refactor#494

Merged
AlexsJones merged 2 commits intomainfrom
feat/schema-refactor
Aug 15, 2024
Merged

feat: supporting new schema refactor#494
AlexsJones merged 2 commits intomainfrom
feat/schema-refactor

Conversation

@AlexsJones
Copy link
Member

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners August 8, 2024 14:01
@AlexsJones
Copy link
Member Author

k8sgpt-ai/k8sgpt#1219

@matthisholleville
Copy link
Contributor

You need to update your branch

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

conditions: []
storedVersions: []


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 new lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because I copied it over manually, ill remove

@AlexsJones AlexsJones merged commit 6c01390 into main Aug 15, 2024
@AlexsJones AlexsJones deleted the feat/schema-refactor branch August 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants