Skip to content

Commit f1d8884

Browse files
fix(ILMS-391): Nothing happens after pressing the convert button. (#139)
* ILMS-391 Nothing happens after pressing the convert button. Fixed minified build. * Synchronize default plugins with v7 Player Studio.
1 parent 49f5087 commit f1d8884

File tree

2 files changed

+75
-68
lines changed

2 files changed

+75
-68
lines changed

app/js/controllers/playerListCtrl.js

Lines changed: 38 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,43 @@
22

33
/* Controllers */
44

5-
angular.module('KMCModule').controller('PlayerListCtrl',
6-
['apiService', 'loadINI', '$location', '$rootScope', '$scope', '$filter', '$modal', '$timeout', '$log', "$compile", "$window", 'localStorageService', 'requestNotificationChannel', 'PlayerService', '$q', 'utilsSvc', 'PermissionsService',
5+
angular.module('KMCModule')
6+
.controller('PlayerUpgradeModeCtrl',
7+
function ($scope, $modalInstance, settings) {
8+
$scope.playerId = '';
9+
$scope.mode = '';
10+
11+
$scope.close = function (result) {
12+
if (!result) {
13+
return $modalInstance.close();
14+
}
15+
16+
$modalInstance.close({
17+
mode: this.mode,
18+
templateId: Number(this.playerId)
19+
});
20+
};
21+
22+
$scope.cancel = function () {
23+
$modalInstance.dismiss('cancel');
24+
};
25+
26+
$scope.validate = function () {
27+
if (!this.mode) {
28+
return false;
29+
}
30+
31+
if (this.mode === 'template' && (this.playerId === '') || isNaN(this.playerId)) {
32+
return false;
33+
}
34+
35+
return true;
36+
};
37+
38+
angular.extend($scope, settings);
39+
})
40+
.controller('PlayerListCtrl',
41+
['apiService', 'loadINI', '$location', '$rootScope', '$scope', '$filter', '$modal', '$timeout', '$log', "$compile", "$window", 'localStorageService', 'requestNotificationChannel', 'PlayerService', '$q', 'utilsSvc', 'PermissionsService',
742
function (apiService, loadINI, $location, $rootScope, $scope, $filter, $modal, $timeout, $log, $compile, $window, localStorageService, requestNotificationChannel, PlayerService, $q, utilsSvc, PermissionsService) {
843
// start request to show the spinner. When data is rendered, the onFinishRender directive will hide the spinner
944
requestNotificationChannel.requestStarted('list');
@@ -348,7 +383,7 @@ angular.module('KMCModule').controller('PlayerListCtrl',
348383
}
349384
});
350385
modal.result.then(function (result) {
351-
if (result && result.result) {
386+
if (result) {
352387
var confirmMsg = $filter('translate')('Do you want to convert this V2 player to a V7 player?<br/><br/>' +
353388
'Player\'s customization and configuration will be lost<br/>' +
354389
'Player\'s embeds will need to be modified.<br/><br/>' +
@@ -405,38 +440,4 @@ angular.module('KMCModule').controller('PlayerListCtrl',
405440
};
406441
}
407442
])
408-
.controller('PlayerUpgradeModeCtrl',
409-
function ($scope, $modalInstance, settings) {
410-
$scope.playerId = '';
411-
$scope.mode = '';
412-
413-
$scope.close = function (result) {
414-
var modalResult = result ? {
415-
result: true,
416-
mode: this.mode,
417-
templateId: Number(this.playerId)
418-
} : {
419-
result: false
420-
};
421-
$modalInstance.close(modalResult);
422-
};
423-
424-
$scope.cancel = function () {
425-
$modalInstance.dismiss('cancel');
426-
};
427-
428-
$scope.validate = function () {
429-
if (this.mode === '') {
430-
return false;
431-
}
432-
433-
if (this.mode === 'template' && (this.playerId === '') || isNaN(this.playerId)) {
434-
return false;
435-
}
436-
437-
return true;
438-
};
439-
440-
angular.extend($scope, settings);
441-
})
442443
;

app/js/services/services.js

Lines changed: 37 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -650,38 +650,44 @@ KMCServices.factory('PlayerDataService', ['apiService', '$q', '$filter',
650650
'uiConf:name': name,
651651
'uiConf:tags': 'kalturaPlayerJs,player,ovp',
652652
'uiConf:config': '{\n' +
653-
' "disableUserCache": false,\n' +
654-
' "plugins": {\n' +
655-
' "kava": {},\n' +
656-
' "playkit-js-hotspots": {},\n' +
657-
' "navigation": {},\n' +
658-
' "playkit-js-transcript": {\n' +
659-
' "position": "bottom",\n' +
660-
' "showTime": true,\n' +
661-
' "expandOnFirstPlay": false,\n' +
662-
' "downloadDisabled": true,\n' +
663-
' "printDisabled": true\n' +
664-
' },\n' +
665-
' "playkit-js-info": {},\n' +
666-
' "dualscreen": {},' +
667-
' "timeline": {},\n' +
668-
' "ivq": {},\n' +
669-
' "kalturaCuepoints": {}' +
670-
' },\n' +
671-
' "viewability": {\n' +
672-
' "playerThreshold": 50\n' +
673-
' },\n' +
674-
' "provider": {\n' +
675-
' "env": {}\n' +
676-
' },\n' +
677-
' "playback": {\n' +
678-
' "enabled": true\n' +
679-
' }\n' +
653+
'\t"disableUserCache": false,\n' +
654+
'\t"plugins": {\n' +
655+
'\t\t"kava": {},\n' +
656+
'\t\t"playkit-js-hotspots": {},\n' +
657+
'\t\t"navigation": {},\n' +
658+
'\t\t"playkit-js-transcript": {\n' +
659+
'\t\t\t"position": "bottom",\n' +
660+
'\t\t\t"showTime": true,\n' +
661+
'\t\t\t"expandOnFirstPlay": false,\n' +
662+
'\t\t\t"downloadDisabled": true,\n' +
663+
'\t\t\t"printDisabled": true\n' +
664+
'\t\t},\n' +
665+
'\t\t"playkit-js-info": {},\n' +
666+
'\t\t"dualscreen": {},\n' +
667+
'\t\t"timeline": {},\n' +
668+
'\t\t"ivq": {},\n' +
669+
'\t\t"kalturaCuepoints": {},\n' +
670+
'\t\t"uiManagers": {},\n' +
671+
'\t\t"playlist": {}\n' +
672+
'\t},\n' +
673+
'\t"viewability": {\n' +
674+
'\t\t"playerThreshold": 50\n' +
675+
'\t},\n' +
676+
'\t"provider": {\n' +
677+
'\t\t"env": {}\n' +
678+
'\t},\n' +
679+
'\t"playback": {\n' +
680+
'\t\t"enabled": true\n' +
681+
'\t},\n' +
682+
'\t"playlist": {\n' +
683+
'\t\t"options": {},\n' +
684+
'\t\t"countdown": {}\n' +
685+
'\t}\n' +
680686
'}',
681-
'uiConf:confVars': '{"versions":{"kaltura-ovp-player":"{latest}","playkit-hotspots":"{latest}",' +
682-
'"playkit-navigation":"{latest}","playkit-transcript":"{latest}","playkit-info":"{latest}",' +
683-
'"playkit-ivq":"{latest}","playkit-timeline":"{latest}","playkit-kaltura-cuepoints":"{latest}",' +
684-
'"playkit-dual-screen":"{latest}"},"langs":["en"]}',
687+
'uiConf:confVars': '{"versions":{"kaltura-ovp-player":"{latest}","playkit-navigation":"{latest}",' +
688+
'"playkit-transcript":"{latest}","playkit-hotspots":"{latest}","playkit-info":"{latest}",' +
689+
'"playkit-dual-screen":"{latest}","playkit-ivq":"{latest}","playkit-playlist":"{latest}",' +
690+
'"playkit-timeline":"{latest}","playkit-kaltura-cuepoints":"{latest}"},"langs":["en"]}',
685691
'uiConf:creationMode': 2,
686692
};
687693

0 commit comments

Comments
 (0)