feat(pagerduty): add client and client_url support for Events API v2#6241
Conversation
af1d6f9 to
564c227
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Add optional client and client_url parameters to the PagerDuty Events API v2 payload, allowing users to configure a clickable link in PagerDuty events. Closes keephq#6233
564c227 to
c3a1f1f
Compare
|
Unit test failure is unrelated to this PR - it's a flaky SQLite locking error during teardown in 938 tests passed, only this one errored due to SQLite concurrency. Could you re-run the failing check? |
|
@shahargl The images/links placement has been reverted back to the original nesting inside |
|
lgtm |
|
I've asked Shahar to have a look when he has time. |
|
🌈 Fantastic work @jyoti369! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
|
Hi @talboren, thanks for merging the PagerDuty Event API enhancement! I see Keep offers bounties for contributions - is there a bounty for this PR that I should expect payment for? |
…eephq#6241) Co-authored-by: Tal <tal@keephq.dev>
|
hey @talboren followin up after a bit. i know keep doesnt run a formal bounty post-acquisition (saw shahars slack note, totally cool). just curious if theres any other way community contributors get recognized for landed work like this - contributor list, swag, anythng? no worries if not, just askin for context |
What
Add optional
clientandclient_urlparameters to the PagerDuty Events API v2 integration, per the Events API v2 spec.These fields allow a clickable "View in [client]" link to appear in PagerDuty event details.
Why
The current Events API implementation is missing
clientandclient_urlattributes. Without them, events created via Keep don't show the monitoring client link in PagerDuty.Changes
clientandclient_urlas optional named parameters in_notify,_send_alert, and_build_alertpayload.payload), matching the API specclient/client_urlincluded when providedclient/client_urlomitted when not providedUsage in workflows
Closes #6233