From 53a88bec948f18dac8da679859fb370bc7673a39 Mon Sep 17 00:00:00 2001 From: chrisnojima Date: Mon, 9 Mar 2026 11:12:38 -0400 Subject: [PATCH] Fix outstanding appendGUILogs session in node process (#29001) The node engine's NativeTransport.packetize_data forwards all responses to the renderer without processing them locally, so RPCs sent from the node process never get responses. The logger's periodic dump was sending appendGUILogs through the node engine, creating a session that stayed outstanding forever. Check process.type to skip log sending in the node (main) process. --- shared/logger/index.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/shared/logger/index.tsx b/shared/logger/index.tsx index 074a79483655..2ec57274e58e 100644 --- a/shared/logger/index.tsx +++ b/shared/logger/index.tsx @@ -109,8 +109,13 @@ class AggregateLoggerImpl { sendLogsToService = async (lines: Array) => { if (!isMobile) { - // don't want main node thread making these calls + // don't want main node thread making these calls — the node engine's + // NativeTransport forwards responses to the renderer without processing + // them locally, so RPCs sent from node never get responses. try { + if (typeof process !== 'undefined' && process.type !== 'renderer') { + return await Promise.resolve() + } const {hasEngine} = require('../engine/require') as {hasEngine: typeof HasEngineType} if (!hasEngine()) { return await Promise.resolve()