Skip to content

Commit e67aaab

Browse files
authored
fix(dingtalk): correctly skip messages when sender info missing (agentscope-ai#851)
1 parent 423387d commit e67aaab

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/copaw/app/channels/dingtalk/content_utils.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,13 @@ def sender_from_chatbot_message(incoming_message: Any) -> tuple[str, bool]:
7979
or ""
8080
)
8181
sender_id = str(sender_id).strip() if sender_id else ""
82-
suffix = sender_id[-4:] if len(sender_id) >= 4 else (sender_id or "????")
83-
sender = f"{(nickname or 'unknown')}#{suffix}"
84-
skip = not suffix and not nickname
82+
has_sender_id = bool(sender_id)
83+
has_nickname = bool(nickname)
84+
85+
suffix = sender_id[-4:] if len(sender_id) >= 4 else sender_id
86+
sender = f"{(nickname or 'unknown')}#{(suffix or '????')}"
87+
88+
skip = (not has_sender_id) and (not has_nickname)
8589
return sender, skip
8690

8791

0 commit comments

Comments
 (0)