Merge pull request #2 from kmuto/takahashim-fix-timeout

fix: add timeout parameter

Author: kmuto

.github/workflows/main.yml

@@ -6,13 +6,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v5
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.4
+        ruby-version: 3.4
     - name: Run the default task
       run: |
-        gem install bundler -v 2.2.5
         bundle install
         bundle exec rake

Gemfile

@@ -4,8 +4,9 @@ source 'https://rubygems.org'
 
 gemspec
 
+gem 'base64'
 gem 'rake', '~> 13.0'
-gem 'rubocop', '~> 1.45.1'
+gem 'rubocop', '~> 1.80.1'
 gem 'rubocop-performance'
 gem 'rubocop-rake'
 gem 'simplecov'

lib/playwrightrunner.rb

@@ -20,15 +20,15 @@ def default_config(config)
     config
   end
 
-  def mermaids_to_images(passed_config, src: '.', dest: '.', type: 'pdf')
+  def mermaids_to_images(passed_config, src: '.', dest: '.', type: 'pdf', timeout: 10_000)
     config = default_config(passed_config)
     Playwright.create(playwright_cli_executable_path: config[:playwright_path]) do |playwright|
-      playwright.chromium.launch(headless: true) do |browser|
+      playwright.chromium.launch(headless: true, timeout: timeout) do |browser|
         page = browser.new_page
         Dir.glob(File.join(src, '*.html')).each do |entry|
           id = File.basename(entry).sub('.html', '')
-          page.goto("file:///#{File.absolute_path(entry)}")
-          page.locator('svg').wait_for(state: 'visible')
+          page.goto("file:///#{File.absolute_path(entry)}", timeout: timeout)
+          page.locator('svg').wait_for(state: 'visible', timeout: timeout)
           sleep(1)
           1.upto(4) do
             bounds = page.locator('svg').bounding_box
@@ -46,7 +46,8 @@ def mermaids_to_images(passed_config, src: '.', dest: '.', type: 'pdf')
               page.set_viewport_size({ width: x + width, height: y + height })
 
               if type == 'png'
-                page.screenshot(path: File.join(dest, "#{id}.png"), clip: { x: x, y: y, width: width, height: height })
+                page.screenshot(path: File.join(dest, "#{id}.png"), clip: { x: x, y: y, width: width, height: height },
+                                timeout: timeout)
                 break
               end
 

playwright-runner.gemspec

@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'playwright-ruby-client', '~> 1.0'
+  spec.add_dependency 'playwright-ruby-client', '>= 1.28.0'
 end

test/test_mermaid.rb

@@ -6,6 +6,7 @@
 class PlaywrightRunnerMermaidTest < Test::Unit::TestCase
   def setup
     system('npm install playwright') unless File.exist?('./node_modules/.bin/playwright')
+    system('npx playwright install chromium')
     FileUtils.rm_rf('test/assets/dest')
     FileUtils.mkdir('test/assets/dest')
   end