Skip to content

Commit 1a884eb

Browse files
authored
Consistent parenthesis use in Makefile (sigstore#700)
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
1 parent 97a5558 commit 1a884eb

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,13 @@ deploy:
125125
LDFLAGS="$(SERVER_LDFLAGS)" GIT_HASH=$(GIT_HASH) GIT_VERSION=$(GIT_VERSION) ko apply -f config/
126126

127127
sign-container: ko
128-
cosign sign --key .github/workflows/cosign.key -a GIT_HASH=$(GIT_HASH) ${KO_DOCKER_REPO}/rekor-server:$(GIT_HASH)
129-
cosign sign --key .github/workflows/cosign.key -a GIT_HASH=$(GIT_HASH) ${KO_DOCKER_REPO}/rekor-cli:$(GIT_HASH)
128+
cosign sign --key .github/workflows/cosign.key -a GIT_HASH=$(GIT_HASH) $(KO_DOCKER_REPO)/rekor-server:$(GIT_HASH)
129+
cosign sign --key .github/workflows/cosign.key -a GIT_HASH=$(GIT_HASH) $(KO_DOCKER_REPO)/rekor-cli:$(GIT_HASH)
130130

131131
.PHONY: sign-keyless-ci
132132
sign-keyless-ci: ko
133-
cosign sign --force -a GIT_HASH=$(GIT_HASH) ${KO_DOCKER_REPO}/rekor-server:$(GIT_HASH)
134-
cosign sign --force -a GIT_HASH=$(GIT_HASH) ${KO_DOCKER_REPO}/rekor-cli:$(GIT_HASH)
133+
cosign sign --force -a GIT_HASH=$(GIT_HASH) $(KO_DOCKER_REPO)/rekor-server:$(GIT_HASH)
134+
cosign sign --force -a GIT_HASH=$(GIT_HASH) $(KO_DOCKER_REPO)/rekor-cli:$(GIT_HASH)
135135

136136
.PHONY: ko-local
137137
ko-local:
@@ -173,8 +173,8 @@ $(SWAGGER): $(TOOLS_DIR)/go.mod
173173

174174
help: # Display help
175175
@awk -F ':|##' \
176-
'/^[^\t].+?:.*?##/ {\
176+
'/^[^\t].+?:.*?##/ (\
177177
printf "\033[36m%-30s\033[0m %s\n", $$1, $$NF \
178-
}' $(MAKEFILE_LIST) | sort
178+
)' $(MAKEFILE_LIST) | sort
179179

180180
include release/release.mk

release/release.mk

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ snapshot:
1818

1919
.PHONY: sign-rekor-server-release
2020
sign-rekor-server-release:
21-
cosign sign --key "gcpkms://projects/${PROJECT_ID}/locations/${KEY_LOCATION}/keyRings/${KEY_RING}/cryptoKeys/${KEY_NAME}/versions/${KEY_VERSION}" -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) ${KO_PREFIX}/rekor-server:$(GIT_VERSION)
21+
cosign sign --key "gcpkms://projects/$(PROJECT_ID)/locations/$(KEY_LOCATION)/keyRings/$(KEY_RING)/cryptoKeys/$(KEY_NAME)/versions/$(KEY_VERSION)" -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) $(KO_PREFIX)/rekor-server:$(GIT_VERSION)
2222

2323
.PHONY: sign-rekor-cli-release
2424
sign-rekor-cli-release:
25-
cosign sign --key "gcpkms://projects/${PROJECT_ID}/locations/${KEY_LOCATION}/keyRings/${KEY_RING}/cryptoKeys/${KEY_NAME}/versions/${KEY_VERSION}" -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) ${KO_PREFIX}/rekor-cli:$(GIT_VERSION)
25+
cosign sign --key "gcpkms://projects/$(PROJECT_ID)/locations/$(KEY_LOCATION)/keyRings/$(KEY_RING)/cryptoKeys/$(KEY_NAME)/versions/$(KEY_VERSION)" -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) $(KO_PREFIX)/rekor-cli:$(GIT_VERSION)
2626

2727
.PHONY: sign-container-release
2828
sign-container-release: ko sign-rekor-server-release sign-rekor-cli-release
@@ -33,11 +33,11 @@ sign-container-release: ko sign-rekor-server-release sign-rekor-cli-release
3333

3434
.PHONY: sign-keyless-rekor-server-release
3535
sign-keyless-rekor-server-release:
36-
cosign sign --force -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) ${KO_PREFIX}/rekor-server:$(GIT_VERSION)
36+
cosign sign --force -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) $(KO_PREFIX)/rekor-server:$(GIT_VERSION)
3737

3838
.PHONY: sign-keyless-rekor-cli-release
3939
sign-keyless-rekor-cli-release:
40-
cosign sign --force -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) ${KO_PREFIX}/rekor-cli:$(GIT_VERSION)
40+
cosign sign --force -a GIT_HASH=$(GIT_HASH) -a GIT_VERSION=$(GIT_VERSION) $(KO_PREFIX)/rekor-cli:$(GIT_VERSION)
4141

4242
.PHONY: sign-keyless-release
4343
sign-keyless-release: sign-keyless-rekor-server-release sign-keyless-rekor-cli-release

0 commit comments

Comments
 (0)