Skip to content

Support functionConfig per the spec.#3

Merged
frankfarzan merged 5 commits into
kptdev:masterfrom
frankfarzan:functionConfig
Dec 21, 2019
Merged

Support functionConfig per the spec.#3
frankfarzan merged 5 commits into
kptdev:masterfrom
frankfarzan:functionConfig

Conversation

@frankfarzan
Copy link
Copy Markdown
Contributor

@frankfarzan frankfarzan commented Dec 20, 2019

- Now any object kind can be passed as functionConfig.
- Provide convinient CLI option to passing functionConfig as a file
- Provide convinient CLI optoin to passing key/value if functionConfig
is a ConfigMap and provide corresponding Configs methods
- Add 'usage' property to KptFunc interface.
- Remove kubelinter for now.

- Now object kind can be passed as functionConfig.
- Provide convinient CLI option to passing functionConfig as a file
- Provide convinient CLI optoin to passing key/value if functionConfig
is a ConfigMap and Configs methods
- Add 'usage' property to KptFunc interface.
- Remove kubelinter for now.
Copy link
Copy Markdown
Contributor

@prachirp prachirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP, will follow up about changes to run and types.

Comment thread README.md
Comment thread README.md
Comment thread ts/kpt-functions/src/io.ts Outdated
Comment thread ts/kpt-functions/src/io.ts
Comment thread ts/kpt-functions/src/io.ts
Comment thread ts/kpt-functions/src/io.ts
@frankfarzan frankfarzan merged commit e995c10 into kptdev:master Dec 21, 2019
frankfarzan added a commit to kptdev/krm-functions-catalog that referenced this pull request Dec 21, 2019
* Support functionConfig per the spec.

kptdev/krm-functions-sdk#3

* Publish packages.
efiacor added a commit to Nordix/krm-functions-sdk that referenced this pull request May 7, 2026
- --help now always takes precedence over --doc regardless of arg order
- Updated AsMain doc comment to document all invocation modes
- Removed no-op strings.TrimPrefix in test assertion

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
efiacor added a commit to Nordix/krm-functions-sdk that referenced this pull request May 7, 2026
- --help now always takes precedence over --doc regardless of arg order
- Updated AsMain doc comment to document all invocation modes
- Removed no-op strings.TrimPrefix in test assertion

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
efiacor added a commit to Nordix/krm-functions-sdk that referenced this pull request May 7, 2026
- --help now always takes precedence over --doc regardless of arg order
- Updated AsMain doc comment to document all invocation modes
- Removed no-op strings.TrimPrefix in test assertion

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants