[release-1.4] fix: avoid configError when logging EndpointPickerConfig#2626
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:release-1.4from Mar 19, 2026
Merged
Conversation
* chore: improve EPP startup logging for config * refactor: optimize string formatting in `String()` methods and update `reflect.TypeOf` usage. * rebase and resolve conflicts (cherry picked from commit f56818d) Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Adjust the cherry-picked stringer cleanup to match the release-1.4 API surface by removing main-only parser handling and using the branch's existing int64 maxBytes fields. Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Backports commit f56818d from
maintorelease-1.4so EPP logs the effectiveEndpointPickerConfigas a plain string instead of triggering a misleadingconfigError. This includes a small release-1.4 compatibility follow-up for types that differ frommain.Which issue(s) this PR fixes:
Fixes: #2622
Does this PR introduce a user-facing change?: