refactor(bbr): move test helpers into plugins/test#2627
refactor(bbr): move test helpers into plugins/test#2627k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @yehuditkerido. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
nirrozenbaum
left a comment
There was a problem hiding this comment.
/lgtm
/approve
thanks 🙏
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, yehuditkerido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yehuditkerido I think it's required to rebase. |
Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
84340f8 to
73e03cf
Compare
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Move
pkg/bbr/test/intopkg/bbr/plugins/test/so test helpers live alongside the plugin code they support. Renamehelpers.gotobase_model_plugin.goto reflect its content, and drop thebbrtestimport alias in favor of the directory-derivedtestpackage name.Does this PR introduce a user-facing change?:
None