Skip to content

refactor(bbr): move test helpers into plugins/test#2627

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
yehuditkerido:tests-cleanup
Mar 19, 2026
Merged

refactor(bbr): move test helpers into plugins/test#2627
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
yehuditkerido:tests-cleanup

Conversation

@yehuditkerido
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move pkg/bbr/test/ into pkg/bbr/plugins/test/ so test helpers live alongside the plugin code they support. Rename helpers.go to base_model_plugin.go to reflect its content, and drop the bbrtest import alias in favor of the directory-derived test package name.

Does this PR introduce a user-facing change?:
None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 19, 2026
@netlify
Copy link

netlify bot commented Mar 19, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 73e03cf
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69bbb363af0f1d00085868ef
😎 Deploy Preview https://deploy-preview-2627--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and shmuelk March 19, 2026 07:09
@k8s-ci-robot
Copy link
Contributor

Hi @yehuditkerido. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2026
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2026
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 🙏

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, yehuditkerido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026
@nirrozenbaum
Copy link
Contributor

@yehuditkerido I think it's required to rebase.

Signed-off-by: Yehudit Kerido <yehudit1987@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2026
@nirrozenbaum
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2026
@k8s-ci-robot k8s-ci-robot merged commit c24b5b7 into kubernetes-sigs:main Mar 19, 2026
11 checks passed
@yehuditkerido yehuditkerido deleted the tests-cleanup branch March 19, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants