Docs: Windows CPU and Memory Affinity by jsturtevant · Pull Request #48469 · kubernetes/website

jsturtevant · 2024-10-21T16:57:02Z

Description

Place holder for kubernetes/enhancements#4885

kubernetes/kubernetes#125296
kubernetes/kubernetes#124285
opencontainers/runtime-spec#1258

Issue

netlify · 2024-10-21T16:57:23Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`7f411ed`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/673ffcb7f4bba50008d9f5da

netlify · 2024-10-21T17:06:37Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7f411ed`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673ffcb7a060ec000817c6c1
😎 Deploy Preview	https://deploy-preview-48469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat · 2024-10-21T17:44:39Z

/sig windows
/sig node

chanieljdan · 2024-11-06T00:56:18Z

Hi @jsturtevant 👋

Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.

Thank you!

chanieljdan · 2024-11-10T01:35:00Z

Hi @jsturtevant 👋 ,

A quick reminder to get your PR ready for review before the deadline, Tuesday November 19th at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.

Thank you!

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Qiming Teng <tengqm@outlook.com> Co-authored-by: Aravindh Puthiyaparambil <aravindhp@users.noreply.github.com>

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

ffromani

LGTM from sig-node, the docs technical content looks correct and reflecting what we did.

…es.md Co-authored-by: Qiming Teng <tengqm@outlook.com>

jsturtevant · 2024-11-21T23:03:57Z

/assign @tengqm

jsturtevant · 2024-11-21T23:07:01Z

/assign @marosset @aravindhp

tengqm

LGTM other than some nits.

…es.md Co-authored-by: Qiming Teng <tengqm@outlook.com>

Co-authored-by: Qiming Teng <tengqm@outlook.com>

chanieljdan · 2024-11-22T13:53:12Z

Technical LGTM provided above

/lgtm

k8s-ci-robot · 2024-11-22T13:53:20Z

LGTM label has been added.

Details

Git tree hash: 638adb68cc2ba994b76e4a31f1dea65c6ae3f970

chanieljdan · 2024-11-22T13:54:03Z

@tengqm could we get your final review/approval on this one? thanks!

marosset

/lgtm from sig-windows

chanieljdan · 2024-11-25T21:05:01Z

Technical and Docs LGTM noted above

/approve

k8s-ci-robot · 2024-11-25T21:05:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanieljdan, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [chanieljdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added this to the 1.32 milestone Oct 21, 2024

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024

k8s-ci-robot requested a review from derekwaynecarr October 21, 2024 16:57

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 21, 2024

k8s-ci-robot requested a review from sjenning October 21, 2024 16:57

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024

jsturtevant mentioned this pull request Oct 21, 2024

Windows CPU and Memory Affinity kubernetes/enhancements#4885

Open

9 tasks

jsturtevant marked this pull request as draft October 21, 2024 17:01

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024

k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 21, 2024

jsturtevant marked this pull request as ready for review October 22, 2024 20:19

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024

k8s-ci-robot requested a review from klueska October 22, 2024 20:19

jsturtevant marked this pull request as draft October 22, 2024 20:19

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024

marosset mentioned this pull request Nov 8, 2024

Memory manager support for Windows nodes kubernetes/kubernetes#128560

Merged

Add docs for Windows CPU and Memory Managers

e2cccab

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

jsturtevant force-pushed the win-mem-cpu-feautre branch from 54b8708 to e2cccab Compare November 18, 2024 22:59

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024

jsturtevant marked this pull request as ready for review November 18, 2024 23:04

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024

k8s-ci-robot requested a review from bg-chun November 18, 2024 23:04

tengqm reviewed Nov 19, 2024

View reviewed changes

marosset reviewed Nov 19, 2024

View reviewed changes

Comment thread ...docs/reference/command-line-tools-reference/feature-gates/windows-cpu-and-memory-affinity.md

marosset reviewed Nov 19, 2024

View reviewed changes

Comment thread content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated

Apply suggestions from code review

ce1491d

Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Qiming Teng <tengqm@outlook.com> Co-authored-by: Aravindh Puthiyaparambil <aravindhp@users.noreply.github.com>

jsturtevant force-pushed the win-mem-cpu-feautre branch from 342bba2 to ba31359 Compare November 19, 2024 22:24

Updates based on feedback

bdc9bef

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

jsturtevant force-pushed the win-mem-cpu-feautre branch from ba31359 to bdc9bef Compare November 19, 2024 22:25

ffromani reviewed Nov 21, 2024

View reviewed changes

ffromani mentioned this pull request Nov 21, 2024

node: start moving the resource management docs to concepts #48797

Merged

Update content/en/docs/tasks/administer-cluster/cpu-management-polici…

bd84bba

…es.md Co-authored-by: Qiming Teng <tengqm@outlook.com>

k8s-ci-robot assigned tengqm Nov 21, 2024

k8s-ci-robot assigned aravindhp and marosset Nov 21, 2024

tengqm reviewed Nov 22, 2024

View reviewed changes

Comment thread content/en/docs/tasks/administer-cluster/cpu-management-policies.md Outdated

Comment thread content/en/docs/tasks/administer-cluster/memory-manager.md Outdated

Comment thread content/en/docs/tasks/administer-cluster/topology-manager.md Outdated

jsturtevant and others added 3 commits November 21, 2024 19:37

Update content/en/docs/tasks/administer-cluster/cpu-management-polici…

6ca0d52

…es.md Co-authored-by: Qiming Teng <tengqm@outlook.com>

Update content/en/docs/tasks/administer-cluster/memory-manager.md

0867522

Co-authored-by: Qiming Teng <tengqm@outlook.com>

Update content/en/docs/tasks/administer-cluster/topology-manager.md

7f411ed

Co-authored-by: Qiming Teng <tengqm@outlook.com>

k8s-ci-robot assigned chanieljdan Nov 22, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024

marosset approved these changes Nov 22, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024

k8s-ci-robot merged commit 64ac7c4 into kubernetes:dev-1.32 Nov 25, 2024

Conversation

jsturtevant commented Oct 21, 2024

Description

Issue

Uh oh!

netlify Bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

netlify Bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

dipesh-rawat commented Oct 21, 2024

Uh oh!

chanieljdan commented Nov 6, 2024

Uh oh!

chanieljdan commented Nov 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

jsturtevant commented Nov 21, 2024

Uh oh!

jsturtevant commented Nov 21, 2024

Uh oh!

tengqm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chanieljdan commented Nov 22, 2024

Uh oh!

k8s-ci-robot commented Nov 22, 2024

Uh oh!

chanieljdan commented Nov 22, 2024

Uh oh!

marosset left a comment

Choose a reason for hiding this comment

Uh oh!

chanieljdan commented Nov 25, 2024

Uh oh!

k8s-ci-robot commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

netlify Bot commented Oct 21, 2024 •

edited

Loading

netlify Bot commented Oct 21, 2024 •

edited

Loading