chore: log Ray Pool run batches#4854
Draft
hfutatzhanghb wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_batchbusiness batch.Why
The index helper submits
fragment_batchestoray.util.multiprocessing.Pool.map_async(..., chunksize=1). In Ray Pool, each submitted chunk is executed byPoolActor.run_batch. Withchunksize=1, eachrun_batchcontains one balanced fragment batch.For large vector index builds, these batches can be memory-heavy or long-running. Bracketing each business batch with info-level logs makes it easier to identify which fragment batch is starting, which one completed, and what status it returned, without logging an unbounded list of fragment IDs.
Validation
python -m py_compile lance_ray/index.py tests/test_vector_index_options.pypython -m pytest tests/test_vector_index_options.pyuv run --no-sync ruff check lance_ray/index.py tests/test_vector_index_options.pygit diff --check